add out to sin function (#727)

Author: KsanaKozlova

dpnp/dpnp_algo/dpnp_algo_trigonometric.pyx

@@ -142,8 +142,32 @@ cpdef dparray dpnp_radians(dparray x1):
     return call_fptr_1in_1out(DPNP_FN_RADIANS, x1, x1.shape)
 
 
-cpdef dparray dpnp_sin(dparray x1):
-    return call_fptr_1in_1out(DPNP_FN_SIN, x1, x1.shape)
+cpdef dparray dpnp_sin(dparray x1, dparray out=None):
+
+    cdef DPNPFuncType param1_type = dpnp_dtype_to_DPNPFuncType(x1.dtype)
+
+    cdef DPNPFuncData kernel_data = get_dpnp_function_ptr(DPNP_FN_SIN, param1_type, param1_type)
+
+    result_type = dpnp_DPNPFuncType_to_dtype(< size_t > kernel_data.return_type)
+
+    shape_result = x1.shape
+
+    cdef dparray result
+
+    if out is not None:
+        if out.dtype != result_type:
+            checker_throw_value_error('sin', 'out.dtype', out.dtype, result_type)
+        if out.shape != shape_result:
+            checker_throw_value_error('sin', 'out.shape', out.shape, shape_result)
+        result = out
+    else:
+        result = dparray(shape_result, dtype=result_type)
+
+    cdef fptr_1in_1out_t func = <fptr_1in_1out_t > kernel_data.ptr
+
+    func(x1.get_data(), result.get_data(), x1.size)
+
+    return result
 
 
 cpdef dparray dpnp_sinh(dparray x1):

dpnp/dpnp_iface_trigonometric.py

@@ -881,15 +881,18 @@ def radians(x1):
     return dpnp_radians(x1)
 
 
-def sin(x1):
+def sin(x1, out=None, **kwargs):
     """
     Trigonometric sine, element-wise.
 
     For full documentation refer to :obj:`numpy.sin`.
 
     Limitations
     -----------
-    Input array is supported as :obj:`dpnp.ndarray`.
+    Parameters ``x1`` is supported as :obj:`dpnp.ndarray`.
+    Parameter ``out`` is supported as default value ``None``.
+    Keyword arguments ``kwargs`` are currently unsupported.
+    Otherwise the functions will be executed sequentially on CPU.
     Input array data types are limited by supported DPNP :ref:`Data types`.
 
     See Also
@@ -908,14 +911,15 @@ def sin(x1):
     [0.0, 1.0, 1.2246467991473532e-16]
 
     """
+    if not use_origin_backend(x1) and not kwargs:
+        if not isinstance(x1, dparray):
+            pass
+        elif out is not None and not isinstance(out, dparray):
+            pass
+        else:
+            return dpnp_sin(x1, out=out)
 
-    if (use_origin_backend(x1)):
-        return numpy.sin(x1)
-
-    if not isinstance(x1, dparray):
-        raise TypeError(f"DPNP sin(): Unsupported x1={type(x1)}")
-
-    return dpnp_sin(x1)
+    return call_origin(numpy.sin, x1, out=out, **kwargs)
 
 
 def sinh(x1):

tests/test_umath.py

@@ -71,3 +71,19 @@ def test_umaths(test_cases):
     result = getattr(dpnp, umath)(*iargs)
 
     numpy.testing.assert_allclose(result, expected, rtol=1e-6)
+
+
+def test_sin():
+    array_data = numpy.arange(10)
+    out = numpy.empty(10, dtype=numpy.float64)
+
+    # DPNP
+    dp_array = dpnp.array(array_data, dtype=dpnp.float64)
+    dp_out = dpnp.array(out, dtype=dpnp.float64)
+    result = dpnp.sin(dp_array, out=dp_out)
+
+    # original
+    np_array = numpy.array(array_data, dtype=numpy.float64)
+    expected = numpy.sin(np_array, out=out)
+
+    numpy.testing.assert_array_equal(expected, result)