Skip to content

Commit f954927

Browse files
committed
update existing tests for binary ufuncs
1 parent a51968f commit f954927

File tree

1 file changed

+22
-22
lines changed

1 file changed

+22
-22
lines changed

dpnp/tests/test_binary_ufuncs.py

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -131,12 +131,12 @@ def test_invalid_shape(self, shape):
131131
@pytest.mark.parametrize("xp", [dpnp, numpy])
132132
@pytest.mark.parametrize(
133133
"out",
134-
[4, (), [], (3, 7), [2, 4]],
135-
ids=["scalar", "empty_tuple", "empty_list", "tuple", "list"],
134+
[4, [], range(2), [2, 4]],
135+
ids=["scalar", "empty_list", "range", "list"],
136136
)
137-
def test_invalid_out(self, xp, out):
137+
def test_invalid_out_type(self, xp, out):
138138
a = xp.arange(10)
139-
assert_raises(TypeError, xp.add, a, 2, out)
139+
assert_raises(TypeError, xp.add, a, 2, out=out)
140140

141141

142142
@pytest.mark.parametrize("func", ["fmax", "fmin", "maximum", "minimum"])
@@ -178,10 +178,10 @@ def test_invalid_shape(self, func, shape):
178178
@pytest.mark.parametrize("xp", [dpnp, numpy])
179179
@pytest.mark.parametrize(
180180
"out",
181-
[4, (), [], (3, 7), [2, 4]],
182-
ids=["scalar", "empty_tuple", "empty_list", "tuple", "list"],
181+
[4, [], range(2), [2, 4]],
182+
ids=["scalar", "empty_list", "range", "list"],
183183
)
184-
def test_invalid_out(self, func, xp, out):
184+
def test_invalid_out_type(self, func, xp, out):
185185
a = xp.arange(10)
186186
assert_raises(TypeError, getattr(xp, func), a, 2, out)
187187

@@ -269,10 +269,10 @@ def test_invalid_shape(self, shape):
269269
@pytest.mark.parametrize("xp", [dpnp, numpy])
270270
@pytest.mark.parametrize(
271271
"out",
272-
[4, (), [], (3, 7), [2, 4]],
273-
ids=["scalar", "empty_tuple", "empty_list", "tuple", "list"],
272+
[4, [], range(2), [2, 4]],
273+
ids=["scalar", "empty_list", "range", "list"],
274274
)
275-
def test_invalid_out(self, xp, out):
275+
def test_invalid_out_type(self, xp, out):
276276
a = xp.arange(10)
277277
assert_raises(TypeError, xp.divide, a, 2, out)
278278

@@ -364,10 +364,10 @@ def test_invalid_shape(self, func, shape):
364364
@pytest.mark.parametrize("xp", [dpnp, numpy])
365365
@pytest.mark.parametrize(
366366
"out",
367-
[4, (), [], (3, 7), [2, 4]],
368-
ids=["scalar", "empty_tuple", "empty_list", "tuple", "list"],
367+
[4, [], range(2), [2, 4]],
368+
ids=["scalar", "empty_list", "range", "list"],
369369
)
370-
def test_invalid_out(self, func, xp, out):
370+
def test_invalid_out_type(self, func, xp, out):
371371
a = xp.arange(10)
372372
assert_raises(TypeError, getattr(xp, func), a, 2, out)
373373

@@ -645,10 +645,10 @@ def test_invalid_shape(self, shape):
645645
@pytest.mark.parametrize("xp", [dpnp, numpy])
646646
@pytest.mark.parametrize(
647647
"out",
648-
[4, (), [], (3, 7), [2, 4]],
649-
ids=["scalar", "empty_tuple", "empty_list", "tuple", "list"],
648+
[4, [], range(2), [2, 4]],
649+
ids=["scalar", "empty_list", "range", "list"],
650650
)
651-
def test_invalid_out(self, xp, out):
651+
def test_invalid_out_type(self, xp, out):
652652
a = xp.arange(10)
653653
assert_raises(TypeError, xp.multiply, a, 2, out)
654654

@@ -907,10 +907,10 @@ def test_invalid_shape(self, shape):
907907
@pytest.mark.parametrize("xp", [dpnp, numpy])
908908
@pytest.mark.parametrize(
909909
"out",
910-
[4, (), [], (3, 7), [2, 4]],
911-
ids=["scalar", "empty_tuple", "empty_list", "tuple", "list"],
910+
[4, [], range(2), [2, 4]],
911+
ids=["scalar", "empty_list", "range", "list"],
912912
)
913-
def test_invalid_out(self, xp, out):
913+
def test_invalid_out_type(self, xp, out):
914914
a = xp.arange(10)
915915
assert_raises(TypeError, xp.power, a, 2, out)
916916

@@ -1123,9 +1123,9 @@ def test_invalid_shape(self, shape):
11231123
@pytest.mark.parametrize("xp", [dpnp, numpy])
11241124
@pytest.mark.parametrize(
11251125
"out",
1126-
[4, (), [], (3, 7), [2, 4]],
1127-
ids=["scalar", "empty_tuple", "empty_list", "tuple", "list"],
1126+
[4, [], range(2), [2, 4]],
1127+
ids=["scalar", "empty_list", "range", "list"],
11281128
)
1129-
def test_invalid_out(self, xp, out):
1129+
def test_invalid_out_type(self, xp, out):
11301130
a = xp.arange(10)
11311131
assert_raises(TypeError, xp.subtract, a, 2, out)

0 commit comments

Comments
 (0)