From 0e8afc400b8d6b877049bf4ec34965e9f1a50036 Mon Sep 17 00:00:00 2001 From: Anton Volkov Date: Thu, 15 May 2025 21:33:30 +0200 Subject: [PATCH 1/2] Temporary disable failing test for NaN input passed to dpnp.linalg.cond --- dpnp/tests/test_linalg.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/dpnp/tests/test_linalg.py b/dpnp/tests/test_linalg.py index b5bae6c51181..fe8f79312401 100644 --- a/dpnp/tests/test_linalg.py +++ b/dpnp/tests/test_linalg.py @@ -6,7 +6,6 @@ from dpctl.utils import ExecutionPlacementError from numpy.testing import ( assert_allclose, - assert_almost_equal, assert_array_equal, assert_equal, assert_raises, @@ -20,12 +19,13 @@ assert_dtype_allclose, generate_random_numpy_array, get_all_dtypes, - get_complex_dtypes, get_float_complex_dtypes, get_integer_float_dtypes, has_support_aspect64, is_cpu_device, is_cuda_device, + is_gpu_device, + is_win_platform, numpy_version, ) from .third_party.cupy import testing @@ -334,6 +334,12 @@ def test_nan(self, p): # while OneMKL returns nans if is_cuda_device() and p in [-dpnp.inf, -1, 1, dpnp.inf, "fro"]: pytest.skip("Different behavior on CUDA") + elif ( + is_gpu_device() + and is_win_platform() + and p in [-dpnp.inf, -1, 1, dpnp.inf, "fro"] + ): + pytest.skip("SAT-7966") a = generate_random_numpy_array((2, 2, 2, 2)) a[0, 0] = 0 a[1, 1] = 0 From 14bdacca5e9c73e58ce9bf918066646882b15f2a Mon Sep 17 00:00:00 2001 From: Anton Volkov Date: Thu, 15 May 2025 21:34:15 +0200 Subject: [PATCH 2/2] Improve error tracing by adding missing space --- dpnp/backend/extensions/lapack/getrf_batch.cpp | 2 +- dpnp/backend/extensions/lapack/getri_batch.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dpnp/backend/extensions/lapack/getrf_batch.cpp b/dpnp/backend/extensions/lapack/getrf_batch.cpp index ea48b773ac84..049d89acb02c 100644 --- a/dpnp/backend/extensions/lapack/getrf_batch.cpp +++ b/dpnp/backend/extensions/lapack/getrf_batch.cpp @@ -116,7 +116,7 @@ static sycl::event getrf_batch_impl(sycl::queue &exec_q, auto error_matrices_ids_size = error_matrices_ids.size(); auto dev_info_size = static_cast(py::len(dev_info)); if (error_matrices_ids_size != dev_info_size) { - throw py::value_error("The size of `dev_info` must be equal to" + + throw py::value_error("The size of `dev_info` must be equal to " + std::to_string(error_matrices_ids_size) + ", but currently it is " + std::to_string(dev_info_size) + "."); diff --git a/dpnp/backend/extensions/lapack/getri_batch.cpp b/dpnp/backend/extensions/lapack/getri_batch.cpp index e4c0c16f5b6b..53e9059afeaf 100644 --- a/dpnp/backend/extensions/lapack/getri_batch.cpp +++ b/dpnp/backend/extensions/lapack/getri_batch.cpp @@ -114,7 +114,7 @@ static sycl::event getri_batch_impl(sycl::queue &exec_q, auto error_matrices_ids_size = error_matrices_ids.size(); auto dev_info_size = static_cast(py::len(dev_info)); if (error_matrices_ids_size != dev_info_size) { - throw py::value_error("The size of `dev_info` must be equal to" + + throw py::value_error("The size of `dev_info` must be equal to " + std::to_string(error_matrices_ids_size) + ", but currently it is " + std::to_string(dev_info_size) + ".");