Skip to content

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 23, 2025

The PR adds support of pad_width keyword as a dictionary to align with the behavior in numpy.pad function.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.19.0 release milestone Jul 23, 2025
@antonwolfy antonwolfy self-assigned this Jul 23, 2025
Copy link
Contributor

github-actions bot commented Jul 23, 2025

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Copy link
Contributor

github-actions bot commented Jul 23, 2025

Array API standard conformance tests for dpnp=0.19.0dev3=py313h509198e_26 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

coveralls commented Jul 23, 2025

Coverage Status

coverage: 71.551% (-0.03%) from 71.582%
when pulling 0775690 on numpy_pad_dict
into 9a9f5d0 on master.

Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 1daf4c9 into master Sep 5, 2025
68 of 73 checks passed
@antonwolfy antonwolfy deleted the numpy_pad_dict branch September 5, 2025 12:21
github-actions bot added a commit that referenced this pull request Sep 5, 2025
The PR adds support of `pad_width` keyword as a dictionary to align with
the behavior in `numpy.pad` function. 1daf4c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants