Skip to content

Remove workflow trigger on change in branch protection rules #2574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2025
Merged

Remove workflow trigger on change in branch protection rules #2574

merged 2 commits into from
Sep 5, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Sep 3, 2025 •
edited
Loading

There is no need to trigger workflows with Autoupdate pre-commit and Run tests suite on any change in branch protection rules. That trigger was intended only to Scorecard supply-chain security workflow.
Thus the PR removes that triggers.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy self-assigned this Sep 3, 2025
@antonwolfy antonwolfy added this to the 0.19.0 release milestone Sep 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.19.0dev3=py313h509198e_22 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

coveralls commented Sep 3, 2025 •
edited
Loading

Coverage Status

coverage: 71.582%. remained the same
when pulling 4bc7f65 on remove-excess-triggers
into c9b9f70 on master.

vlad-perevezentsev
vlad-perevezentsev approved these changes Sep 5, 2025
View reviewed changes
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 9a9f5d0 into master Sep 5, 2025
70 of 74 checks passed
@antonwolfy antonwolfy deleted the remove-excess-triggers branch September 5, 2025 10:25
github-actions bot added a commit that referenced this pull request Sep 5, 2025
@github-actions
Remove workflow trigger on change in branch protection rules (#2574)
6e05f08 
There is no need to trigger workflows with `Autoupdate pre-commit` and
`Run tests suite` on any change in branch protection rules. That trigger
was intended only to `Scorecard supply-chain security` workflow.
Thus the PR removes that triggers. 9a9f5d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov

@vtavana vtavana Awaiting requested review from vtavana

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels

None yet

Projects

None yet

Milestone

0.19.0 release

Development

Successfully merging this pull request may close these issues.

3 participants

@antonwolfy @coveralls @vlad-perevezentsev