Skip to content

Commit 110f02f

Browse files
author
Vahid Tavanashad
committed
address comments
1 parent 2db04e6 commit 110f02f

File tree

1 file changed

+17
-14
lines changed

1 file changed

+17
-14
lines changed

mkl_umath/src/mkl_umath_loops.c.src

Lines changed: 17 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -317,7 +317,8 @@ mkl_umath_@TYPE@_exp(char **args, const npy_intp *dimensions, const npy_intp *st
317317
can_vectorize
318318
,
319319
const @type@ in1 = *(@type@ *)ip1;
320-
ignore_fpstatus = npy_isnan(in1) || in1 == NPY_INFINITY || in1 == -NPY_INFINITY;
320+
const int invalid_cases = npy_isnan(in1) || in1 == NPY_INFINITY || in1 == -NPY_INFINITY;
321+
ignore_fpstatus |= invalid_cases;
321322
*(@type@ *)op1 = @scalarf@(in1);
322323
)
323324
}
@@ -355,7 +356,8 @@ mkl_umath_@TYPE@_exp2(char **args, const npy_intp *dimensions, const npy_intp *s
355356
can_vectorize
356357
,
357358
const @type@ in1 = *(@type@ *)ip1;
358-
ignore_fpstatus = npy_isnan(in1) || in1 == NPY_INFINITY || in1 == -NPY_INFINITY;
359+
const int invalid_cases = npy_isnan(in1) || in1 == NPY_INFINITY || in1 == -NPY_INFINITY;
360+
ignore_fpstatus |= invalid_cases;
359361
*(@type@ *)op1 = @scalarf@(in1);
360362
)
361363
}
@@ -492,7 +494,8 @@ mkl_umath_@TYPE@_log2(char **args, const npy_intp *dimensions, const npy_intp *s
492494
can_vectorize
493495
,
494496
const @type@ in1 = *(@type@ *)ip1;
495-
ignore_fpstatus = in1 < 0 || in1 == 0 || npy_isnan(in1) || in1 == -NPY_INFINITY;
497+
const int invalid_cases = in1 < 0 || in1 == 0 || npy_isnan(in1) || in1 == -NPY_INFINITY;
498+
ignore_fpstatus |= invalid_cases;
496499
*(@type@ *)op1 = @scalarf@(in1);
497500
)
498501
}
@@ -2122,9 +2125,10 @@ mkl_umath_@TYPE@_remainder(char **args, const npy_intp *dimensions, const npy_in
21222125
BINARY_LOOP {
21232126
const @type@ in1 = *(@type@ *)ip1;
21242127
const @type@ in2 = *(@type@ *)ip2;
2125-
ignore_fpstatus = !npy_isnan(in1) && in2 == 0;
2126-
ignore_fpstatus |= (in1 == NPY_INFINITY || in1 == -NPY_INFINITY) && !npy_isnan(in2);
2127-
ignore_fpstatus |= (in1 != NPY_INFINITY && in1 != -NPY_INFINITY) && (in2 == NPY_INFINITY || in2 == -NPY_INFINITY);
2128+
int invalid_cases = !npy_isnan(in1) && in2 == 0;
2129+
invalid_cases |= (in1 == NPY_INFINITY || in1 == -NPY_INFINITY) && !npy_isnan(in2);
2130+
invalid_cases |= (in1 != NPY_INFINITY && in1 != -NPY_INFINITY) && (in2 == NPY_INFINITY || in2 == -NPY_INFINITY);
2131+
ignore_fpstatus |= invalid_cases;
21282132
divmod@c@(in1, in2, (@type@ *)op1);
21292133
}
21302134
}
@@ -2666,13 +2670,13 @@ mkl_umath_@TYPE@_conjugate(char **args, const npy_intp *dimensions, const npy_in
26662670
CHUNKED_VML_CALL2(v@s@Conj, dimensions[0], @type@, args[0], args[1]);
26672671
/* v@s@Conj(dimensions[0], (@type@*) args[0], (@type@*) args[1]); */
26682672
} else {
2669-
UNARY_LOOP {
2670-
const @ftype@ in1r = ((@ftype@ *)ip1)[0];
2671-
const @ftype@ in1i = ((@ftype@ *)ip1)[1];
2672-
((@ftype@ *)op1)[0] = in1r;
2673-
((@ftype@ *)op1)[1] = -in1i;
2674-
}
2675-
}
2673+
UNARY_LOOP {
2674+
const @ftype@ in1r = ((@ftype@ *)ip1)[0];
2675+
const @ftype@ in1i = ((@ftype@ *)ip1)[1];
2676+
((@ftype@ *)op1)[0] = in1r;
2677+
((@ftype@ *)op1)[1] = -in1i;
2678+
}
2679+
}
26762680
}
26772681

26782682
void
@@ -2691,7 +2695,6 @@ mkl_umath_@TYPE@_absolute(char **args, const npy_intp *dimensions, const npy_int
26912695
UNARY_LOOP {
26922696
const @ftype@ in1r = ((@ftype@ *)ip1)[0];
26932697
const @ftype@ in1i = ((@ftype@ *)ip1)[1];
2694-
ignore_fpstatus = npy_isnan(in1r) && npy_isnan(in1i);
26952698
*((@ftype@ *)op1) = hypot@c@(in1r, in1i);
26962699
}
26972700
}

0 commit comments

Comments
 (0)