Merge pull request #6 from ekomarova/transition-to-scikit-build

Replace test_basic with pytest

Author: ekomarova

conda-recipe/meta.yaml

@@ -37,10 +37,12 @@ requirements:
       - {{ pin_compatible('numpy') }}
 
 test:
+    requires:
+      - pytest
     source_files:
       - mkl_umath/tests/test_basic.py
     commands:
-      - python mkl_umath/tests/test_basic.py
+      - pytest mkl_umath/tests/test_basic.py
     imports:
       - mkl_umath
       - mkl_umath._ufuncs

mkl_umath/tests/test_basic.py

@@ -23,6 +23,7 @@
 # OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
+import pytest
 import numpy as np
 import mkl_umath._ufuncs as mu
 import numpy.core.umath as nu
@@ -49,11 +50,8 @@ def get_args(args_str):
     return tuple(args)
 
 umaths = [i for i in dir(mu) if isinstance(getattr(mu, i), np.ufunc)]
-
 umaths.remove('arccosh') # expects input greater than 1
 
-# dictionary with test cases
-# (umath, types) : args
 generated_cases = {}
 for umath in umaths:
     mkl_umath = getattr(mu, umath)
@@ -64,29 +62,30 @@ def get_args(args_str):
         generated_cases[(umath, type)] = args
 
 additional_cases = {
-('arccosh', 'f->f') : (np.single(np.random.random_sample() + 1),),
-('arccosh', 'd->d') : (np.double(np.random.random_sample() + 1),),
+    ('arccosh', 'f->f'): (np.single(np.random.random_sample() + 1),),
+    ('arccosh', 'd->d'): (np.double(np.random.random_sample() + 1),),
 }
 
-test_cases = {}
-for d in (generated_cases, additional_cases):
-    test_cases.update(d)
+test_cases = {**generated_cases, **additional_cases}
 
-for case in test_cases:
-    umath = case[0]
-    type = case[1]
+@pytest.mark.parametrize("case", list(test_cases.keys()))
+def test_umath(case):
+    umath, type = case
     args = test_cases[case]
     mkl_umath = getattr(mu, umath)
     np_umath = getattr(nu, umath)
     print('*'*80)
-    print(umath, type)
-    print("args", args)
+    print(f"Testing {umath} with type {type}")
+    print("args:", args)
+    
     mkl_res = mkl_umath(*args)
     np_res = np_umath(*args)
-    print("mkl res", mkl_res)
-    print("npy res", np_res)
-
-    assert np.allclose(mkl_res, np_res)
+    
+    print("mkl res:", mkl_res)
+    print("npy res:", np_res)
+    
+    assert np.allclose(mkl_res, np_res), f"Results for {umath} do not match"
 
-print("Test cases count:", len(test_cases))
-print("All looks good!")
+def test_cases_count():
+    print("Test cases count:", len(test_cases))
+    assert len(test_cases) > 0, "No test cases found"