Skip to content

Commit 199183c

Browse files
author
Diptorup Deb
committed
Add docstring and references to open issues for FIXME/TODO.
1 parent 731b20d commit 199183c

File tree

3 files changed

+20
-3
lines changed

3 files changed

+20
-3
lines changed

numba_dpex/experimental/decorators.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
#
33
# SPDX-License-Identifier: Apache-2.0
44

5+
""" The set of experimental decorators provided by numba_dpex that are not yet
6+
ready to move to numba_dpex.core.
7+
"""
58
import inspect
69

710
from numba.core import sigutils

numba_dpex/experimental/kernel_dispatcher.py

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,17 @@ def _compile_cached(
168168

169169

170170
class KernelDispatcher(Dispatcher):
171+
"""Dispatcher class designed to compile kernel decorated functions. The
172+
dispatcher inherits the Numba Dispatcher class, but has a different
173+
compilation strategy. Instead of compiling a kernel decorated function to
174+
an executable binary, the dispatcher compiles it to SPIR-V and then caches
175+
that SPIR-V bitcode.
176+
177+
FIXME: Fix issues identified by pylint with this class.
178+
https://github.com/IntelPython/numba-dpex/issues/1196
179+
180+
"""
181+
171182
targetdescr = dpex_kernel_target
172183
_fold_args = False
173184

@@ -293,8 +304,9 @@ def cb_llvm(dur):
293304
if existing is not None:
294305
return existing
295306

296-
# FIXME: Enable caching
297-
# Add code to enable on disk caching of a binary spirv kernel
307+
# TODO: Enable caching
308+
# Add code to enable on disk caching of a binary spirv kernel.
309+
# Refer: https://github.com/IntelPython/numba-dpex/issues/1197
298310
self._cache_misses[sig] += 1
299311
ev_details = {
300312
"dispatcher": self,
@@ -317,6 +329,7 @@ def folded(args, kws):
317329
self.add_overload(kcres.cres_or_error)
318330

319331
# TODO: enable caching of kernel_module
332+
# https://github.com/IntelPython/numba-dpex/issues/1197
320333

321334
return kcres.entry_point
322335

numba_dpex/tests/experimental/test_exec_queue_inference.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@ def test_successful_execution_queue_inference():
3535
r = Range(100)
3636

3737
# FIXME: This test fails unexpectedly if the NUMBA_CAPTURED_ERRORS is set
38-
# to "new_style"
38+
# to "new_style".
39+
# Refer: https://github.com/IntelPython/numba-dpex/issues/1195
3940
try:
4041
exp_dpex.call_kernel(add, r, a, b, c)
4142
except:

0 commit comments

Comments
 (0)