Skip to content

Commit 8be6115

Browse files
committed
removing pytest expected failure for ocl
1 parent 85a0804 commit 8be6115

File tree

1 file changed

+6
-38
lines changed

1 file changed

+6
-38
lines changed

numba_dpex/tests/experimental/kernel_api_overloads/spv_overloads/test_atomic_load_store_cmp_exchg.py

Lines changed: 6 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ def test_load_store_fn(supported_dtype):
2727
"""A test for load/store atomic functions."""
2828

2929
@dpex_exp.kernel
30-
def _kernel(a, b):
31-
i = dpex.get_global_id(0)
30+
def _kernel(item, a, b):
31+
i = item.get_id(0)
3232
a_ref = AtomicRef(a, index=i)
3333
b_ref = AtomicRef(b, index=i)
3434
val = b_ref.load()
@@ -38,17 +38,6 @@ def _kernel(a, b):
3838
a = dpnp.zeros(2 * N, dtype=supported_dtype)
3939
b = dpnp.arange(N, dtype=supported_dtype)
4040

41-
dev = a.sycl_device
42-
if (
43-
dev.backend == dpctl.backend_type.opencl
44-
and dev.device_type == dpctl.device_type.cpu
45-
and supported_dtype == dpnp.float64
46-
):
47-
pytest.xfail(
48-
"Atomic load and store operations not working "
49-
" for fp64 on OpenCL CPU"
50-
)
51-
5241
dpex_exp.call_kernel(_kernel, dpex.Range(b.size), a, b)
5342
# Verify that `b[i]` loaded and stored into a[i] by kernel
5443
# matches the `b[i]` loaded stored into a[i] using Python
@@ -66,25 +55,15 @@ def test_exchange_fn(supported_dtype):
6655
"""A test for exchange atomic function."""
6756

6857
@dpex_exp.kernel
69-
def _kernel(a, b):
70-
i = dpex.get_global_id(0)
58+
def _kernel(item, a, b):
59+
i = item.get_id(0)
7160
v = AtomicRef(a, index=i)
7261
b[i] = v.exchange(b[i])
7362

7463
N = 10
7564
a_orig = dpnp.zeros(2 * N, dtype=supported_dtype)
7665
b_orig = dpnp.arange(N, dtype=supported_dtype)
7766

78-
dev = a_orig.sycl_device
79-
if (
80-
dev.backend == dpctl.backend_type.opencl
81-
and dev.device_type == dpctl.device_type.cpu
82-
and supported_dtype == dpnp.float64
83-
):
84-
pytest.xfail(
85-
"Atomic exchange operation not working " " for fp64 on OpenCL CPU"
86-
)
87-
8867
a_copy = dpnp.copy(a_orig)
8968
b_copy = dpnp.copy(b_orig)
9069

@@ -112,17 +91,6 @@ def _kernel(b):
11291

11392
b = dpnp.arange(4, dtype=supported_dtype)
11493

115-
dev = b.sycl_device
116-
if (
117-
dev.backend == dpctl.backend_type.opencl
118-
and dev.device_type == dpctl.device_type.cpu
119-
and supported_dtype == dpnp.float64
120-
):
121-
pytest.xfail(
122-
"Atomic compare_exchange operation not working "
123-
" for fp64 on OpenCL CPU"
124-
)
125-
12694
dpex_exp.call_kernel(_kernel, dpex.Range(1), b)
12795

12896
# check for failure
@@ -142,8 +110,8 @@ def test_store_exchange_diff_types(store_exchange_fn):
142110
"""
143111

144112
@dpex_exp.kernel
145-
def _kernel(a, b):
146-
i = dpex.get_global_id(0)
113+
def _kernel(item, a, b):
114+
i = item.get_id(0)
147115
v = AtomicRef(b, index=0)
148116
getattr(v, store_exchange_fn)(a[i])
149117

0 commit comments

Comments
 (0)