Skip to content

Commit bc46319

Browse files
author
Diptorup Deb
authored
Merge pull request #1056 from IntelPython/spirv_version
Upgraded spirv-max-version from 1.1 to 1.4.
2 parents 452d336 + 5e8aa13 commit bc46319

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

numba_dpex/spirv_generator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ def generate(self, llvm_spirv_args, ipath, opath):
7676
llvm_spirv_flags.append("--spirv-debug-info-version=ocl-100")
7777

7878
if not config.NATIVE_FP_ATOMICS:
79-
llvm_spirv_args = ["--spirv-max-version", "1.1"] + llvm_spirv_args
79+
llvm_spirv_args = ["--spirv-max-version", "1.4"] + llvm_spirv_args
8080
llvm_spirv_tool = self._llvm_spirv()
8181

8282
if config.DEBUG:

numba_dpex/tests/kernel_tests/test_print.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@
1616
dpnp.float64,
1717
]
1818

19+
skip_on_gpu = pytest.mark.skipif(
20+
dpctl.SyclDevice().device_type == dpctl.device_type.gpu,
21+
reason="skip print on gpu",
22+
)
23+
1924

2025
@pytest.fixture(params=list_of_dtypes)
2126
def input_arrays(request):
@@ -24,6 +29,7 @@ def input_arrays(request):
2429
return a
2530

2631

32+
@skip_on_gpu
2733
def test_print_scalar_with_string(input_arrays, capfd):
2834
"""Tests if we can print a scalar value with a string."""
2935

@@ -41,6 +47,7 @@ def print_scalar_val(s):
4147
assert "printing ... 10" in captured.out
4248

4349

50+
@skip_on_gpu
4451
def test_print_scalar(input_arrays, capfd):
4552
"""Tests if we can print a scalar value."""
4653

@@ -59,6 +66,7 @@ def print_scalar_val(s):
5966
assert "10" in captured.out
6067

6168

69+
@skip_on_gpu
6270
def test_print_only_str(input_arrays):
6371
"""Negative test to capture LoweringError as printing strings is
6472
unsupported.
@@ -80,6 +88,7 @@ def print_string(a):
8088
print_string[dpex.Range(1)](a)
8189

8290

91+
@skip_on_gpu
8392
def test_print_array(input_arrays):
8493
"""Negative test to capture LoweringError as printing arrays
8594
is unsupported.

0 commit comments

Comments
 (0)