Add negative unary op (#79)

Author: tkarna

imex_version.txt

@@ -1 +1 @@
-149d88b36ed4f7ff19fec3e3d9842aa6dcd4fb3d
+77e2decc3db735469dbe9de95253f27c81c44f5d

src/EWUnyOp.cpp

@@ -190,8 +190,10 @@ static ::imex::ndarray::EWUnyOpId sharpy(const EWUnyOpId uop) {
     return ::imex::ndarray::LOGICAL_NOT;
   case __NEG__:
   case NEGATIVE:
+    return ::imex::ndarray::NEGATIVE;
   case __POS__:
   case POSITIVE:
+    return ::imex::ndarray::POSITIVE;
   default:
     throw std::runtime_error("Unknown/invalid elementwise unary operation");
   }
@@ -213,24 +215,31 @@ struct DeferredEWUnyOp : public Deferred {
     auto aTyp = av.getType().cast<::imex::ndarray::NDArrayType>();
     auto outTyp = aTyp.cloneWith(shape(), aTyp.getElementType());
 
+    auto ndOpId = sharpy(_op);
     auto uop = builder.create<::imex::ndarray::EWUnyOp>(
-        loc, outTyp, builder.getI32IntegerAttr(sharpy(_op)), av);
+        loc, outTyp, builder.getI32IntegerAttr(ndOpId), av);
+    // positive op will be eliminated so it is equivalent to a view
+    auto view = ndOpId == ::imex::ndarray::POSITIVE;
 
     dm.addVal(
         this->guid(), uop,
-        [this](uint64_t rank, void *l_allocated, void *l_aligned,
-               intptr_t l_offset, const intptr_t *l_sizes,
-               const intptr_t *l_strides, void *o_allocated, void *o_aligned,
-               intptr_t o_offset, const intptr_t *o_sizes,
-               const intptr_t *o_strides, void *r_allocated, void *r_aligned,
-               intptr_t r_offset, const intptr_t *r_sizes,
-               const intptr_t *r_strides, uint64_t *lo_allocated,
-               uint64_t *lo_aligned) {
-          this->set_value(std::move(mk_tnsr(
-              this->guid(), _dtype, this->shape(), this->device(), this->team(),
-              l_allocated, l_aligned, l_offset, l_sizes, l_strides, o_allocated,
-              o_aligned, o_offset, o_sizes, o_strides, r_allocated, r_aligned,
-              r_offset, r_sizes, r_strides, lo_allocated, lo_aligned)));
+        [this, view](uint64_t rank, void *l_allocated, void *l_aligned,
+                     intptr_t l_offset, const intptr_t *l_sizes,
+                     const intptr_t *l_strides, void *o_allocated,
+                     void *o_aligned, intptr_t o_offset,
+                     const intptr_t *o_sizes, const intptr_t *o_strides,
+                     void *r_allocated, void *r_aligned, intptr_t r_offset,
+                     const intptr_t *r_sizes, const intptr_t *r_strides,
+                     uint64_t *lo_allocated, uint64_t *lo_aligned) {
+          auto t = mk_tnsr(this->guid(), _dtype, this->shape(), this->device(),
+                           this->team(), l_allocated, l_aligned, l_offset,
+                           l_sizes, l_strides, o_allocated, o_aligned, o_offset,
+                           o_sizes, o_strides, r_allocated, r_aligned, r_offset,
+                           r_sizes, r_strides, lo_allocated, lo_aligned);
+          if (view && Registry::has(_a)) {
+            t->set_base(Registry::get(_a).get());
+          }
+          this->set_value(std::move(t));
         });
     return false;
   }

test/test_ewu.py

@@ -1,6 +1,8 @@
 import sharpy as sp
-from utils import runAndCompare, mpi_dtypes
 import pytest
+import numpy
+
+type_list = [sp.int64, sp.float64]
 
 
 class TestEWU:
@@ -10,6 +12,23 @@ def test_sqrt(self):
         v = 16 * 16 * 3
         assert float(c) == v
 
+    def test_abs(self):
+        a = sp.full((6,), -5, sp.float32)
+        b = sp.abs(a)
+        assert numpy.allclose(sp.to_numpy(b), [5, 5, 5, 5, 5, 5])
+
+    def test_negative(self):
+        for dtype in type_list:
+            a = sp.arange(0, 6, 1, dtype)
+            b = -a
+            assert numpy.allclose(sp.to_numpy(b), [0, -1, -2, -3, -4, -5])
+
+    def test_positive(self):
+        for dtype in type_list:
+            a = sp.arange(0, 6, 1, dtype)
+            b = +a
+            assert numpy.allclose(sp.to_numpy(b), [0, 1, 2, 3, 4, 5])
+
     @pytest.mark.skip(reason="FIXME")
     def test_equal(self):
         a = sp.full((16, 16), 9, sp.float32)