Update workflows to use upload-artifact v4 (#3097)

* Update workflows to use upload-artifact v4

* only upload artifacts once

* use expression syntax

Author: SirYwell

.github/workflows/build-pr.yml

@@ -21,7 +21,8 @@ jobs:
       - name: Build on ${{ matrix.os }}
         run: ./gradlew build -s
       - name: Archive artifacts
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
+        if: ${{ matrix.os == 'ubuntu-latest' }} # only upload once, use linux builds
         with:
             name: FastAsyncWorldEdit-SNAPSHOT
             path: worldedit-bukkit/build/libs/FastAsyncWorldEdit-*.jar

.github/workflows/build.yml

@@ -67,7 +67,7 @@ jobs:
           target-branch: main
           target-directory: worldedit-bukkit
       - name: Archive Artifacts
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: FastAsyncWorldEdit-Bukkit-SNAPSHOT
           path: worldedit-bukkit/build/libs/FastAsyncWorldEdit-*.jar