fix: don't throw exception in LinOps#getList + cleanup

Author: PierreSchwang

worldedit-bukkit/adapters/adapter-1_21_11/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_21_11/LinOps.java

@@ -63,6 +63,16 @@ public LinTag<?> empty() {
         return LinEndTag.instance();
     }
 
+    @Override
+    public LinTag<?> emptyList() {
+        return LinListTag.empty(LinTagType.endTag());
+    }
+
+    @Override
+    public LinTag<?> emptyMap() {
+        return LinCompoundTag.builder().build();
+    }
+
     @Override
     public <U> U convertTo(final DynamicOps<U> outOps, final LinTag<?> input) {
         return switch (input) {
@@ -180,7 +190,7 @@ public DataResult<Stream<Pair<LinTag<?>, LinTag<?>>>> getMapValues(final LinTag<
                     .stream()
                     .map(entry -> Pair.of(this.createString(entry.getKey()), entry.getValue())));
         }
-        return DataResult.error(() -> "Not a map");
+        return DataResult.error(() -> "Not a map: " + input);
     }
 
     @Override
@@ -189,7 +199,7 @@ public DataResult<Consumer<BiConsumer<LinTag<?>, LinTag<?>>>> getMapEntries(fina
             return DataResult.success(consumer ->
                     tag.value().forEach((s, linTag) -> consumer.accept(this.createString(s), linTag)));
         }
-        return DataResult.error(() -> "Not a map");
+        return DataResult.error(() -> "Not a map: " + input);
     }
 
     @Override
@@ -321,7 +331,7 @@ public DataResult<Consumer<Consumer<LinTag<?>>>> getList(final LinTag<?> input)
                 }
             });
         }
-        throw new UnsupportedOperationException("Not a list: " + input);
+        return DataResult.error(() -> "Not a list: " + input);
     }
 
     @Override

worldedit-bukkit/adapters/adapter-1_21_11/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_21_11/LinValueInput.java

@@ -307,21 +307,23 @@ public boolean isEmpty() {
             return new AbstractIterator<>() {
                 @Override
                 protected @Nullable T computeNext() {
-                    while (iterator.hasNext()) {
-                        int index = iterator.nextIndex();
-                        LinTag<?> tag = iterator.next();
-                        switch (codec.parse(context.ops(), tag)) {
-                            case DataResult.Success<T> success:
-                                return success.value();
-                            case DataResult.Error<T> error:
-                                problemReporter.report(() -> "Failed to decode value '" + tag + "' from field '" + name + "' at index " + index + ":" + " " + error);
-                                if (error.partialValue().isEmpty()) {
-                                    continue;
-                                }
-                                return error.partialValue().get();
+                    while (true) {
+                        if (iterator.hasNext()) {
+                            int index = iterator.nextIndex();
+                            LinTag<?> tag = iterator.next();
+                            switch (codec.parse(context.ops(), tag)) {
+                                case DataResult.Success<T> success:
+                                    return success.value();
+                                case DataResult.Error<T> error:
+                                    problemReporter.report(() -> "Failed to decode value '" + tag + "' from field '" + name + "' at index " + index + ":" + " " + error);
+                                    if (error.partialValue().isEmpty()) {
+                                        continue;
+                                    }
+                                    return error.partialValue().get();
+                            }
                         }
+                        return this.endOfData();
                     }
-                    return this.endOfData();
                 }
             };
         }
@@ -366,21 +368,8 @@ public boolean isEmpty() {
 
     }
 
-    private static final class EmptyValueInput implements ValueInput {
-
-        private final HolderLookup.Provider lookup;
-        private final ValueInputList emptyChildList;
-        private final TypedInputList<Object> emptyTypedList;
-
-        private EmptyValueInput(
-                final HolderLookup.Provider lookup,
-                final ValueInputList list,
-                final TypedInputList<Object> typedList
-        ) {
-            this.lookup = lookup;
-            this.emptyChildList = list;
-            this.emptyTypedList = typedList;
-        }
+    private record EmptyValueInput(HolderLookup.Provider lookup, ValueInputList emptyChildList,
+                                   TypedInputList<Object> emptyTypedList) implements ValueInput {
 
         @Override
         public <T> @NonNull Optional<T> read(final @NonNull String key, final @NonNull Codec<T> codec) {
@@ -483,11 +472,6 @@ public double getDoubleOr(final @NonNull String s, final double defaultValue) {
             return Optional.empty();
         }
 
-        @Override
-        public HolderLookup.@NonNull Provider lookup() {
-            return this.lookup;
-        }
-
     }
 
 }

worldedit-bukkit/adapters/adapter-1_21_11/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_21_11/LinValueOutput.java

@@ -198,7 +198,9 @@ public boolean isEmpty() {
     }
 
     public LinCompoundTag buildResult() {
-        return this.toBuilder().build();
+        return LinCompoundTag.of(this.collector.entrySet().stream()
+                .collect(Collectors.toMap(Map.Entry::getKey, entry -> unwrapPendingEntry(entry.getValue())))
+        );
     }
 
     public LinCompoundTag.Builder toBuilder() {