fix: remove duplicate data source parameters from openapi metadata

Author: ascott18

CHANGELOG.md

@@ -5,6 +5,7 @@
 - Fix error in .NET 9 thrown by vite development middleware if the HTTPS cert directory doesn't exist.
 - Fix `ViewModel.$load` and `ListViewModel.$load` not properly working with `.useResponseCaching()`.
 - Entities that own multiple one-to-one relationships should no longer throw errors when generating.
+- Don't duplicate data source parameters in OpenAPI parameter collections.
 
 # 5.3.1
 

src/IntelliTect.Coalesce.Swashbuckle.Tests/OpenApiDocumentTests.cs

@@ -73,5 +73,19 @@ public async Task EndpointsWithObjectParameters_IncludeActionParameterNamePrefix
             Assert.Single(properties, p => p.Key == "complexModelId");
             Assert.Single(properties, p => p.Key.Equals("model.complexModelId", StringComparison.InvariantCultureIgnoreCase));
         }
+
+        [Fact]
+        public async Task DataSourceWithInheritance_DoesNotDuplicateSharedParameters()
+        {
+            var doc = await Fixture.GetDocumentAsync();
+
+            var parameters = doc
+                .Paths["/api/Person/list"]
+                .Operations[Microsoft.OpenApi.Models.OperationType.Get]
+                .Parameters;
+
+            var param = Assert.Single(parameters, p => p.Name == "dataSource.IntArray");
+            Assert.Equal("Used by data sources ParameterTestsSource, ParameterTestsSourceSubclass.", param.Description);
+        }
     }
 }

src/IntelliTect.Coalesce.Tests/TargetClasses/TestDbContext/Person.cs

@@ -298,4 +298,9 @@ public class ParameterTestsSource(CrudContext<AppDbContext> context) : StandardD
         [Coalesce]
         public byte[] Bytes { get; set; }
     }
+
+    [Coalesce]
+    public class ParameterTestsSourceSubclass(CrudContext<AppDbContext> context) : ParameterTestsSource(context)
+    {
+    }
 }

src/IntelliTect.Coalesce/Api/OpenApi/CoalesceApiDescriptionProvider.cs

@@ -87,19 +87,19 @@ private void ProcessStandardParameters(ApiDescription operation, MethodViewModel
 
                 var dataSources = declaredFor.ClassViewModel!.ClientDataSources(reflectionRepository);
 
-                foreach (var dataSource in dataSources)
+                foreach (var group in dataSources.SelectMany(ds => ds.DataSourceParameters).GroupBy(ds => ds.Name))
                 {
-                    foreach (var dsParam in dataSource.DataSourceParameters)
+                    var dsParam = group.First();
+                    var dataSource = dsParam.Parent;
+
+                    operation.ParameterDescriptions.Add(new ApiParameterDescription()
                     {
-                        operation.ParameterDescriptions.Add(new ApiParameterDescription()
-                        {
-                            Source = BindingSource.Query,
-                            Name = $"{paramVm.Name}.{dsParam.Name}",
-                            IsRequired = false,
-                            Type = dsParam.Type.TypeInfo,
-                            ModelMetadata = operation.ParameterDescriptions.First().ModelMetadata.GetMetadataForProperty(dataSource.Type.TypeInfo, dsParam.Name)
-                        });
-                    }
+                        Source = BindingSource.Query,
+                        Name = $"{paramVm.Name}.{dsParam.Name}",
+                        IsRequired = false,
+                        Type = dsParam.Type.TypeInfo,
+                        ModelMetadata = operation.ParameterDescriptions.First().ModelMetadata.GetMetadataForProperty(dataSource.Type.TypeInfo, dsParam.Name)
+                    });
                 }
             }
         }