Skip to content

Commit 3f30e4c

Browse files
Copilotascott18
andcommitted
refactor: only add Because() clause when result.Message is not empty
Co-authored-by: ascott18 <5017521+ascott18@users.noreply.github.com>
1 parent 3908847 commit 3f30e4c

File tree

1 file changed

+24
-9
lines changed

1 file changed

+24
-9
lines changed

templates/Coalesce.Vue.Template/content/Coalesce.Starter.Vue.Data.Test/Utilities/AssertionExtensions.cs

Lines changed: 24 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,14 @@ public static async Task AssertError(this ApiResult result, string message)
2727
/// </summary>
2828
public static async Task AssertSuccess(this ApiResult result, string? message = null)
2929
{
30-
await Assert.That(result.WasSuccessful)
31-
.IsTrue()
32-
.Because(result.Message ?? "");
30+
if (!string.IsNullOrEmpty(result.Message))
31+
{
32+
await Assert.That(result.WasSuccessful).IsTrue().Because(result.Message);
33+
}
34+
else
35+
{
36+
await Assert.That(result.WasSuccessful).IsTrue();
37+
}
3338
await Assert.That(result.Message).IsEqualTo(message);
3439
}
3540

@@ -38,9 +43,14 @@ await Assert.That(result.WasSuccessful)
3843
/// </summary>
3944
public static async Task<T> AssertSuccess<T>(this ItemResult<T> result)
4045
{
41-
await Assert.That(result.WasSuccessful)
42-
.IsTrue()
43-
.Because(result.Message ?? "");
46+
if (!string.IsNullOrEmpty(result.Message))
47+
{
48+
await Assert.That(result.WasSuccessful).IsTrue().Because(result.Message);
49+
}
50+
else
51+
{
52+
await Assert.That(result.WasSuccessful).IsTrue();
53+
}
4454
await Assert.That(result.Message).IsNull();
4555
return result.Object ?? throw new ArgumentException("Successful result unexpectedly returned null object");
4656
}
@@ -60,9 +70,14 @@ public static async Task<T> AssertSuccess<T>(this Task<ItemResult<T>> resultTask
6070
public static async Task AssertSuccess(this Task<ItemResult> resultTask)
6171
{
6272
var result = await resultTask;
63-
await Assert.That(result.WasSuccessful)
64-
.IsTrue()
65-
.Because(result.Message ?? "");
73+
if (!string.IsNullOrEmpty(result.Message))
74+
{
75+
await Assert.That(result.WasSuccessful).IsTrue().Because(result.Message);
76+
}
77+
else
78+
{
79+
await Assert.That(result.WasSuccessful).IsTrue();
80+
}
6681
}
6782

6883
/// <summary>

0 commit comments

Comments
 (0)