feat: #537 emit error for nested data sources whose type doesn't match their containing class

Author: ascott18

playground/Coalesce.Domain/Person.cs

@@ -353,8 +353,8 @@ public override IQueryable<Person> GetQuery(IDataSourceParameters parameters)
                 //=> Db.People.Include(p => p.Company);
                 => Db.People.IncludeChildren();
 
-                // https://stackoverflow.com/questions/11276964/how-to-slow-down-a-sql-query
-                //=> Db.People.FromSql("SELECT top 1000000 T1.* FROM Person T1,Person T2, Person T3, Person T4 ORDER BY RAND(T1.PersonId)");
+            // https://stackoverflow.com/questions/11276964/how-to-slow-down-a-sql-query
+            //=> Db.People.FromSql("SELECT top 1000000 T1.* FROM Person T1,Person T2, Person T3, Person T4 ORDER BY RAND(T1.PersonId)");
         }
 
         public class Behaviors : StandardBehaviors<Person, AppDbContext>

src/IntelliTect.Coalesce.DotnetTool/Program.cs

@@ -11,6 +11,7 @@
 using IntelliTect.Coalesce.CodeGeneration.Configuration;
 using IntelliTect.Coalesce.CodeGeneration.Generation;
 using IntelliTect.Coalesce.CodeGeneration.Utilities;
+using IntelliTect.Coalesce.TypeDefinition;
 using McMaster.Extensions.CommandLineUtils;
 using Microsoft.Extensions.Logging;
 using Newtonsoft.Json;
@@ -115,6 +116,12 @@ private async Task<int> OnExecuteAsync(CommandLineApplication app)
             {
                 await executor.GenerateAsync(rootGenerator);
             }
+            catch (CoalesceModelException e)
+            {
+                // Only write the message here, not a full exception.ToString() w/ stack trace
+                executor.Logger.LogError(e.Message);
+                return -1;
+            }
             catch (ProjectAnalysisException e)
             {
                 // Only write the message here, not a full exception.ToString() w/ stack trace

src/IntelliTect.Coalesce/TypeDefinition/CoalesceModelException.cs

@@ -0,0 +1,23 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace IntelliTect.Coalesce.TypeDefinition
+{
+    public sealed class CoalesceModelException : Exception
+    {
+        public CoalesceModelException() : base()
+        {
+        }
+
+        public CoalesceModelException(string? message) : base(message)
+        {
+        }
+
+        public CoalesceModelException(string? message, Exception? innerException) : base(message, innerException)
+        {
+        }
+    }
+}

src/IntelliTect.Coalesce/TypeDefinition/PropertyViewModel.cs

@@ -165,7 +165,7 @@ public PropertyViewModel? ManyToManyFarNavigationProperty
                 string? propName = this.GetAttributeValue<ManyToManyAttribute>(a => a.FarNavigationProperty);
                 if (propName != null && propName == ManyToManyNearNavigationProperty?.Name)
                 {
-                    throw new Exception(
+                    throw new CoalesceModelException(
                         "ManyToManyAtttribute.FarNavigationProperty is referencing the near side of " +
                         "the many-to-many relationship, which is not allowed. " +
                         "To configure the near side of the many-to-many relationship, use [InverseProperty].");
@@ -182,7 +182,7 @@ propName is null
                 {
                     if (firstCandidate != null)
                     {
-                        throw new Exception(
+                        throw new CoalesceModelException(
                             "Found more than one candidate far navigation property for [ManyToMany] collection. To fix this, set ManyToManyAtttribute.FarNavigationProperty to the name of one of these candidate properties: " +
                             string.Concat(candidates.Select(p => $"\n    {Object}.{p.Name}")));
                     }

src/IntelliTect.Coalesce/TypeDefinition/ReflectionRepository.cs

@@ -331,15 +331,15 @@ private bool AddCrudStrategy(
             var servedClass = servedType.ClassViewModel;
             if (servedClass == null)
             {
-                throw new InvalidOperationException($"{servedType} is not a valid type argument for a {iface}.");
+                throw new CoalesceModelException($"{servedType} is not a valid type argument for a {iface}.");
             }
 
             // See if we were expecting that the strategy be declared for a particular type
             // by virtue of its nesting. If this type has been overridden to something else by an attribute, then that's wrong.
             var explicitlyDeclaredFor = strategyType.GetAttributeValue<DeclaredForAttribute>(a => a.DeclaredFor)?.ClassViewModel;
             if (explicitlyDeclaredFor != null && declaredFor != null && !explicitlyDeclaredFor.Equals(declaredFor))
             {
-                throw new InvalidOperationException(
+                throw new CoalesceModelException(
                     $"Expected that {strategyType} is declared for {declaredFor}, but it was explicitly declared for {explicitlyDeclaredFor} instead.");
             }
 
@@ -350,10 +350,16 @@ private bool AddCrudStrategy(
 
             if (declaredFor.IsCustomDto && !servedClass.Equals(declaredFor.DtoBaseViewModel))
             {
-                throw new InvalidOperationException($"{strategyType} is not a valid {iface} for {declaredFor} - " +
+                throw new CoalesceModelException($"{strategyType} is not a valid {iface.Name} for {declaredFor}. " +
                     $"{strategyType} must satisfy {iface} with type parameter <{declaredFor.DtoBaseViewModel}>.");
             }
 
+            if (!declaredFor.IsCustomDto && !servedClass.Equals(declaredFor))
+            {
+                throw new CoalesceModelException($"{strategyType} is not a valid {iface.Name} for {declaredFor}. " +
+                    $"{strategyType} must satisfy {iface} with type parameter <{declaredFor}>.");
+            }
+
             set.Add(new CrudStrategyTypeUsage(strategyType.ClassViewModel, servedClass, declaredFor));
 
             if (strategyType.IsA(typeof(IDataSource<>)))