feat: #526 implicitly inject interface method parameters from services

Author: ascott18

CHANGELOG.md

@@ -3,9 +3,9 @@
 ## Breaking Changes
 
 - Vue 2 support has been dropped.
-- The CommonJS build of coalesce-vue has been dropped - only the ESM build remains. Most projects should be unaffected.
-- `ViewModel.$getErrors` now returns a `string[]` instead of a `Generator<string>`.
 - `StandardBehaviors.AfterDelete` is now `AfterDeleteAsync` and has a different signature and semantics. Instead of modifying the resulting `item` and `includeTree` with `ref` parameters, these values can be optionally overridden by returning an ItemResult with its `Object` and `IncludeTree` properties populated with non-null values.
+- `ViewModel.$getErrors` now returns a `string[]` instead of a `Generator<string>`.
+- The CommonJS build of coalesce-vue has been dropped - only the ESM build remains. Most projects should be unaffected.
 
 ## Features
 
@@ -17,6 +17,7 @@
 - `ViewModel.$loadCleanData()` now returns the VM instance, to support call chaining.
 - `c-admin-display` now renders clickable links for binary values that will download the value as a file, instead of only showing the length in bytes.
 - `System.Uri` is now support as a type, mapping to a `string` in TypeScript.
+- Interfaces used as parameters in Coalesce-exposed methods are now automatically injected from services, without the need to specify `[InjectAttribute]`. This does not include known data-like interfaces including `IEnumerable`, `ICollection`, and `IFile`.
 
 # 5.3.3
 

src/IntelliTect.Coalesce.Tests/TargetClasses/TestDbContext/ComplexModel.cs

@@ -269,7 +269,7 @@ ICollection<ExternalParentAsInputOnly> collection
         public InputOutputOnlyExternalTypeWithRequiredNonscalarProp MethodWithInputOutputOnlyExternalTypeWithRequiredNonscalarProp(InputOutputOnlyExternalTypeWithRequiredNonscalarProp i) => i;
 
         [Coalesce, Execute]
-        public void MethodWithSingleFileParameter(IFile file) { }
+        public void MethodWithSingleFileParameter(IFile file, IWeatherService implicitInjectedService) { }
 
         [Coalesce, Execute]
         public void MethodWithMultiFileParameter(ICollection<IFile> files) { }

src/IntelliTect.Coalesce/Api/DataSources/QueryableDataSourceBase`1.cs

@@ -214,7 +214,7 @@ protected virtual IQueryable<T> ApplyListPropertyFilter(
 
                             object result = type == typeof(Guid)
                                 ? Guid.Parse(item)
-                                : typeConverter.ConvertFromString(item);
+                                : typeConverter.ConvertFromString(item)!;
 
                             return (Success: true, Result: result);
                         }

src/IntelliTect.Coalesce/TypeDefinition/ParameterViewModel.cs

@@ -45,7 +45,15 @@ private protected ParameterViewModel(MethodViewModel parent, TypeViewModel type)
         /// <summary>
         /// True if this is an injected method parameter that should be represented by a controller action argument.
         /// </summary>
-        public bool ShouldInjectFromServices => HasInjectAttribute || (!IsAutoInjectedContext && IsDbContext);
+        public bool ShouldInjectFromServices => 
+            HasInjectAttribute ||
+            // Only DbContexts that are not the `IsAutoInjectedContext` are injected from services.
+            // The auto-injected context is sourced from the controller, not the action parameters.
+            (!IsAutoInjectedContext && IsDbContext) ||
+            // Interfaces that are not known data types (file, collections) are always injected
+            // because Coalesce couldn't otherwise possibly know the implementation type to use.
+            (Type.IsInterface && !Type.IsFile && !Type.IsCollection)
+            ;
 
         /// <summary>
         /// True if the parameter is marked with <see cref="InjectAttribute"/>