Skip to content

Commit d93cfbe

Browse files
Startup steps reduced down to changing one bool value (#601)
## Description Newcomers to this repo are not able to immediately start up the application due to the private nuget feed. Final solution requires newcomers to change on boolean value in Directory.Build.props to tell lower level config files not to reference ContentFeedNuget, which is inaccessible to those without permissions. --------- Co-authored-by: Benjamin Michaelis <[email protected]>
1 parent 8a47bea commit d93cfbe

File tree

4 files changed

+10
-6
lines changed

4 files changed

+10
-6
lines changed

Directory.Build.props

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
<PreserveCompilationContext>true</PreserveCompilationContext>
88
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
99
<DockerDefaultTargetOS>Linux</DockerDefaultTargetOS>
10+
<AccessToNugetFeed>true</AccessToNugetFeed>
1011

1112
<!-- https://aka.ms/vs-build-acceleration -->
1213
<AccelerateBuildsInVisualStudio>True</AccelerateBuildsInVisualStudio>

Directory.Packages.props

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,14 @@
22
<PropertyGroup>
33
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
44
<CentralPackageTransitivePinningEnabled>false</CentralPackageTransitivePinningEnabled>
5-
<AccessToNugetFeed>true</AccessToNugetFeed>
6-
<ToolingPackagesVersion>1.1.1.4359</ToolingPackagesVersion>
5+
<ToolingPackagesVersion>1.1.1.4330</ToolingPackagesVersion>
76
</PropertyGroup>
87
<ItemGroup Condition="$(AccessToNugetFeed)">
98
<PackageVersion Include="ContentFeedNuget" Version="$(ToolingPackagesVersion)" />
10-
<PackageVersion Include="Microsoft.EntityFrameworkCore.Sqlite" Version="8.0.10" />
119
</ItemGroup>
1210
<ItemGroup>
13-
<PackageVersion Include="EssentialCSharp.Shared.Models" Version="1.1.1.4359" />
11+
<PackageVersion Include="EssentialCSharp.Shared.Models" Version="1.1.1.4330" />
12+
<PackageVersion Include="Microsoft.EntityFrameworkCore.Sqlite" Version="8.0.8" />
1413
<PackageVersion Include="AspNet.Security.OAuth.GitHub" Version="8.2.0" />
1514
<PackageVersion Include="coverlet.collector" Version="6.0.2" />
1615
<PackageVersion Include="HtmlAgilityPack" Version="1.11.67" />

EssentialCSharp.Web/EssentialCSharp.Web.csproj

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,16 @@
11
<Project Sdk="Microsoft.NET.Sdk.Web">
22
<PropertyGroup>
33
<TargetFramework>net8.0</TargetFramework>
4-
<AccessToNugetFeed>true</AccessToNugetFeed>
54
</PropertyGroup>
65
<ItemGroup>
76
<PlaceholderHtmlFile Include="$(ProjectDir)Placeholders/*.html" />
87
<PlaceholderJsonFile Include="$(ProjectDir)Placeholders/*.json" />
98
</ItemGroup>
9+
<ItemGroup Condition="$(AccessToNugetFeed)">
10+
<PackageReference Include="ContentFeedNuget" />
11+
</ItemGroup>
1012

1113
<ItemGroup>
12-
<PackageReference Include="ContentFeedNuget" />
1314
<PackageReference Include="AspNet.Security.OAuth.GitHub" />
1415
<PackageReference Include="EssentialCSharp.Shared.Models" />
1516
<PackageReference Include="HtmlAgilityPack" />

nuget.config

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66
<add key="nuget" value="https://api.nuget.org/v3/index.json" />
77
<add key="EssentialCSharp" value="https://pkgs.dev.azure.com/intelliTect/_packaging/EssentialCSharp/nuget/v3/index.json" />
88
</packageSources>
9+
<disabledPackageSources>
10+
<add key="EssentialCSharp" value="!$(AccessToNugetFeed)" />
11+
</disabledPackageSources>
912
<packageSourceMapping>
1013
<packageSource key="nuget">
1114
<package pattern="*" />

0 commit comments

Comments
 (0)