Fix #2 - log an error during init if the database cannot be connected to.

Author: ascott18

demo/DemoServer/DemoServer.csproj

@@ -1,13 +1,13 @@
 <Project Sdk="Microsoft.NET.Sdk.Web">
 
   <PropertyGroup>
-    <TargetFramework>net5.0</TargetFramework>
+    <TargetFramework>net6.0</TargetFramework>
     <CopyRefAssembliesToPublishDirectory>false</CopyRefAssembliesToPublishDirectory>
 	<IsPackable>false</IsPackable>
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation" Version="5.0.7" />
+    <PackageReference Include="Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation" Version="6.0.0" />
   </ItemGroup>
 
   <ItemGroup>

demo/DemoServer/Program.cs

@@ -32,7 +32,7 @@ public static IHostBuilder CreateHostBuilder(string[] args) =>
                         builder.AddSimpleConsole(options =>
                         {
                             options.TimestampFormat = "hh:mm:ss ";
-                            options.SingleLine = true;
+                            options.SingleLine = false;
                         });
                     });
                 });

src/IntelliTect.AspNetCore.SignalR.SqlServer/IntelliTect.AspNetCore.SignalR.SqlServer.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
 	<PropertyGroup>
-		<TargetFrameworks>netstandard2.0;netcoreapp3.1;net5.0</TargetFrameworks>
+		<TargetFrameworks>netstandard2.0;netcoreapp3.1;net5.0;net6.0</TargetFrameworks>
 		<LangVersion>9.0</LangVersion>
 		<Nullable>enable</Nullable>
 		<GenerateDocumentationFile>true</GenerateDocumentationFile>

src/IntelliTect.AspNetCore.SignalR.SqlServer/Internal/SqlServer/SqlInstaller.cs

@@ -28,35 +28,43 @@ public SqlInstaller(SqlServerOptions options, ILogger logger, string messagesTab
         public async Task Install()
         {
             _logger.LogInformation("Start installing SignalR SQL objects");
-
-            using var connection = new SqlConnection(_options.ConnectionString);
-            await connection.OpenAsync();
-            using var command = connection.CreateCommand();
-
-            if (_options.AutoEnableServiceBroker)
+            try
             {
-                try
-                {
-                    command.CommandText = GetType().Assembly.StringResource("enable-broker.sql");
-                    await command.ExecuteNonQueryAsync();
-                }
-                catch (Exception ex)
+                using var connection = new SqlConnection(_options.ConnectionString);
+                await connection.OpenAsync();
+                using var command = connection.CreateCommand();
+
+                if (_options.AutoEnableServiceBroker)
                 {
-                    _logger.LogError(ex, "Unable to automatically enable SQL Server Service Broker.");
+                    try
+                    {
+                        command.CommandText = GetType().Assembly.StringResource("enable-broker.sql");
+                        await command.ExecuteNonQueryAsync();
+                    }
+                    catch (Exception ex)
+                    {
+                        _logger.LogError(ex, "Unable to automatically enable SQL Server Service Broker.");
+                    }
                 }
-            }
 
-            var script = GetType().Assembly.StringResource("install.sql");
+                var script = GetType().Assembly.StringResource("install.sql");
+
+                script = script.Replace("SET @SCHEMA_NAME = 'SignalR';", "SET @SCHEMA_NAME = '" + _options.SchemaName + "';");
+                script = script.Replace("SET @TARGET_SCHEMA_VERSION = 1;", "SET @TARGET_SCHEMA_VERSION = " + SchemaVersion + ";");
+                script = script.Replace("SET @MESSAGE_TABLE_COUNT = 1;", "SET @MESSAGE_TABLE_COUNT = " + _options.TableCount + ";");
+                script = script.Replace("SET @MESSAGE_TABLE_NAME = 'Messages';", "SET @MESSAGE_TABLE_NAME = '" + _messagesTableNamePrefix + "';");
 
-            script = script.Replace("SET @SCHEMA_NAME = 'SignalR';", "SET @SCHEMA_NAME = '" + _options.SchemaName + "';");
-            script = script.Replace("SET @TARGET_SCHEMA_VERSION = 1;", "SET @TARGET_SCHEMA_VERSION = " + SchemaVersion + ";");
-            script = script.Replace("SET @MESSAGE_TABLE_COUNT = 1;", "SET @MESSAGE_TABLE_COUNT = " + _options.TableCount + ";");
-            script = script.Replace("SET @MESSAGE_TABLE_NAME = 'Messages';", "SET @MESSAGE_TABLE_NAME = '" + _messagesTableNamePrefix + "';");
+                command.CommandText = script;
+                await command.ExecuteNonQueryAsync();
 
-            command.CommandText = script;
-            await command.ExecuteNonQueryAsync();
+                _logger.LogInformation("SignalR SQL objects installed");
+            }
+            catch (Exception ex)
+            {
+                _logger.LogError(ex, "Unable to install SignalR SQL objects");
+                throw;
+            }
 
-            _logger.LogInformation("SignalR SQL objects installed");
         }
     }
 }

src/IntelliTect.AspNetCore.SignalR.SqlServer/Internal/SqlServer/SqlStream.cs

@@ -44,7 +44,7 @@ public Task Send(byte[] message)
 
         public void Dispose()
         {
-            _logger.LogInformation("{0}Disposing stream {1}", _tracePrefix, _streamIndex);
+            _logger.LogTrace("{0}Disposing stream {1}", _tracePrefix, _streamIndex);
 
             _receiver.Dispose();
         }

src/IntelliTect.AspNetCore.SignalR.SqlServer/Internal/SqlServerProtocol.cs

@@ -110,7 +110,7 @@ private void WriteInvocationCore(ref MessagePackWriter writer, string methodName
                 writer.WriteArrayHeader(0);
             }
 
-            WriteHubMessage(ref writer, new InvocationMessage(methodName, args));
+            WriteHubMessage(ref writer, new InvocationMessage(methodName, args ?? Array.Empty<object[]>()));
         }
 
         public SqlServerInvocation ReadInvocationAll(ReadOnlyMemory<byte> data)

src/IntelliTect.AspNetCore.SignalR.SqlServer/SqlServerHubLifetimeManager.cs

@@ -116,6 +116,8 @@ public override Task OnDisconnectedAsync(HubConnectionContext connection)
             var tasks = new List<Task>();
 
             var feature = connection.Features.Get<ISqlServerFeature>()!;
+            if (feature is null) return Task.CompletedTask;
+
             var groupNames = feature.Groups;
 
             if (groupNames != null)
@@ -165,7 +167,7 @@ public override Task SendConnectionAsync(string connectionId, string methodName,
             var connection = _connections[connectionId];
             if (connection != null)
             {
-                return connection.WriteAsync(new InvocationMessage(methodName, args), cancellationToken).AsTask();
+                return connection.WriteAsync(new InvocationMessage(methodName, args ?? Array.Empty<object[]>()), cancellationToken).AsTask();
             }
 
             var message = _protocol.WriteTargetedInvocation(MessageType.InvocationConnection, connectionId, methodName, args, null);
@@ -382,8 +384,6 @@ private async Task EnsureSqlServerConnection()
                 {
                     if (_streams.Count == 0)
                     {
-                        // NOTE: Called from a ThreadPool thread
-
                         var installer = new SqlInstaller(_options, _logger, _tableNamePrefix);
                         await installer.Install();