Skip to content

Commit e4b9a38

Browse files
ascott18ascott18
committed
Clean up dependencies
1 parent 8e4e860 commit e4b9a38

File tree

3 files changed

+18
-17
lines changed

3 files changed

+18
-17
lines changed

‎src/IntelliTect.AspNetCore.SignalR.SqlServer/IntelliTect.AspNetCore.SignalR.SqlServer.csproj‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
<Description>A Microsoft SQL Server backplane for ASP.NET Core SignalR.</Description>
1313
<PackageTags>IntelliTect aspnetcore sqlserver signalr</PackageTags>
1414

15-
1615
<!-- Sourcelink: -->
1716
<PublishRepositoryUrl>true</PublishRepositoryUrl>
1817
<EmbedUntrackedSources>true</EmbedUntrackedSources>
@@ -24,18 +23,20 @@
2423
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All"/>
2524

2625
<PackageReference Include="MessagePack" Version="2.3.75" />
27-
<PackageReference Include="Microsoft.AspNetCore.SignalR.Core" Version="1.1.0" />
2826
<PackageReference Include="Microsoft.Data.SqlClient" Version="3.0.0" />
29-
<PackageReference Include="Microsoft.Extensions.Logging" Version="5.0.0" />
30-
<PackageReference Include="System.Diagnostics.Tools" Version="4.3.0" />
31-
27+
3228
<PackageReference Include="Nullable" Version="1.3.0">
3329
<PrivateAssets>all</PrivateAssets>
3430
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
3531
</PackageReference>
3632
</ItemGroup>
3733

34+
<ItemGroup Condition="$(TargetFramework) != 'netstandard2.0'">
35+
<FrameworkReference Include="Microsoft.AspNetCore.App" />
36+
</ItemGroup>
3837
<ItemGroup Condition="$(TargetFramework) == 'netstandard2.0'">
38+
<PackageReference Include="Microsoft.Extensions.Logging" Version="2.2.0" />
39+
<PackageReference Include="Microsoft.AspNetCore.SignalR.Core" Version="1.1.0" />
3940
<PackageReference Include="System.ComponentModel.Annotations" Version="4.5.0" />
4041
</ItemGroup>
4142

‎src/IntelliTect.AspNetCore.SignalR.SqlServer/Internal/SqlServerProtocol.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public MessageType ReadMessageType(ReadOnlyMemory<byte> data)
4141
return (MessageType)reader.ReadByte();
4242
}
4343

44-
public byte[] WriteInvocationAll(string methodName, object?[] args, IReadOnlyList<string>? excludedConnectionIds)
44+
public byte[] WriteInvocationAll(string methodName, object?[]? args, IReadOnlyList<string>? excludedConnectionIds)
4545
{
4646
// Written as a MessagePack 'arr' containing at least these items:
4747
// * A MessagePack 'arr' of 'str's representing the excluded ids
@@ -65,7 +65,7 @@ public byte[] WriteInvocationAll(string methodName, object?[] args, IReadOnlyLis
6565
}
6666
}
6767

68-
public byte[] WriteTargetedInvocation(MessageType type, string target, string methodName, object?[] args, IReadOnlyList<string>? excludedConnectionIds)
68+
public byte[] WriteTargetedInvocation(MessageType type, string target, string methodName, object?[]? args, IReadOnlyList<string>? excludedConnectionIds)
6969
{
7070
// Written as a MessagePack 'arr' containing at least these items:
7171
// * A MessagePack 'arr' of 'str's representing the excluded ids
@@ -90,7 +90,7 @@ public byte[] WriteTargetedInvocation(MessageType type, string target, string me
9090
}
9191
}
9292

93-
private void WriteInvocationCore(ref MessagePackWriter writer, string methodName, object?[] args, IReadOnlyList<string>? excludedConnectionIds)
93+
private void WriteInvocationCore(ref MessagePackWriter writer, string methodName, object?[]? args, IReadOnlyList<string>? excludedConnectionIds)
9494
{
9595
// Written as a MessagePack 'arr' containing at least these items:
9696
// * A MessagePack 'arr' of 'str's representing the excluded ids

‎src/IntelliTect.AspNetCore.SignalR.SqlServer/SqlServerHubLifetimeManager.cs‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -136,21 +136,21 @@ public override Task OnDisconnectedAsync(HubConnectionContext connection)
136136
}
137137

138138
/// <inheritdoc />
139-
public override Task SendAllAsync(string methodName, object?[] args, CancellationToken cancellationToken = default)
139+
public override Task SendAllAsync(string methodName, object?[]? args, CancellationToken cancellationToken = default)
140140
{
141141
var message = _protocol.WriteInvocationAll(methodName, args, null);
142142
return PublishAsync(MessageType.InvocationAll, message);
143143
}
144144

145145
/// <inheritdoc />
146-
public override Task SendAllExceptAsync(string methodName, object?[] args, IReadOnlyList<string> excludedConnectionIds, CancellationToken cancellationToken = default)
146+
public override Task SendAllExceptAsync(string methodName, object?[]? args, IReadOnlyList<string> excludedConnectionIds, CancellationToken cancellationToken = default)
147147
{
148148
var message = _protocol.WriteInvocationAll(methodName, args, excludedConnectionIds);
149149
return PublishAsync(MessageType.InvocationAll, message);
150150
}
151151

152152
/// <inheritdoc />
153-
public override Task SendConnectionAsync(string connectionId, string methodName, object?[] args, CancellationToken cancellationToken = default)
153+
public override Task SendConnectionAsync(string connectionId, string methodName, object?[]? args, CancellationToken cancellationToken = default)
154154
{
155155
if (connectionId == null)
156156
{
@@ -170,7 +170,7 @@ public override Task SendConnectionAsync(string connectionId, string methodName,
170170
}
171171

172172
/// <inheritdoc />
173-
public override Task SendGroupAsync(string groupName, string methodName, object?[] args, CancellationToken cancellationToken = default)
173+
public override Task SendGroupAsync(string groupName, string methodName, object?[]? args, CancellationToken cancellationToken = default)
174174
{
175175
if (groupName == null)
176176
{
@@ -182,7 +182,7 @@ public override Task SendGroupAsync(string groupName, string methodName, object?
182182
}
183183

184184
/// <inheritdoc />
185-
public override Task SendGroupExceptAsync(string groupName, string methodName, object?[] args, IReadOnlyList<string> excludedConnectionIds, CancellationToken cancellationToken = default)
185+
public override Task SendGroupExceptAsync(string groupName, string methodName, object?[]? args, IReadOnlyList<string> excludedConnectionIds, CancellationToken cancellationToken = default)
186186
{
187187
if (groupName == null)
188188
{
@@ -194,7 +194,7 @@ public override Task SendGroupExceptAsync(string groupName, string methodName, o
194194
}
195195

196196
/// <inheritdoc />
197-
public override Task SendUserAsync(string userId, string methodName, object?[] args, CancellationToken cancellationToken = default)
197+
public override Task SendUserAsync(string userId, string methodName, object?[]? args, CancellationToken cancellationToken = default)
198198
{
199199
var message = _protocol.WriteTargetedInvocation(MessageType.InvocationUser, userId, methodName, args, null);
200200
return PublishAsync(MessageType.InvocationUser, message);
@@ -247,7 +247,7 @@ public override Task RemoveFromGroupAsync(string connectionId, string groupName,
247247
}
248248

249249
/// <inheritdoc />
250-
public override Task SendConnectionsAsync(IReadOnlyList<string> connectionIds, string methodName, object?[] args, CancellationToken cancellationToken = default)
250+
public override Task SendConnectionsAsync(IReadOnlyList<string> connectionIds, string methodName, object?[]? args, CancellationToken cancellationToken = default)
251251
{
252252
if (connectionIds == null)
253253
{
@@ -264,7 +264,7 @@ public override Task SendConnectionsAsync(IReadOnlyList<string> connectionIds, s
264264
}
265265

266266
/// <inheritdoc />
267-
public override Task SendGroupsAsync(IReadOnlyList<string> groupNames, string methodName, object?[] args, CancellationToken cancellationToken = default)
267+
public override Task SendGroupsAsync(IReadOnlyList<string> groupNames, string methodName, object?[]? args, CancellationToken cancellationToken = default)
268268
{
269269
if (groupNames == null)
270270
{
@@ -284,7 +284,7 @@ public override Task SendGroupsAsync(IReadOnlyList<string> groupNames, string me
284284
}
285285

286286
/// <inheritdoc />
287-
public override Task SendUsersAsync(IReadOnlyList<string> userIds, string methodName, object?[] args, CancellationToken cancellationToken = default)
287+
public override Task SendUsersAsync(IReadOnlyList<string> userIds, string methodName, object?[]? args, CancellationToken cancellationToken = default)
288288
{
289289
if (userIds.Count == 0)
290290
{

0 commit comments

Comments
 (0)