note offs in data prep

Author: victor-shepardson

notepredictor/notepredictor/data.py

@@ -41,11 +41,12 @@ def __getitem__(self, idx):
         # delta t of first note?
         time = time * (1 + random.random()*self.speed*2 - self.speed)
         # dequantize
-        # TODO: use actual tactus from MIDI file
+        # TODO: use actual tactus from MIDI file?
         time = (
             time + (torch.rand_like(time)-0.5)*2e-3
             ).clamp(0., float('inf'))
 
+        # TODO: random velocity curve?
         velocity = (
             velocity + 
             (torch.rand_like(time)-0.5) * ((velocity>0) & (velocity<127)).float()

notepredictor/scripts/lakh_prep.py

@@ -23,15 +23,16 @@ def process(fnames, min_len=64):
     s_per_tick = micros_per_beat / mid.ticks_per_beat / 1e6
 
     for i,tr in enumerate(mid.tracks):
-        seq = [m for m in tr if m.type=='note_on' and m.velocity]
+        seq = [m for m in tr if m.type=='note_on' or m.type=='note_off']
         if len(seq) < min_len:
             continue
         torch.save(dict(
             pitch=torch.LongTensor([m.note for m in seq]),
-            velocity=torch.LongTensor([m.velocity for m in seq]),
+            velocity=torch.LongTensor([
+                m.velocity if m.type=='note_on' else 0 for m in seq]),
             time=torch.Tensor([m.time for m in seq])*s_per_tick,
-            # src_track=i,
-            # tempo=micros_per_beat,
+            tempo=micros_per_beat,
+            ticks=mid.ticks_per_beat
         ), g.with_suffix(f'.{i}.pkl') )
 
 def main(data_path, dest_path, n_jobs=4):