Made Auto-generated for EF also call save changes

Author: joelsteventurner

Modules/Intent.Modules.Application.DomainInteractions/Intent.Application.DomainInteractions.imodspec

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <package>
   <id>Intent.Application.DomainInteractions</id>
-  <version>1.1.6</version>
+  <version>1.1.7-pre.0</version>
   <supportedClientVersions>[4.5.15-a,5.0.0)</supportedClientVersions>
   <summary>Provides interaction strategies to generate domain interaction implementations.</summary>
   <description>Provides interaction strategies to generate domain interaction implementations.</description>

Modules/Intent.Modules.Application.DomainInteractions/Intent.Modules.Application.DomainInteractions.csproj

@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <TargetFramework>net8.0</TargetFramework>
-    <Version>1.1.6</Version>
+    <Version>1.1.7-pre.0</Version>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <Nullable>enable</Nullable>
   </PropertyGroup>

Modules/Intent.Modules.Application.DomainInteractions/InteractionStrategies/CreateEntityInteractionStrategy.cs

@@ -98,7 +98,7 @@ private static void AddSaveChangesStatements(ICSharpClassMethodDeclaration metho
                 if (entity.ElementModel.IsClassModel())
                 {
                     var primaryKeys = entity.ElementModel.AsClassModel().GetTypesInHierarchy().SelectMany(c => c.Attributes.Where(a => a.IsPrimaryKey()));
-                    if (primaryKeys.Any(HasDBGeneratedPk))
+                    if (primaryKeys.Any(p => HasDBGeneratedPk(entity.ElementModel, p)))
                     {
                         method.AddStatement(ExecutionPhases.Persistence, new CSharpStatement($"{entity.DataAccessProvider.SaveChangesAsync()}"));
                     }
@@ -137,9 +137,34 @@ private static List<EntityDetails> GetEntitiesReturningPk(ICSharpClassMethodDecl
                 .ToList();
         }
 
-        private static bool HasDBGeneratedPk(AttributeModel attribute)
+        private class DataSources
         {
-            return attribute.IsPrimaryKey() && attribute.GetStereotypeProperty("Primary Key", "Data source", "Default") == "Default";
+            /// <summary>
+            /// Explicitly Stating the Keys are Auto-generated 
+            /// DB Tech may have options for how ths is done, e.g. EF has options here 
+            /// For EF this typically means assigned on Save Changes
+            /// For Cosmos this would typically be set on object construction
+            /// </summary>
+            public const string AutoGenerated = "Auto-generated";
+            /// <summary>
+            /// What ever the default is for the technology.
+            /// e.g. EF Auto-generated PKs, Guids EF assigned in Memory, Oridinals are DB Assigned
+            /// </summary>
+            public const string Default = "Default";
+            /// <summary>
+            /// PKS are set but the explicitly (Business keys, composite keys, these are typcially not auto assigned)
+            /// </summary>            
+            public const string UserSupplied = "User supplied";
+        }
+
+        private static bool HasDBGeneratedPk(IElement entity, AttributeModel attribute)
+        {
+            if (entity.Package.AsDomainPackageModel()?.HasStereotype("Relational Database") == true)
+            {
+                return attribute.IsPrimaryKey() && attribute.GetStereotypeProperty("Primary Key", "Data source", "Default") is DataSources.Default or DataSources.AutoGenerated;
+            }
+            // For document DBs User Supplied and Auto-generated is assumed to not be set by the DB
+            return attribute.IsPrimaryKey() && attribute.GetStereotypeProperty("Primary Key", "Data source", "Default") == DataSources.Default;
         }
     }
 }

Modules/Intent.Modules.Application.DomainInteractions/release-notes.md

@@ -1,3 +1,7 @@
+### Version 1.1.7
+
+- Fixed: CRUD not explicitly calls SaveChanges for EF when modeling Auto-generated primary keys.
+
 ### Version 1.1.6
 
 - Improvement: Improved error message when `ProjectTo` is selected as the query strategy with an unsupported provider (Mapperly).