Skip to content

Commit 8e89795

Browse files
committed
build: fix install script
1 parent c0eaa9e commit 8e89795

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

scripts/install.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ RUN OPTIONS:
3737
[-t|--torch torch version, default="2.0.0"]
3838
[--torchvision torchvision version, default="0.15.1"]
3939
[--cpu) build for cpu only)]
40-
[--cuda) provide cuda version e.g. "11.8", default: check nvcc output)]
40+
[--cuda_version) provide cuda version e.g. "11.8", default: check nvcc output)]
4141
[--detectron2_url use this if you want to specify a pre-built detectron2 (find at
4242
"https://detectron2.readthedocs.io/en/latest/tutorials/install.html#install-pre-built-detectron2-linux-only"),
4343
not required for regular versions derived from cuda and torch versions above.
@@ -47,7 +47,7 @@ RUN OPTIONS:
4747
[--no-weights) prevents the installation script from downloading vision model parameters]
4848
4949
50-
EXAMPLE [bash install.sh -m detectron2 -t "1.9.1" --cuda "11.8" --compressai /path/to/compressai]
50+
EXAMPLE [bash install.sh -m detectron2 -t "1.9.1" --cuda_version "11.8" --compressai /path/to/compressai]
5151
5252
_EOF_
5353
exit;
@@ -56,7 +56,7 @@ _EOF_
5656
-t|--torch) shift; TORCH_VERSION="$1"; shift; ;;
5757
--torchvision) shift; TORCHVISION_VERSION="$1"; shift; ;;
5858
--cpu) CPU="True"; shift; ;;
59-
--cuda) shift; CUDA_VERSION="$1"; shift; ;;
59+
--cuda_version) shift; CUDA_VERSION="$1"; shift; ;;
6060
--models_dir) shift; MODELS_PARENT_DIR="$1"; shift; ;;
6161
--no-prepare) NO_PREPARE="True"; shift; ;;
6262
--no-install) NO_INSTALL="True"; shift; ;;
@@ -81,6 +81,7 @@ b5905e9faf500a2608c93991f91a41a6150bcd2dd30986865a73becd94542fa1 yolox/darknet5
8181
MODELS_SOURCE_DIR="${MODELS_PARENT_DIR}/models"
8282
MODELS_WEIGHT_DIR="${MODELS_PARENT_DIR}/weights"
8383

84+
# pip3 is the default package manager, run install_uv.sh for uv
8485
PACKAGE_MANAGER="${PACKAGE_MANAGER:-pip3}"
8586

8687
detect_env() {
@@ -122,7 +123,6 @@ main () {
122123
run_install
123124
else
124125
echo "Skipping installation due to --no-install flag."
125-
return
126126
fi
127127

128128
if [ "${DOWNLOAD_WEIGHTS}" == "True" ]; then

0 commit comments

Comments
 (0)