build: Fix compilation errors with GCC 16.

* Fix unused-but-set-variable errors.
* net_nntp: Fix snprintf format-truncation error.

Author: InterLinked1

bbs/auth.c

@@ -426,7 +426,6 @@ static int valid_temp_token(const char *username, const char *password)
 {
 	struct pw_auth_token *t;
 	time_t now;
-	int total = 0;
 	int match = 0;
 
 	now = time(NULL);
@@ -447,7 +446,6 @@ static int valid_temp_token(const char *username, const char *password)
 			}
 			/* Don't break, we still want to purge any tokens that may be stale. */
 		}
-		total++;
 	}
 	RWLIST_TRAVERSE_SAFE_END;
 	RWLIST_UNLOCK(&auth_tokens);

bbs/socket.c

@@ -2400,10 +2400,10 @@ ssize_t bbs_timed_read(int fd, char *restrict buf, size_t len, int ms)
 		len -= (long unsigned) res;
 		if (len <= 0) {
 			bbs_debug(7, "Buffer (size %lu) is now full\n", len);
-			return res;
+			return bytes;
 		}
 		if (bbs_poll(fd, ms) <= 0) {
-			return res;
+			return bytes;
 		}
 	}
 	__builtin_unreachable();

external/modman.c

@@ -404,7 +404,6 @@ static int check_header_file(const char *dirname, const char *modname, int is_mo
 	char incpaths[sizeof(sys_include_paths)];
 	int exists = 0;
 	char *path, *paths = incpaths;
-	int num_incpaths = 0;
 	char filename[1024];
 	int common_include_file = 0;
 
@@ -428,7 +427,6 @@ static int check_header_file(const char *dirname, const char *modname, int is_mo
 
 		includedir = strchr(path, '/'); /* Skip leading whitespace, and strchr cannot return NULL. */
 		TERMINATE_AT(path, '\n');
-		num_incpaths++;
 
 		snprintf(filename, sizeof(filename), "%s/%s", includedir, incfile);
 		modman_log(8, "  Checking existence of %s\n", filename);

modules/mod_smtp_filter_arc.c

@@ -34,7 +34,10 @@ static ARC_LIB *lib;
 static int process_message(struct smtp_filter_data *f, ARC_MESSAGE *msg)
 {
 	ARC_STAT stat;
-	size_t headerslen, bodylen;
+	size_t headerslen;
+#ifdef EXTRA_CHECKS
+	size_t bodylen;
+#endif
 	char *headers, *header, *dup = NULL;
 	char full_header[4096];
 	char *hdrbuf;
@@ -102,10 +105,14 @@ static int process_message(struct smtp_filter_data *f, ARC_MESSAGE *msg)
 	}
 
 	body = smtp_message_body(f) + headerslen;
+#ifdef EXTRA_CHECKS
 	bodylen = f->size - headerslen;
+#endif
 	if (STARTS_WITH(body, "\r\n\r\n")) {
 		body += 2;
+#ifdef EXTRA_CHECKS
 		bodylen -= 2;
+#endif
 	}
 #ifdef EXTRA_CHECKS
 	bbs_assert(strlen(body) == bodylen);

nets/net_imap.c

@@ -4935,20 +4935,17 @@ static int imap_process(struct imap_session *imap, char *s, char *saved_tag, siz
 		res = handle_setacl(imap, s, 1);
 	} else if (!strcasecmp(command, "ENABLE")) {
 		char *cap;
-		int enabled = 0;
 		REQUIRE_ARGS(s);
 		/*! \todo This combined with our parsing of remote server capabilities could use a more formal capabilities flag-based int */
 		while ((cap = strsep(&s, " "))) {
 			/* The reply only contains capabilities that were enabled just now, not any that may have already been enabled. */
 			if (!strcasecmp(cap, "CONDSTORE")) {
 				imap->condstore = 1;
 				imap_send(imap, "ENABLED CONDSTORE");
-				enabled++;
 			} else if (!strcasecmp(cap, "QRESYNC")) {
 				imap->condstore = 1; /* Implicitly includes CONDSTORE */
 				imap->qresync = 1;
 				imap_send(imap, "ENABLED QRESYNC CONDSTORE");
-				enabled++;
 			} else {
 				bbs_warning("Unknown capability %s\n", cap);
 			}

nets/net_imap/imap_client_list.c

@@ -326,7 +326,6 @@ int list_virtual(struct imap_session *imap, struct list_command *lcmd)
 	FILE *fp;
 	char virtfile[256];
 	char line[256];
-	int l = 0;
 	struct bbs_parallel p;
 	int lineno = 0;
 	int skip_proxied = 0;
@@ -465,7 +464,6 @@ int list_virtual(struct imap_session *imap, struct list_command *lcmd)
 			break; /* If we're excluding all proxied accounts from the LIST response, we can stop now */
 		}
 
-		l++;
 		server = line;
 		prefix = strsep(&server, "|"); /* Use pipe in case mailbox name contains spaces */
 		if (!strncmp(prefix, "#", 1)) {

nets/net_nntp.c

@@ -398,7 +398,7 @@ static char *get_article_id(struct nntp_session *nntp, int number)
 static int on_head(const char *dir_name, const char *filename, struct nntp_session *nntp, int number, int msgfilter, const char *msgidfilter)
 {
 	FILE *fp;
-	char fullpath[256];
+	char fullpath[256 * 3];
 	const char *msgid;
 	char msgbuf[1001]; /* Enough for longest possible line */
 

tests/test.c

@@ -464,7 +464,6 @@ static void *io_relay(void *varg)
 			soft_assertions_failed++;
 		}
 		if (bbs_expect_str) {
-			int rounds = 0;
 			bbs_readline_append(&rldata, "\n", buf, (size_t) res, &ready);
 			/* Check if the line contains the expected output.
 			 * If we read multiple lines, loop until there's not a full line left in the buffer. */
@@ -484,7 +483,6 @@ static void *io_relay(void *varg)
 				}
 				/* Don't append, just shift the buffer and check if we can read immediately. */
 				bbs_readline_append(&rldata, "\n", NULL, 0, &ready);
-				rounds++;
 			}
 			if (startup_run_unit_tests_started == 1) {
 				bbs_debug(5, "Stalling until expect reactivated\n");
@@ -1237,8 +1235,8 @@ static int run_test(const char *filename, int multiple)
 				alarm(0); /* Cancel any pending alarm */
 				bbs_debug(3, "Test '%s' returned %d\n", filename, res);
 #if 1
-				 /* Allow the poor BBS time for catching its breath.
-				  * test_irc under valgrind no longer seems to need this due to locking fixes, but LBBS-80 is exacerbated by removing this */
+				/* Allow the poor BBS time for catching its breath. */
+				/* FIXME test_irc under valgrind no longer seems to need this due to locking fixes, but LBBS-80 is exacerbated by removing this */
 				usleep(50000);
 #endif
 			} else {