patches: Prevent creation of duplicate Asterisk processes.

Slipstream the following patch, which was not merged when up on Gerrit,
and is probably not really worth the effort of trying to upstream again
due to the resistance it received before:

* ASTERISK-30339 (Gerrit 19655) asterisk.c: Prevent creation of
  duplicate Asterisk processes (Dec 2022)

Author: InterLinked1

README.md

@@ -14,6 +14,7 @@ PhreakScript installs:
    - Bug fixes for reading and writing configuration file templates
    - Bug fix for ConfBridge shutdown race condition
    - Enhances performance by completely removing Newexten AMI event
+   - Prevents duplicate Asterisk process creation
 - Many additional features and improvements
    - Adds prefix capabilities to `include => `
    - Signaling enhancements

patches/19655-asterisk.c-Prevent-duplicate-Asterisk-processes-fro.patch

@@ -0,0 +1,80 @@
+From 6a35b12e045da797ff030c85c1692b5585710d37 Mon Sep 17 00:00:00 2001
+From: Naveen Albert <[email protected]>
+Date: Sun, 4 Dec 2022 14:58:35 +0000
+Subject: [PATCH] asterisk.c: Prevent duplicate Asterisk processes from
+ starting.
+
+During startup, there is a period of time between when the daemon
+is started and when Asterisk starts accepting socket connections
+for remote consoles, during which if another attempt is made to
+start the Asterisk daemon, it will succeed. This will lead to
+multiple Asterisk processes running concurrently, causing all
+sorts of issues.
+
+A check is now added before starting the daemon to check if
+if the PID in the PID file is currently running, and if so,
+to abort to avoid starting a duplicate Asterisk process.
+
+ASTERISK-30339 #close
+
+Change-Id: I38d8d75567524ffd6b1779aa24e7f2bd6951fbb3
+---
+ main/asterisk.c | 35 +++++++++++++++++++++++++++++++++++
+ 1 file changed, 35 insertions(+)
+
+diff --git a/main/asterisk.c b/main/asterisk.c
+index dea849f10c..21da28c1fb 100644
+--- a/main/asterisk.c
++++ b/main/asterisk.c
+@@ -1696,6 +1696,35 @@ static int ast_tryconnect(void)
+ 		return 1;
+ }
+ 
++static int ast_is_starting(void)
++{
++	/* Don't use kill since that only works if Asterisk was started as the same user. */
++	struct stat st;
++	FILE *f;
++	long file_pid = 0;
++	char procpath[PATH_MAX];
++
++	/* Get current value from PID file */
++	f = fopen(ast_config_AST_PID, "r");
++	if (!f) {
++		return 0; /* PID file doesn't exist? No way to tell. */
++	}
++	fscanf(f, "%ld", &file_pid);
++	fclose(f);
++	if (!file_pid) {
++		return 0;
++	}
++
++	/* Check if such a process is running */
++	snprintf(procpath, sizeof(procpath), "/proc/%ld", file_pid);
++	if (stat(procpath, &st) == -1 && errno == ENOENT) {
++		/* Process doesn't exist */
++		return 0;
++	}
++	return 1;
++}
++
++
+ /*! \brief Urgent handler
+  *
+  * Called by soft_hangup to interrupt the poll, read, or other
+@@ -4021,6 +4050,12 @@ int main(int argc, char *argv[])
+ 		exit(1);
+ 	}
+ 
++	if (ast_is_starting()) {
++		fprintf(stderr, "Asterisk is currently starting.  Use 'asterisk -r' to connect momentarily.\n");
++		printf("%s", term_quit());
++		exit(1);
++	}
++
+ #ifdef HAVE_CAP
+ 	child_cap = cap_from_text("cap_net_admin-eip");
+ #endif
+-- 
+2.30.2
+

phreaknet.sh

@@ -2255,12 +2255,8 @@ phreak_patches() { # $1 = $PATCH_DIR, $2 = $AST_SRC_DIR
 	phreak_tree_module "funcs/func_query.c"
 	phreak_tree_module "funcs/func_resonance.c"
 	phreak_tree_module "funcs/func_tech.c"
-	phreak_tree_module "res/res_coindetect.c"
-
-	if [ "$DEVMODE" = "1" ]; then
-		phreak_tree_module "res/res_deadlock.c" # this is not possibly useful to non-developers
-	fi
 
+	phreak_tree_module "res/res_coindetect.c"
 	phreak_tree_module "res/res_alarmsystem.c"
 	phreak_tree_module "res/res_digitmap.c"
 	phreak_tree_module "res/res_irc.c"
@@ -2270,6 +2266,9 @@ phreak_patches() { # $1 = $PATCH_DIR, $2 = $AST_SRC_DIR
 	phreak_tree_module "res/res_pjsip_presence.c"
 	phreak_tree_module "res/res_smdr_whozz.c"
 
+	if [ "$DEVMODE" = "1" ]; then
+		phreak_tree_module "res/res_deadlock.c" # this is not possibly useful to non-developers
+	fi
 	if [ -d /etc/dahdi ]; then
 		phreak_tree_module "apps/app_loopdisconnect.c"
 		if [ "$RTPULSING" = "1" ]; then
@@ -2326,6 +2325,11 @@ phreak_patches() { # $1 = $PATCH_DIR, $2 = $AST_SRC_DIR
 	asterisk_pr_unconditional 971 # config.c fix issues w/ whitespace in comments
 	asterisk_pr_unconditional 1030 # chan_dahdi: Fix wrong channel state when RINGING recieved
 
+	#asterisk_pr_unconditional 272 # Call Waiting Deluxe. This also now conflicts (with the latest revisions), so temp. disabled.
+	#asterisk_pr_unconditional 438 # Last Number Redial. This now conflicts with 272, so temp. disabled.
+	asterisk_pr_unconditional 292 # GROUP VARs
+	git_custom_patch "https://code.phreaknet.org/asterisk/dahdicleanup.diff"
+
 	if [ $AST_MAJOR_VER -lt 21 ]; then
 		if [ "$EXTERNAL_CODECS" = "1" ]; then
 			phreak_nontree_patch "main/translate.c" "translate.diff" "https://issues.asterisk.org/jira/secure/attachment/60464/translate.diff" # Bug fix to translation code
@@ -2336,39 +2340,23 @@ phreak_patches() { # $1 = $PATCH_DIR, $2 = $AST_SRC_DIR
 		fi
 	fi
 
-	# Unmerged patches
-	git_patch "app_confbridge_Fix_bridge_shutdown_race_condition.patch" # app_confbridge: Fix bridge shutdown race condition
-
-	## WIP
-	asterisk_pr_unconditional 292 # GROUP VARs
-
-	# Unmerged
-	#asterisk_pr_unconditional 272 # Call Waiting Deluxe. This also now conflicts (with the latest revisions), so temp. disabled.
-	#asterisk_pr_unconditional 438 # Last Number Redial. This now conflicts with 272, so temp. disabled.
-
-	### TODO: Include ASTERISK-30339 and ASTERISK-30374 once resubmitted on GitHub
-
 	if [ "$RTPULSING" = "1" ]; then
 		# Patches split up to make it easier to selectively redo the 2nd one if a patch conflict occurs and the patch needs to be rebased.
 		git_patch "ast_rtoutpulsing1.diff" # chan_dahdi: add rtoutpulsing
 		git_patch "ast_rtoutpulsing2.diff" # chan_dahdi: add rtoutpulsing
 	fi
 
+	# Out of tree patches
+	git_patch "app_confbridge_Fix_bridge_shutdown_race_condition.patch" # app_confbridge: Fix bridge shutdown race condition
 	git_patch "blueboxing.diff" # dsp: make blue boxing easier
 	git_patch "prefixinclude.diff" # pbx: prefix includes
 	git_patch "agi_record_noisefirst.diff" # res_agi: Add noise before silence detection option to Record AGI
-
-	git_custom_patch "https://code.phreaknet.org/asterisk/dahdicleanup.diff"
+	git_patch "19655-asterisk.c-Prevent-duplicate-Asterisk-processes-fro.patch" # Prevent duplicate Asterisk process creation
 
 	if [ "$EXPERIMENTAL_FEATURES" = "1" ] && [ $AST_MAJOR_VER -ge 21 ]; then
 		printf "Installing 21+ patches for experimental features\n"
 		add_experimental
 	fi
-
-	if [ "$DEVMODE" = "1" ]; then # highly experimental
-		# res_pbx_validate
-		:
-	fi
 }
 
 freebsd_port_patch() {