Unconditionally include limits.h

According to the Autoconf manual, hosted environments that are still of
interest for portable code provide all of the headers specified in C89,
which includes limits.h.  There's no need in checking for it.

Author: Julien-Elie

configure.ac

@@ -592,7 +592,7 @@ dnl Special checks for header files.
 AC_HEADER_STDBOOL
 
 dnl Generic checks for header files.
-AC_CHECK_HEADERS([crypt.h inttypes.h limits.h \
+AC_CHECK_HEADERS([crypt.h inttypes.h \
                   stdint.h strings.h sys/bitypes.h sys/filio.h sys/loadavg.h \
                   sys/select.h sys/time.h sys/uio.h syslog.h unistd.h])
 

innfeed/article.c

@@ -21,9 +21,7 @@
 #include <assert.h>
 #include <errno.h>
 #include <fcntl.h>
-#if HAVE_LIMITS_H
-#    include <limits.h>
-#endif
+#include <limits.h>
 #include <sys/stat.h>
 #include <syslog.h>
 

innfeed/endpoint.c

@@ -19,15 +19,12 @@
 #include <assert.h>
 #include <errno.h>
 #include <fcntl.h>
+#include <limits.h>
 #include <signal.h>
 #include <sys/stat.h>
 #include <sys/uio.h>
 #include <syslog.h>
 
-#ifdef HAVE_LIMITS_H
-#    include <limits.h>
-#endif
-
 #ifdef HAVE_SYS_SELECT_H
 #    include <sys/select.h>
 #endif

innfeed/host.c

@@ -13,15 +13,12 @@
 #include <ctype.h>
 #include <errno.h>
 #include <float.h>
+#include <limits.h>
 #include <math.h>
 #include <netdb.h>
 #include <sys/param.h>
 #include <syslog.h>
 
-#ifdef HAVE_LIMITS_H
-#    include <limits.h>
-#endif
-
 #include "inn/innconf.h"
 #include "inn/libinn.h"
 #include "inn/messages.h"

lib/fdlimit.c

@@ -15,6 +15,10 @@
 **  Note that on some versions of Linux (2.2.x reported), sysconf may return
 **  the wrong value for the maximum file descriptors.  getrlimit is correct,
 **  so always prefer it.
+**
+**  Written by Russ Allbery in 2000.
+**  Various bug fixes, code and documentation improvements since then
+**  in 2000, 2001, 2006, 2011, 2014, 2021, 2023, 2025.
 */
 
 #include "portable/system.h"
@@ -118,9 +122,7 @@ getfdlimit(void)
 }
 
 #else /* no function mechanism available */
-#    if HAVE_LIMITS_H
-#        include <limits.h>
-#    endif
+#    include <limits.h>
 #    include <sys/param.h>
 
 int

m4/iov-max.m4

@@ -1,5 +1,9 @@
 dnl Probe for the maximum number of iovecs accepted by writev.
 dnl
+dnl Written by Russ Allbery in 2003.
+dnl Various bug fixes, code and documentation improvements since then
+dnl in 2009, 2019, 2021, 2022, 2025.
+dnl
 dnl Check for the maximum number of elements in an iovec (IOV_MAX).  SVr4
 dnl systems appear to use that name for this limit (checked Solaris 2.6, IRIX
 dnl 6.5, and HP-UX 11.00).  Linux doesn't have it, but instead has UIO_MAXIOV
@@ -16,15 +20,13 @@ dnl Source used by INN_MACRO_IOV_MAX.
 AC_DEFUN([_INN_MACRO_IOV_MAX_SOURCE], [[
 #include <errno.h>
 #include <fcntl.h>
+#include <limits.h>
 #include <stdio.h>
 #include <sys/types.h>
 #include <sys/uio.h>
 #ifdef HAVE_UNISTD_H
 # include <unistd.h>
 #endif
-#ifdef HAVE_LIMITS_H
-# include <limits.h>
-#endif
 
 int
 main()
@@ -60,9 +62,7 @@ main()
 
 dnl Headers to use for checking for an IOV_MAX definition.
 AC_DEFUN([_INN_MACRO_IOV_MAX_HEADERS], [AC_INCLUDES_DEFAULT] [[
-#ifdef HAVE_LIMITS_H
-# include <limits.h>
-#endif
+#include <limits.h>
 ]])
 
 dnl Do the actual check.

nnrpd/article.c

@@ -5,10 +5,8 @@
 #include "portable/system.h"
 
 #include <assert.h>
-#if HAVE_LIMITS_H
-#    include <limits.h>
-#endif
 #include <ctype.h>
+#include <limits.h>
 #include <sys/uio.h>
 
 #include "cache.h"

storage/buffindexed/buffindexed.c

@@ -1,18 +1,22 @@
 /*
 **  Overview buffer and index method.
+**
+**  Originally written in 1999.
+**  Various bug fixes, code and documentation improvements since then
+**  in 1999-2010, 2013-2017, 2019-2025.
 */
 
 /*
-** Buffindexed using shared memory on ovbuff by Sang-yong Suh
+**  Buffindexed using shared memory on ovbuff by Sang-yong Suh.
 **
-** During the recent discussions in inn-workers, Alex Kiernan found
-** that inn_lock_range() is not working for MMAPed file.  This explains
-** why buffindexed has long outstanding bugs such as "could not MMAP...".
+**  During the discussions in inn-workers in 2003, Alex Kiernan found
+**  that inn_lock_range() is not working for MMAPed file.  This explains
+**  why buffindexed has long outstanding bugs such as "could not MMAP...".
 **
-** This version corrects the file locking error by using shared memory.
-** The bitfield of each buffer file is loaded into memory, and is shared
-** by all programs such as innd, expireover, makehistory, and overchan.
-** The locking problem is handled by semaphore.
+**  This version corrects the file locking error by using shared memory.
+**  The bitfield of each buffer file is loaded into memory, and is shared
+**  by all programs such as innd, expireover, makehistory, and overchan.
+**  The locking problem is handled by semaphore.
 */
 
 #include "portable/system.h"
@@ -22,9 +26,7 @@
 #include <ctype.h>
 #include <errno.h>
 #include <fcntl.h>
-#if HAVE_LIMITS_H
-#    include <limits.h>
-#endif
+#include <limits.h>
 #include <sys/stat.h>
 #include <time.h>
 

storage/cnfs/cnfs.c

@@ -1,5 +1,10 @@
 /*
 **  Storage manager module for Cyclic News File System method.
+**
+**  Rewritten and cleaned by Scott Fritchie from its INN 1.5.1 incarnation
+**  in 1998.
+**  Various bug fixes, code and documentation improvements since then
+**  in 1998-2011, 2014, 2015, 2017-2025.
 */
 
 #include "portable/system.h"
@@ -8,9 +13,7 @@
 #include <ctype.h>
 #include <errno.h>
 #include <fcntl.h>
-#if HAVE_LIMITS_H
-#    include <limits.h>
-#endif
+#include <limits.h>
 #include <netinet/in.h>
 #include <sys/stat.h>
 #include <sys/uio.h>

storage/ovdb/ovdb.c

@@ -5,7 +5,7 @@
  *
  * Created in 1999.
  * Various bug fixes, code and documentation improvements since then
- * in 2000-2006, 2008, 2010, 2011, 2013-2015, 2017, 2018, 2021-2024.
+ * in 2000-2006, 2008, 2010, 2011, 2013-2015, 2017, 2018, 2021-2025.
  *
  * See the full commit history for more details.
  * Below follows a list of the major initial changes:
@@ -82,9 +82,7 @@
 #include "portable/socket.h"
 #include <errno.h>
 #include <fcntl.h>
-#ifdef HAVE_LIMITS_H
-#    include <limits.h>
-#endif
+#include <limits.h>
 #include <signal.h>
 #ifdef HAVE_SYS_SELECT_H
 #    include <sys/select.h>