Skip to content

Commit 514c293

Browse files
committed
Fix tests: take include-pattern into account
pls fix arrange step (code to check)
1 parent 38a5897 commit 514c293

File tree

9 files changed

+18
-25
lines changed

9 files changed

+18
-25
lines changed

IxDFCodingStandard/Sniffs/Classes/ForbidDirectClassInheritanceSniff.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ final class ForbidDirectClassInheritanceSniff implements Sniff
1010
public const FORBIDDEN_CLASS_INHERITED = 'ForbiddenInheritance';
1111

1212
/**
13-
* A list of forbidden classes not allowed to inherit directly.
13+
* A list of forbidden classes isn't allowed to inherit directly.
1414
* Usually used to force developers to use our custom wrappers instead of framework or library functionality.
1515
* @var array<class-string, class-string|null>
1616
*/

IxDFCodingStandard/ruleset.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -570,7 +570,7 @@
570570
<exclude-pattern>*/*\.blade.php</exclude-pattern>
571571
</rule>
572572
<rule ref="IxDFCodingStandard.NamingConventions.CamelCaseRouteName">
573-
<include-pattern>routes/</include-pattern>
573+
<include-pattern>*/routes/*</include-pattern>
574574
</rule>
575575
<rule ref="IxDFCodingStandard.NamingConventions.MeaningfulVariableName">
576576
<properties>

tests/Sniffs/NamingConventions/CamelCaseRouteNameSniffTest.php

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,24 +10,26 @@ final class CamelCaseRouteNameSniffTest extends TestCase
1010
/** @test */
1111
public function it_does_not_report_about_camel_case_route_name(): void
1212
{
13-
$report = self::checkFile(__DIR__.'/data/routeNameUsesCamelCase.php');
13+
$report = self::checkFile(__DIR__.'/data/routes/routeNameUsesCamelCase.php');
1414

1515
self::assertNoSniffErrorInFile($report);
1616
}
1717

1818
/** @test */
1919
public function it_reports_about_kebab_case_route_name(): void
2020
{
21-
$report = self::checkFile(__DIR__.'/data/routeNameUsesKebabCase.php', [], [], [__DIR__.'/data/routeNameUsesKebabCase.php']);
21+
$report = self::checkFile(__DIR__.'/data/routes/routeNameUsesKebabCase.php');
2222

23-
self::assertSniffError($report, 2, CamelCaseRouteNameSniff::CODE_NOT_CAMEL_CASE_ROUTE_NAME);
23+
self::assertSame(1, $report->getErrorCount());
24+
self::assertSniffError($report, 3, CamelCaseRouteNameSniff::CODE_NOT_CAMEL_CASE_ROUTE_NAME);
2425
}
2526

2627
/** @test */
2728
public function it_reports_about_snake_case_route_name(): void
2829
{
29-
$report = self::checkFile(__DIR__.'/data/routeNameUsesSnakeCase.php', [], [CamelCaseRouteNameSniff::CODE_NOT_CAMEL_CASE_ROUTE_NAME], ['--standard=IxDFCodingStandard']);
30+
$report = self::checkFile(__DIR__.'/data/routes/routeNameUsesKebabCase.php');
3031

31-
self::assertSniffError($report, 2, CamelCaseRouteNameSniff::CODE_NOT_CAMEL_CASE_ROUTE_NAME);
32+
self::assertSame(1, $report->getErrorCount());
33+
self::assertSniffError($report, 3, CamelCaseRouteNameSniff::CODE_NOT_CAMEL_CASE_ROUTE_NAME);
3234
}
3335
}

tests/Sniffs/NamingConventions/data/routeNameUsesCamelCase.php

Lines changed: 0 additions & 6 deletions
This file was deleted.

tests/Sniffs/NamingConventions/data/routeNameUsesKebabCase.php

Lines changed: 0 additions & 6 deletions
This file was deleted.

tests/Sniffs/NamingConventions/data/routeNameUsesSnakeCase.php

Lines changed: 0 additions & 6 deletions
This file was deleted.
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
<?php declare(strict_types=1);
2+
3+
Route::get('test', 'SomeController')->name('route.uses.camelCase.name');
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
<?php declare(strict_types=1);
2+
3+
Route::get('test', 'SomeController')->name('route.uses.kebab-case.name');
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
<?php declare(strict_types=1);
2+
3+
Route::get('test', 'SomeController')->name('route.uses.snake_case.name');

0 commit comments

Comments
 (0)