Optimize isPurposeAllowed() to just check the bit instead of creating the waste set every time

wei zhiwei · wei zhiwei · commit 391d638c63de · 2018-06-13T14:13:54.000+08:00
diff --git a/src/main/java/com/iab/gdpr/consent/implementation/v1/ByteBufferBackedVendorConsent.java b/src/main/java/com/iab/gdpr/consent/implementation/v1/ByteBufferBackedVendorConsent.java
@@ -100,8 +100,8 @@ public int getMaxVendorId() {
 
     @Override
     public boolean isPurposeAllowed(int purposeId) {
-        if (purposeId < 1) return false;
-        return getAllowedPurposeIds().contains(purposeId);
+        if (purposeId < 1 || purposeId > PURPOSES_SIZE) return false;
+        return bits.getBit(PURPOSES_OFFSET + purposeId - 1);
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -100,8 +100,8 @@ public int getMaxVendorId() {`
`100`	`100`
`101`	`101`	`@Override`
`102`	`102`	`public boolean isPurposeAllowed(int purposeId) {`
`103`		`- if (purposeId < 1) return false;`
`104`		`- return getAllowedPurposeIds().contains(purposeId);`
	`103`	`+ if (purposeId < 1 \|\| purposeId > PURPOSES_SIZE) return false;`
	`104`	`+ return bits.getBit(PURPOSES_OFFSET + purposeId - 1);`
`105`	`105`	`}`
`106`	`106`
`107`	`107`	`@Override`