Skip to content

Commit be8b5c2

Browse files
author
Timothy M. Ace
committed
Fix dispose method on IntersectionObserver technique to reference this.element and prevent runtime errors during a dispose call. Reference: Issue #23
1 parent 3c2bc36 commit be8b5c2

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

demo/vpaid/vpaid-client.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1619,8 +1619,8 @@ var IntersectionObserver = function (_BaseTechnique) {
16191619
key: 'dispose',
16201620
value: function dispose() {
16211621
if (this.observer) {
1622-
this.observer.unobserve(element);
1623-
this.observer.disconnect(element);
1622+
this.observer.unobserve(this.element);
1623+
this.observer.disconnect(this.element);
16241624
}
16251625
}
16261626

dist/openvv.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Measurement/MeasurementTechniques/IntersectionObserver.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ export default class IntersectionObserver extends BaseTechnique {
4646
*/
4747
dispose() {
4848
if(this.observer) {
49-
this.observer.unobserve(element);
50-
this.observer.disconnect(element);
49+
this.observer.unobserve(this.element);
50+
this.observer.disconnect(this.element);
5151
}
5252
}
5353

@@ -106,4 +106,4 @@ export default class IntersectionObserver extends BaseTechnique {
106106
}
107107
}
108108

109-
}
109+
}

0 commit comments

Comments
 (0)