Skip to content

Commit 810291b

Browse files
committed
Update default parameters
1 parent 0c43862 commit 810291b

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

pysplashsurf/pysplashsurf/__init__.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -515,15 +515,15 @@ def convert_tris_to_quads(
515515

516516

517517
def reconstruction_pipeline(
518-
particles, *, attributes_to_interpolate={}, particle_radius=0.025,
519-
rest_density=1000.0, smoothing_length=2.0, cube_size=0.5,
518+
particles, *, attributes_to_interpolate={}, particle_radius,
519+
rest_density=1000.0, smoothing_length=2.0, cube_size,
520520
iso_surface_threshold=0.6, enable_multi_threading=True, mesh_smoothing_weights=False, sph_normals=False,
521-
mesh_smoothing_weights_normalization=13.0, mesh_smoothing_iters=5, normals_smoothing_iters=5,
521+
mesh_smoothing_weights_normalization=13.0, mesh_smoothing_iters=None, normals_smoothing_iters=None,
522522
mesh_cleanup=False, decimate_barnacles=False, keep_vertices=False,
523523
compute_normals=False, output_raw_normals=False, output_mesh_smoothing_weights=False, mesh_aabb_clamp_vertices=False,
524-
subdomain_grid=False, subdomain_num_cubes_per_dim=64, aabb_min=None, aabb_max=None, mesh_aabb_min=None, mesh_aabb_max=None
524+
subdomain_grid=True, subdomain_num_cubes_per_dim=64, aabb_min=None, aabb_max=None, mesh_aabb_min=None, mesh_aabb_max=None
525525
):
526-
"""Surface reconstruction based on particle positions and post processing
526+
"""Surface reconstruction based on particle positions and post-processing
527527
528528
Parameters
529529
----------
@@ -542,10 +542,10 @@ def reconstruction_pipeline(
542542
Rest density of the fluid
543543
544544
smoothing_length: float
545-
Smoothing length of the fluid
545+
Smoothing length of the fluid in multiples of the particle radius (compact support radius of SPH kernel will be twice the smoothing length)
546546
547547
cube_size: float
548-
Size of the cubes used in the uniform grid
548+
Size of the cubes used for the marching cubes grid in multiples of the particle radius
549549
550550
iso_surface_threshold: float
551551
Threshold for the iso surface
@@ -566,7 +566,7 @@ def reconstruction_pipeline(
566566
Number of iterations for the mesh smoothing
567567
568568
normals_smoothing_iters: int
569-
Number of iterations for the normals smoothing
569+
Number of iterations for the normal smoothing
570570
571571
mesh_cleanup: bool
572572
Flag to perform mesh cleanup
@@ -632,4 +632,4 @@ def reconstruction_pipeline(
632632
mesh_smoothing_iters=mesh_smoothing_iters, mesh_smoothing_weights=mesh_smoothing_weights, mesh_smoothing_weights_normalization=mesh_smoothing_weights_normalization,
633633
output_mesh_smoothing_weights=output_mesh_smoothing_weights, output_raw_normals=output_raw_normals, mesh_aabb_min=mesh_aabb_min, mesh_aabb_max=mesh_aabb_max, mesh_aabb_clamp_vertices=mesh_aabb_clamp_vertices)
634634
else:
635-
raise ValueError("Invalid data type (only float32 and float64 are supported, consider explicitly specifying the dtype for particles)")
635+
raise ValueError("Invalid data type (only float32 and float64 are supported, consider explicitly specifying the dtype for particles)")

0 commit comments

Comments
 (0)