Fix clippy errors

Author: w1th0utnam3

splashsurf/src/io.rs

@@ -287,7 +287,7 @@ pub fn to_binary_f32<R: Real, P: AsRef<Path>>(file: P, values: &[R]) -> Result<(
 
     for v in values {
         let v_f32 = v.to_f32().unwrap();
-        writer.write(&v_f32.to_ne_bytes())?;
+        writer.write_all(&v_f32.to_ne_bytes())?;
     }
 
     Ok(())

splashsurf_lib/src/io/bgeo_format.rs

@@ -481,7 +481,6 @@ mod parser {
 
     /// Parses a single BGEO attribute definition
     fn parse_attr_def(input: &[u8]) -> IResult<&[u8], AttribDefinition, BgeoParserError<&[u8]>> {
-        let input = input;
         let (input, name_length) = number::be_u16(input)?;
         let (input, name) = map_res(take(name_length as usize), |input: &[u8]| {
             std::str::from_utf8(input).map_err(|_| BgeoParserErrorKind::InvalidAttributeName)

splashsurf_lib/src/postprocessing.rs

@@ -803,11 +803,7 @@ pub fn convert_tris_to_quads<R: Real>(
                             // Check normal deviation of triangles
                             if convert {
                                 let dot_i_j = tri_normals[i].dot(&tri_normals[j]);
-                                if dot_i_j >= min_dot {
-                                    convert = convert;
-                                } else {
-                                    convert = false;
-                                }
+                                convert = dot_i_j >= min_dot;
                             }
 
                             if convert {

splashsurf_lib/src/utils.rs

@@ -79,7 +79,8 @@ impl<'a, T> UnsafeSlice<'a, T> {
     }
 
     /// Returns a mutable reference to an element of the wrapped slice without doing bounds checking, simultaneous access has to be disjoint!
-    /// SAFETY: It is UB to obtain two mutable references to the same index.
+    /// SAFETY: It is unsound to obtain two mutable references to the same index.
+    #[allow(clippy::mut_from_ref)]
     pub unsafe fn get_mut_unchecked(&self, i: usize) -> &mut T {
         debug_assert!(i < self.len(), "index out of bounds");
         &mut *self.slice.get_unchecked(i).get()