CDC and HID don't seem to coexist properly (STM32F072)

[bentwire]

I got all my CDC issues fixed, so now I am moving on to the HID portion of my code. I have the hid device defined (it is a simple 2 axis joystick, the report desc is 57 bytes), but when I mount it and the CDC interface Linux can't properly detect the HID interface. If I comment out the mounting of the CDC interface the HID interface gets detected fine (I've not tried to send data yet).

Any suggestions on what I may have done wrong? I can post a gist of the HID code if you need, it is fairly short.

Unfortunately on this hardware I don't have access to the JTAG/SWD interface so I can't attach a debugger. :(

[benedekkupper]

Does the CDC interface (function really, but let's not get too technical) get detected though? How do you set the endpoint addresses?

[bentwire]

Yep, the CDC interface gets detected and functions. The string descriptors don't work properly (lsusb says error) but it does get detected and I can read from it.

I set them as follows:

void UsbDevice_Init(void)
{
    /* Initialize the device */
    USBD_Init(UsbDevice, dev_cfg);

    /* All fields of Config have to be properly set up */
    console_if->Config.InEpNum  = 0x81;
    console_if->Config.OutEpNum = 0x01;
    console_if->Config.NotEpNum = 0x82;

    joy_if->Config.InEpNum      = 0x83;

    /* Mount the interfaces to the device */
    USBD_CDC_MountInterface(console_if, UsbDevice);
    //USBD_HID_MountInterface(joy_if, UsbDevice);

    /* The device connection can be made */
    USBD_Connect(UsbDevice);
}

[benedekkupper]

This part look ok. Does the HID interface work on its own?

[bentwire]

Yes if I comment out the CDC mount the HID interface gets detected fine. I have not tried to send data yet however.

[benedekkupper]

This works just fine for me, e.g. with the DebugDongle, so it's more likely that something specific to your implementation is the problem.

[bentwire]

It sends data fine as well.

[bentwire]

Hmm I wonder what it could be. I do have a USB Beagle 12 that I could do a bus dump with while it enumerates. Would that be of help?

Yeah I used DebugDongle as an example actually.

[bentwire]

Ok this is weird... I reversed the mount order, and now the both work:

void UsbDevice_Init(void)
{
    /* Initialize the device */
    USBD_Init(UsbDevice, dev_cfg);

    /* All fields of Config have to be properly set up */
    console_if->Config.InEpNum  = 0x81;
    console_if->Config.OutEpNum = 0x01;
    console_if->Config.NotEpNum = 0x82;

    joy_if->Config.InEpNum      = 0x83;

    /* Mount the interfaces to the device */
    USBD_HID_MountInterface(joy_if, UsbDevice);
    USBD_CDC_MountInterface(console_if, UsbDevice);
    
    /* The device connection can be made */
    USBD_Connect(UsbDevice);
}

The strings still show (error) in lsusb output, but both interfaces work...

[benedekkupper]

Do you enable this flag: USBD_HID_REPORT_STRINGS ? Do you have anything specific about your string handling?

[bentwire]

I do not. Here is my config:

#ifndef __USBD_CONFIG_H_
#define __USBD_CONFIG_H_

/** @addtogroup USBD_Exported_Macros
 * @{ */

/** @brief Must be set according to the highest number of interfaces for a given USB Device. */
#define USBD_MAX_IF_COUNT           8

/** @brief Must be set higher than:
 * @arg the length of the entire USB device configuration descriptor
 * @arg the longest USB string (as Unicode string descriptor)
 * @arg the length of the longest class-specific control request */
#define USBD_EP0_BUFFER_SIZE        256

/** @brief Set to 1 if peripheral support and application demand
 * for High-Speed operation both exist. */
#define USBD_HS_SUPPORT             0

/** @brief When set to 0, no SerialNumber is readable by the host.
 * Otherwise the SerialNumber will be converted from USBD_SERIAL_BCD_SIZE / 2
 * amount of raw bytes to string BCD format and sent to the host. */
#define USBD_SERIAL_BCD_SIZE        48



/** @brief Set to 1 if notifications are sent by a CDC-ACM interface.
 * In this case notification EP will be allocated and opened if its address is valid. */
#define USBD_CDC_NOTEP_USED         1

/** @brief Set to 1 if SET_CONTROL_LINE_STATE request is used by a CDC-ACM interface. */
#define USBD_CDC_CONTROL_LINE_USED  0

/** @brief Set to 1 if SEND_BREAK request is used by a CDC-ACM interface. */
#define USBD_CDC_BREAK_SUPPORT      0



/** @brief Set to 1 if a DFU interface holds more than one applications as alternate settings. */
//#define USBD_DFU_ALTSETTINGS        0

/** @brief Set to 1 if DFU STMicroelectronics Extension
 *  protocol (v1.1A) shall be used instead of the standard DFU (v1.1). */
//#define USBD_DFU_ST_EXTENSION       0



/** @brief Set to 1 if a HID interface holds more than one applications as alternate settings. */
#define USBD_HID_ALTSETTINGS        0

/** @brief Set to 1 if a HID interface uses an OUT endpoint. */
#define USBD_HID_OUT_SUPPORT        0

/** @brief Set to 1 if a HID interface defines strings in its report descriptor. */
#define USBD_HID_REPORT_STRINGS     0

/** @} */

#endif /* __USBD_CONFIG_H_ */

[bentwire]

Here is all the HID code:

#include <usbd_hid.h>
#include <hid/usage_consumer.h>
#include <hid/usage_desktop.h>
#include <hid/usage_button.h>
#include <accell_tasks.h>
#include <hid.h>

/**
 * HID Report for joystick
 *
 */
__alignment(USBD_DATA_ALIGNMENT)
static const uint8_t JoystickReport[] __align(USBD_DATA_ALIGNMENT) = {
        HID_USAGE_PAGE_DESKTOP,
        HID_USAGE_DT_JOYSTICK,
        HID_COLLECTION_APPLICATION(
                HID_USAGE_PAGE_BUTTON,
                HID_USAGE_MIN_8(1),
                HID_USAGE_MAX_8(8),
                HID_LOGICAL_MIN_8(0),
                HID_LOGICAL_MAX_8(1),
                HID_PHYSICAL_MIN_8(0),
                HID_PHYSICAL_MAX_8(1),
                HID_REPORT_SIZE(1),
                HID_REPORT_COUNT(8),
                HID_INPUT(HID_ITEM_FLAG_VAR),
                HID_USAGE_PAGE_DESKTOP,
                HID_USAGE_DT_X,
                HID_LOGICAL_MIN_16(-2500),
                HID_LOGICAL_MAX_16(5500),
                HID_PHYSICAL_MIN_16(-2500),
                HID_PHYSICAL_MAX_16(5500),
                HID_REPORT_SIZE(16),
                HID_REPORT_COUNT(1),
                HID_INPUT(HID_ITEM_FLAG_VAR),
                HID_USAGE_DT_Y,
                HID_REPORT_SIZE(16),
                HID_REPORT_COUNT(1),
                HID_INPUT(HID_ITEM_FLAG_VAR),
        ),
};

void
sendReport(hid_joydata_t * joyData) {
    USBD_HID_ReportIn(joy_if, joyData, sizeof(hid_joydata_t));
}

static void
getReport(void * itf, USBD_HID_ReportType type, uint8_t id) {
    uint8_t buf[8] = { 0 };
    hid_joydata_t data = { 0 };
    if (type == HID_REPORT_INPUT) {
        sendReport(&data);
    } else {
        USBD_HID_ReportIn(itf, buf, sizeof(buf));
    }
}

static void
setReport(void * itf, USBD_HID_ReportType type, uint8_t * data, uint16_t len) {

}

static void joyInit(void *itf) {

}

static void joyDeinit(void *itf) {

}

static const USBD_HID_ReportConfigType joystickReportConfig = {
        .Desc = JoystickReport,
        .DescLength = sizeof(JoystickReport),
        .Input.MaxSize = sizeof(hid_joydata_t),
        .Input.Interval_ms = 20,
};

static const USBD_HID_AppType joyApp = {
        .Name = "Joystick",
        .Init = joyInit,
        .Deinit = joyDeinit,
        .SetReport = setReport,
        .GetReport = getReport,
        .Report = &joystickReportConfig,
};

USBD_HID_IfHandleType hjoy_if = {
        .App = &joyApp,
        .Base.AltCount = 1,
}, *const joy_if = &hjoy_if;

Nothing obvious sticks out to me.

[bentwire]

BTW after I get this working I will send a PR for the Joystick additions I did to the HidReportDef project.

[benedekkupper]

I could only tell more with USB trace information available, otherwise I have no ideas.

[bentwire]

composite-hand.zip

Hopefully the capture will help. It looks like the device replies with an invalid PID sequence during a setup transaction. You will see the rows marked "I" in the error column in the .csv.

[benedekkupper]

The only failure I see here is that the host fails to set the CDC line coding, and afterwards also fails to read the interface descriptor of the console_if (which it succeeded to read before). These are all functioning operations on my side, so I don't know what's exactly wrong with your setup.