Skip to content

Commit 4ad3612

Browse files
authored
fix: make RelWithDebInfo default cmake build type (#3774)
* fix(build): fix cmake build type * fix(build): fix windows powershell wildcards in build pypi
1 parent 8f37f3e commit 4ad3612

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

.github/workflows/cuda11.8-whl-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ jobs:
8080
- name: Build wheel
8181
run: |
8282
python -m build --wheel -o build/wheel
83-
change_wheel_version build/*.whl --local-version cu118 --delete-old-wheel
83+
Get-ChildItem -Path "build" -Filter "*.whl" | ForEach-Object { change_wheel_version $_.FullName --local-version cu118 --delete-old-wheel }
8484
- name: Upload Artifacts
8585
uses: actions/upload-artifact@v4
8686
with:

.github/workflows/pypi.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ jobs:
7979
- name: Build wheel
8080
run: |
8181
python -m build --wheel -o build/wheel
82-
change_wheel_version build/*.whl --local-version cu121 --delete-old-wheel
82+
Get-ChildItem -Path "build" -Filter "*.whl" | ForEach-Object { change_wheel_version $_.FullName --local-version cu121 --delete-old-wheel }
8383
- name: Upload Artifacts
8484
uses: actions/upload-artifact@v4
8585
with:

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,13 +132,13 @@ def gen_packages_items():
132132
cmake_depends_on=['pybind11'],
133133
source_dir=str(Path(__file__).parent.absolute()),
134134
cmake_generator=None if os.name == 'nt' else 'Ninja',
135+
cmake_build_type=os.getenv('CMAKE_BUILD_TYPE', 'RelWithDebInfo'),
135136
cmake_configure_options=[
136137
f'-DPython3_ROOT_DIR={Path(sys.prefix)}',
137138
f'-DPYTHON_EXECUTABLE={Path(sys.executable)}',
138139
'-DCALL_FROM_SETUP_PY:BOOL=ON',
139140
'-DBUILD_SHARED_LIBS:BOOL=OFF',
140141
# Select the bindings implementation
141-
'-DCMAKE_BUILD_TYPE=' + os.getenv('CMAKE_BUILD_TYPE', 'RelWithDebInfo'),
142142
'-DBUILD_PY_FFI=ON',
143143
'-DBUILD_MULTI_GPU=' + ('OFF' if os.name == 'nt' else 'ON'),
144144
'-DUSE_NVTX=' + ('OFF' if os.name == 'nt' else 'ON'),

0 commit comments

Comments
 (0)