-
Notifications
You must be signed in to change notification settings - Fork 33
Requesting an already requested Resource results in creating a duplicated process ID in ClearingHouse #638
Description
Bug Report
Describe the bug
In case a connection is established with a provider and Clearing House was enabled, a process creation message was already sent to the Clearing House. Thus, a valid connection, which was logged with the agreement ID of consumer/provider, exists.
DataspaceConnector/src/main/java/io/dataspaceconnector/common/ids/message/ClearingHouseService.java
Line 132 in cff7d16
| final var url = buildProcessCreationUrl(agreementId); |
In case the same resource is requested, it seems, that no new agreement is created, but the existing one is used. Nevertheless from the logs it seems, that it is tried to create a new process ID in Clearing House for the existing agreement ID, which ultimately results in a HTTP Status 400 from Clearing House with ids:RejectionMessage
To Reproduce
Steps to reproduce the behavior:
- Configure connector properly (DAPS, ClearingHouse, etc.)
- Request a resource and establish connection
- Request again the same resource and see logs
Expected behavior
No new process is created, but the existing one is used. Maybe first, a clearingHouse query shall be conducted e.g, with https://github.com/International-Data-Spaces-Association/IDS-Messaging-Services/blob/e6da46cbcbbf55bd0cfe1388396d76ae7c67fee2/clearinghouse/src/main/java/ids/messaging/clearinghouse/ClearingHouseService.java#L180
Screenshots & Logs
2023-01-18T08:33:28,044 [http-nio-8080-exec-15] INFO - Sending request message: [...] [code=(IMSMEI0068)]
2023-01-18T08:33:28,044 [http-nio-8080-exec-15] INFO - Sending request to https://clearing.test.mobility-dataspace.eu/messages/log/841cbff3-af52-4010-99c2-64a588899c7d ... [code=(IMSMEI0065)]
2023-01-18T08:33:30,113 [http-nio-8080-exec-15] INFO - Incoming response body: --97499e9b-a5f4-4ccd-9208-1bb2611ebbfa\r\nContent-Disposition: form-data; name="header"\r\nContent-Type: application/json; charset=UTF-8\r\nContent-Transfer-Encoding: 8bit\r\n\r\n{\n "@context" : {\n "ids" : "https://w3id.org/idsa/core/",\n "idsc" : "https://w3id.org/idsa/code/"\n },\n "@type" : "ids:RejectionMessage",\n "@id" : "https://w3id.org/idsa/autogen/rejectionMessage/39e784d9-2e48-479b-a038-4b442905458b",\n "ids:issuerConnector" : {\n "@id" : "https://clearing.test.mobility-dataspace.eu"\n },\n "ids:senderAgent" : {\n "@id" : "https://clearing.test.mobility-dataspace.eu"\n },\n "ids:securityToken" : {\n "@type" : "ids:DynamicAttributeToken",\n "@id" : "https://w3id.org/idsa/autogen/dynamicAttributeToken/417bd91e-9765-4558-b390-2ad5c022065a",\n "ids:tokenValue" : "eyJ0eXAiOiJhdCtqd3QiLCJraWQiOiJjNGI1ZWY4NDk4NTNiY2RlZjNjZjA1Njc5ODExNzU3NzUxODNhMGZlNmMyZDkwZjliYTkwNTM4YTlmOWEyODE0IiwiYWxnIjoiUlMyNTYifQ.eyJzY29wZSI6Imlkc2M6SURTX0NPTk5FQ1RPUl9BVFRSSUJVVEVTX0FMTCIsImF1ZCI6WyJpZHNjOklEU19DT05ORUNUT1JTX0FMTCJdLCJpc3MiOiJodHRwczovL2RhcHMudGVzdC5tb2JpbGl0eS1kYXRhc3BhY2UuZXUiLCJzdWIiOiIwNDpCODozQjpEQzpCODoxQTpFMTo5RjpBNzoxNDozODo2NzpBODoxMjpCRjo3RTpFOToxRDo2ODoyQTprZXlpZDo2RDoyQjozOTo1QTpBNzo3QTpCQTpGNDo5RDo5NTpEQTpBRjo4Qzo0Mjo5RjpDODo4QTo2ODoxODo4NyIsIm5iZiI6MTY3NDAzMDgwOSwiaWF0IjoxNjc0MDMwODA5LCJqdGkiOiJiOTQ4NGM1Yy0zMjExLTQyMzEtYTg5ZS02MjdlZDUzYTNlMjUiLCJleHAiOjE2NzQwMzQ0MDksImNsaWVudF9pZCI6IjA0OkI4OjNCOkRDOkI4OjFBOkUxOjlGOkE3OjE0OjM4OjY3OkE4OjEyOkJGOjdFOkU5OjFEOjY4OjJBOmtleWlkOjZEOjJCOjM5OjVBOkE3OjdBOkJBOkY0OjlEOjk1OkRBOkFGOjhDOjQyOjlGOkM4OjhBOjY4OjE4Ojg3Iiwic2VjdXJpdHlQcm9maWxlIjoiaWRzYzpCQVNFX1NFQ1VSSVRZX1BST0ZJTEUiLCJyZWZlcnJpbmdDb25uZWN0b3IiOiJodHRwczovL2NsZWFyaW5nLnRlc3QubW9iaWxpdHktZGF0YXNwYWNlLmV1IiwiQHR5cGUiOiJpZHM6RGF0UGF5bG9hZCIsIkBjb250ZXh0IjoiaHR0cHM6Ly93M2lkLm9yZy9pZHNhL2NvbnRleHRzL2NvbnRleHQuanNvbmxkIiwidHJhbnNwb3J0Q2VydHNTaGEyNTYiOiIzMGI4MzA0ZjJmM2Q4ZDdlZGU3NTljN2IxNzFmYTA2NmM2YWExMTVjMWM1M2Y3YjU2ZmQ1N2IxNTEwYzA5ZmQ4In0.iOWzxGICC5uSX9HrmfUOTXM7-a5UlTFI4frOMzHPXywmVtPNhzD4Q8vhFJFIIdJFIqbYiTVnyYpCHM0ECIZM2oKHxr_fAh_f8o755kSM5FSv305JhrYvPT_drqXmNWVH-zJwiSEZHoW1xH0kF9O1Of4UMMQp_1P-FGWiHAJAUmC1k5vDCd52YoJVyi0Ct2pSvum2SlrWxAZmjmkTFMX7vP6GTOaulDmkZUt6rCasfn0PdhAK6oCxoefEnTidNwWW0M5CYWGJOIt4vGPbZ-l1TtWE-cLopX0kk_yhqXweBteOw7Y2_nsGmS1ufs1e6dxvnpSxzkYFSBfmnOqxlLbdgTqEo6gbMiPiTs07rm4moFTdhw39U8wLuxBZbT79GoDOdQY27gAJTKFJQB1YMBsLLyeXwoi3GwfdMQ5Zsl14T028g5is5SpMZdQDw4IHWI-TCZLcVQ8yrAhS8pwI1iA9txcjf6peCSU67Yf6V00sXh40smlCnY6iyqln1aPqTbFR6TeSLoPqiQtBjWOj5Z24VlCZZ3iqNj11Qusz8PoPkw_pUqy5RKUMbpgCXhjf_-IFf9EcpGVEscwus99fti6LPUHPtyG0Ngo1hKJrWA5OkQWlHfx7gj3eRX6JMVK1B9vD4XzRC76D8xZ0hH3wNOExQkwJx__9MtfMDpJgQijwmLE",\n "ids:tokenFormat" : {\n "@id" : "https://w3id.org/idsa/code/JWT"\n }\n },\n "ids:issued" : {\n "@value" : "2023-01-18T08:33:30.056Z",\n "@type" : "http://www.w3.org/2001/XMLSchema#dateTimeStamp"\n },\n "ids:correlationMessage" : {\n "@id" : "https://w3id.org/idsa/autogen/logMessage/2cc122b6-7854-4a97-9e50-bf00cbc9d159"\n },\n "ids:recipientConnector" : [ {\n "@id" : "https://connector-sovity-mds-test.prod-sovity.azure.sovity.io"\n } ],\n "ids:recipientAgent" : [ {\n "@id" : "https://connector-sovity-mds-test.prod-sovity.azure.sovity.io"\n } ],\n "ids:modelVersion" : "4.1.0"\n}\r\n--97499e9b-a5f4-4ccd-9208-1bb2611ebbfa--\r\n [code=(IMSMEI0066)]
2023-01-18T08:33:30,113 [http-nio-8080-exec-15] WARN - Received response but response-code not in 200-299. [code=(IMSMEW0046), response-code=(400)]
2023-01-18T08:33:30,118 [http-nio-8080-exec-15] INFO - Successfully passed SHACL-Validation. [code=(IMSMEI0064)]
Stakeholders to keep updated
@kragall @ip312 @dhommen @tmberthold @omarsilva1