Merge pull request #15 from ChartIQ/typescript-linting

Typescript linting and moving variable for bloombergBridgeFolder to locaiton required in 5.0

Author: Kris West

.eslintignore

@@ -0,0 +1,6 @@
+# don't ever lint node_modules
+node_modules
+# don't lint build output (make sure it's set to your correct build folder name)
+dist
+# don't lint nyc coverage output
+coverage

.eslintrc.js

@@ -0,0 +1,26 @@
+module.exports = {
+  root: true,
+  parser: '@typescript-eslint/parser',
+  plugins: [
+    '@typescript-eslint',
+  ],
+  extends: [
+    // 'eslint:recommended',
+    // 'plugin:@typescript-eslint/recommended',
+    // 'airbnb-typescript'
+    'eslint:recommended',
+    'plugin:@typescript-eslint/recommended',
+    'plugin:@typescript-eslint/recommended-requiring-type-checking',
+  ],
+  parserOptions: {
+    tsconfigRootDir: __dirname,
+    project: './tsconfig.json',
+  },
+  rules: {
+    // indent: ["error", "tab"],
+    'no-tabs': 'off',
+    "indent": "off",
+    "linebreak-style": 0,
+    "@typescript-eslint/explicit-module-boundary-types": "off"
+  }
+};

finsemble.config.json

@@ -1,10 +1,9 @@
 {
   "seedProjectDirectory": "../finsemble-seed",
-  "bloombergBridgeFolder": "C:/Users/admin/Documents/code/finsemble-bloomberg/BloombergBridge",
   "importConfig": [
     "$applicationRoot/components/Bloomberg Terminal/config.json",
     "$applicationRoot/components/Bloomberg Bridge/config.json",
-	"$applicationRoot/components/testBloomberg/config.json",
-	"$applicationRoot/components/SecurityFinder/config.json"
+	  "$applicationRoot/components/testBloomberg/config.json",
+	  "$applicationRoot/components/SecurityFinder/config.json"
   ]
 }

finsemble.manifest.json

@@ -6,5 +6,10 @@
 			"alias": "bloomberg_bridge",
 			"target": "BloombergBridge.exe"
 		}
-	]
+	],
+	"finsemble": {
+		"custom": {
+            "bloombergBridgeFolder": "C:/Users/admin/Documents/code/finsemble-bloomberg/BloombergBridge"
+        }
+	}
 }

fpe-scripts/watch.js

@@ -112,6 +112,10 @@ async function updateManifestLocal(seedDirectory, currentFile) {
 
 		seedManifest.appAssets = newAppAssets;
 
+		//add the variable for the bloomberg bridge path (for development)
+		if (!seedManifest.finsemble.custom) { seedManifest.finsemble.custom = {};}
+		seedManifest.finsemble.custom.bloombergBridgeFolder = projectManifest.finsemble.custom.bloombergBridgeFolder;
+
 		const output = await writeJson(seedManifestPath, seedManifest, { spaces: 4 });
 		if (output) console.log('success writing manifest');
 	} catch (error) {

package.json

@@ -4,7 +4,9 @@
   "description": "Finsemble's Bloomberg Terminal Connect Integration",
   "scripts": {
     "watch": "node ./fpe-scripts/watch.js",
-    "docs": "npx typedoc"
+    "docs": "npx typedoc",
+    "lint": "eslint . --ext .js,.jsx,.ts,.tsx",
+    "lintTS": "tsc --noemit && eslint . --ext .ts,.tsx"
   },
   "keywords": [
     "Finsemble",
@@ -17,16 +19,24 @@
     "node": ">=10"
   },
   "devDependencies": {
+    "@finsemble/finsemble-core": "^5.0.1",
+    "@typescript-eslint/eslint-plugin": "^4.5.0",
+    "@typescript-eslint/parser": "^4.5.0",
     "chokidar": "^3.4.0",
+    "eslint": "^7.11.0",
+    "eslint-config-airbnb-typescript": "^12.0.0",
+    "eslint-plugin-import": "^2.22.1",
+    "eslint-plugin-jsx-a11y": "^6.3.1",
+    "eslint-plugin-react": "^7.21.5",
+    "eslint-plugin-react-hooks": "^4.2.0",
     "fs-extra": "^9.0.0",
     "typedoc": "^0.17.7",
-    "typedoc-plugin-markdown": "^2.3.1"
+    "typedoc-plugin-markdown": "^2.3.1",
+    "typescript": "^4.0.3"
   },
   "dependencies": {
-    "@chartiq/finsemble": "^4.3.0",
     "@types/node": "^14.0.13",
     "react-autosuggest": "^10.0.2",
-    "react-tabs": "^3.1.1",
-    "typescript": "^3.9.5"
+    "react-tabs": "^3.1.1"
   }
 }