Address remarks

Author: carbolymer

cardano-api/src/Cardano/Api/Genesis/Internal.hs

@@ -271,7 +271,8 @@ conwayGenesisDefaults =
 
     costModelParamsForTesting :: HasCallStack => [(V3.ParamName, Int64)]
     costModelParamsForTesting =
-      -- all geneses should contain only the number of cost model params equal to the initial number
+      -- all geneses should have exactly the number of cost model params equal to the initial number
+      -- initial number - a number of parameters for the language, when the plutus language was introduced
       take (L.costModelInitParamCount PlutusV3)
         . Map.toList
         . fromJust

cardano-api/test/cardano-api-test/Test/Cardano/Api/CBOR.hs

@@ -91,8 +91,8 @@ prop_text_envelope_roundtrip_txbody_CBOR = H.property $ do
         deserialiseFromTextEnvelope
     )
 
-_prop_text_envelope_roundtrip_tx_CBOR :: Property
-_prop_text_envelope_roundtrip_tx_CBOR = H.property $ do
+prop_text_envelope_roundtrip_tx_CBOR :: Property
+prop_text_envelope_roundtrip_tx_CBOR = H.property $ do
   AnyShelleyBasedEra era <- H.noteShowM . H.forAll $ Gen.element [minBound .. maxBound]
   x <- H.forAll $ genTx era
   shelleyBasedEraConstraints
@@ -427,8 +427,8 @@ tests =
     [ testProperty "test canonicalisation of CBOR" prop_canonicalise_cbor
     , testProperty "rountrip txbody text envelope" prop_text_envelope_roundtrip_txbody_CBOR
     , testProperty "txbody backwards compatibility" prop_txbody_backwards_compatibility
-    , -- , testProperty "rountrip tx text envelope" prop_text_envelope_roundtrip_tx_CBOR
-      testProperty "roundtrip witness CBOR" prop_roundtrip_witness_CBOR
+    , testProperty "rountrip tx text envelope" prop_text_envelope_roundtrip_tx_CBOR
+    , testProperty "roundtrip witness CBOR" prop_roundtrip_witness_CBOR
     , testProperty "roundtrip legacy key witness CBOR" prop_roundtrip_legacy_key_witness_CBOR
     , testProperty
         "roundtrip operational certificate CBOR"

cardano-api/test/cardano-api-test/Test/Cardano/Api/Transaction/Autobalance.hs

@@ -334,7 +334,7 @@ prop_make_transaction_body_autobalance_return_correct_fee_for_multi_asset = H.pr
   feeWithTxoutAsset === fee
 
 prop_make_transaction_body_autobalance_when_deregistering_certs :: Property
-prop_make_transaction_body_autobalance_when_deregistering_certs = H.propertyOnce $ do
+prop_make_transaction_body_autobalance_when_deregistering_certs = H.property $ do
   let ceo = ConwayEraOnwardsConway
       beo = convert ceo
       sbe = convert beo
@@ -354,15 +354,22 @@ prop_make_transaction_body_autobalance_when_deregistering_certs = H.propertyOnce
       address = mkAddress sbe scriptHash
       deregDeposit = L.Coin 20_000_000
       txOutCoin = L.Coin 20_800_000
-
-  -- that's the same stake credential as in UTXO
-  lStakeCred@(L.KeyHashObj kh) <-
-    pure $ mkCredential "keyHash-ebe9de78a37f84cc819c0669791aa0474d4f0a764e54b9f90cfe2137"
-  let stakeCred = StakeCredentialByKey $ StakeKeyHash kh
+      mkStakeKeyFromHash hashStr = do
+        (L.KeyHashObj kh) <-
+          pure $ mkCredential hashStr
+        pure . StakeCredentialByKey $ StakeKeyHash kh
+
+  (expectedFee, stakeCred) <-
+    forAll $
+      Gen.choice
+        -- expected fee is larger, when the certificate credential does not match the credential required when witnessing UTXO
+        [ (180_901,) <$> genStakeCredential
+        , (176_457,) <$> mkStakeKeyFromHash "keyHash-ebe9de78a37f84cc819c0669791aa0474d4f0a764e54b9f90cfe2137"
+        ]
   let certs =
         [
           ( ConwayCertificate ceo $
-              L.ConwayTxCertDeleg (L.ConwayUnRegCert lStakeCred (L.SJust deregDeposit))
+              L.ConwayTxCertDeleg (L.ConwayUnRegCert (toShelleyStakeCredential stakeCred) (L.SJust deregDeposit))
           , Nothing
           )
         ]
@@ -395,7 +402,7 @@ prop_make_transaction_body_autobalance_when_deregistering_certs = H.propertyOnce
   H.note_ "Sanity check: inputs == outputs"
   mconcat [deregDeposit, txInputsTotalCoin] === mconcat [txOutCoin, fee, changeCoin]
 
-  176_457 === fee
+  expectedFee === fee
 
 prop_make_transaction_body_autobalance_multi_asset_collateral :: Property
 prop_make_transaction_body_autobalance_multi_asset_collateral = H.propertyOnce $ do