[FEATURE] - Update `cardano-cli conway query spo-stake-distribution`

[CarlosLopezDeLara]

What

We need to update the output of cardano-cli conway query spo-stake-distribution to include the DREP delegation choices of the Pool's reward account. This, once IntersectMBO/cardano-ledger#4645 is implemented, in particular:

To be more specific the solution to this problem is:

1.  To change the default vote for SPOs to `No` from `Abstain` for all of the three proposals in question
2. Check whether SPO's reward address is delegated to the predefined `AlwaysNoConfidence` DRep and count default vote as `Yes` only on `NoConfidence` proposals for that SPO.
3. Check whether SPO's reward address is delegated to predefined `AlwaysAbstain` DRep and count default vote as `Abstain` for that SPO on all three: `NoConfidence`, `UpdateCommitee` and `ParameterUpdate` proposals.

For example:

    [
        "dec39dd553180bf78b206258aba3861537b185580086ca3f62716f8d",
        10868846712397,
        "drep-alwaysAbstain"
    ],
    [
        "e2fd1cd89bba55dc457574adf420240c28a2bfdb3d460279e453c57a",
        10671709098807,
        "drep-keyHash-ffc25bcec3379aea4e32f353b4048fc7ab9fc1124c01738546e2f7bb"
    ],
    [
        "eec73ca2652e1ae92852195ff3289dd991a83dbe5f989f06e1c96b64",
        10703582488560,
        "drep-alwaysNoConfidence"
    ],
    [
        "f386ee192cf53c26da7457b7d8992ae0e52a05fc1c88c5d653a90021",
        10466189795103,
        "drep-scriptHash-186e32faa80a26810392fda6d559c7ed4721a65ce1c9d4ef3e1c87b4"
    ]

(Thank you @gitmachtl)

Why

IntersectMBO/cardano-ledger#4645 changes the way SPO votes are counted. The SPO reward account delegation choice will impact how the pool's stake counts for voting. It is important to show this information so that downstream tools can recreate the vote count.

Personas

• SPOs
• dApp Devs
• Exchanges
• Wallets
• 3rd party tools
• ADA holders

Definition of Done (DoD)

• Acceptance Criteria + User Stories & DoD created and singed-off (by PO, dev & test owners)
• Builds successfully on CI
• Code & Test review (as per Acceptance Criteria)
• There is documentation and/or examples for the new functionality (usage/response)
• Log/record changes on Vnext (or similar depending on what we adopt)
• Ticket number(s) included in PR description
• All Acceptance Criteria met and covered by dev/unit/property/integration tests
• System/E2E automated tests + System Test Engineer Owner Sign-off

NOTE: Ideally, we should merge only fully implemented and tested features into the master branch.
So all the above steps are required for the PR to be merged.
In order to avoid the PRs becoming stale and requiring to be rebased on master, these can be merged
after a reasonable time (current agreement is 3 days) if the System Test Engineer Owner's sign-off
was not provided (last step in the DoD).

IMPORTANT: Any deviation from the plan should be discussed and agreed as a comment in the Feature file.

Sign-off

• Product Owner
• Dev Owner
• System Test Engineer Owner

Related PRs

Acceptance Criteria

The output must show the SPO rewards account delegation choice: "registered DRep", "Always abstain" or "Always no confidence"

[gitmachtl]

here is the cross reference to the ledger part
IntersectMBO/cardano-ledger#4663

[gitmachtl]

i will extended this FR to also change the spo-stake-distribution name into spo-power-distribution or spo-votepower-distribution.

[gitmachtl]

@smelc did you have time yet to look into this? how realistic is it to have a new cli release with this update before the hf?

[smelc]

@gitmachtl> sorry no progress nearly yet because I've been helping with query proposals the last week (#984 and IntersectMBO/cardano-node#6045). When is the hf planned?

[gitmachtl]

@smelc i think sometimes in january

[smelc]

@smelc i think sometimes in january

Then this might be doable. I'll focus on this one during the next days 👍 FYI @Jimbo4350

[smelc]

Work being done here: https://github.com/IntersectMBO/cardano-cli/commits/smelc/augment-spo-stake-distribution/

[gitmachtl]

Work being done here: https://github.com/IntersectMBO/cardano-cli/commits/smelc/augment-spo-stake-distribution/

Have not checked your code yet, is the goal to mimic the output we set up as an example output here? #911 (comment)

I guess if there is no delegation of the rewards account yet, the output will simply be null for the default-delegation of that pool?

[smelc]

Have not checked your code yet, is the goal to mimic the output we set up as an example output here? #911 (comment)

I can but I think it's not a really nice output. So far I went for this, but really it's up to you tell me what you want (taking the community's opinion into account):

[{"stake":45017728438785,
  "stakePool":"6d598b98e752c8e3efa20134bb498b7a63daf2def7ea559654584ea3",
  "voteDelegation":null}]

Tackling this issue can be a good moment to change the output's format.

Have not checked your code yet, is the goal to mimic the output we set up as an example output here? #911 (comment)

Yes

@gitmachtl> would you be able to test this branch? It's right now based on cardano-cli-10.1.0.0, so that I can more easily test it locally with cardano-testnet-test, but I can rebase on another version if that would help you.

[gitmachtl]

@smelc the thing is that this than would be a breaking change for tooling, adding just a 3rd entry will most likely not break any tooling.

yeah... let me test your branch

[smelc]

@smelc the thing is that this than would be a breaking change for tooling, adding just a 3rd entry will most likely not break any tooling.

@gitmachtl> Sounds good 👍 I added commit Revert to triplet JSON to just add the third entry 👍