db-sync: Fix (again) foreign key exception on pool offline data

This was supposed to be fixed in d658f38 but probably due to a git
merge error, the new functions that were supposed to fix this issue were
added but not used.

The fix is to use the checked versions of the functions and completely
remove the unchecked functions so they cannot be called by accident.

Closes: #858

Author: erikd

cardano-db-sync/src/Cardano/DbSync/Era/Shelley/Offline.hs

@@ -83,8 +83,8 @@ insertOfflineResults trce resultQueue = do
     insert :: (MonadBaseControl IO m, MonadIO m) => FetchResult -> ReaderT SqlBackend m ()
     insert fr =
       case fr of
-        ResultMetadata md -> void $ DB.insertPoolOfflineData md
-        ResultError fe -> void $ DB.insertPoolOfflineFetchError fe
+        ResultMetadata md -> void $ DB.insertCheckPoolOfflineData md
+        ResultError fe -> void $ DB.insertCheckPoolOfflineFetchError fe
 
     isFetchError :: FetchResult -> Bool
     isFetchError fe =

cardano-db/src/Cardano/Db/Insert.hs

@@ -24,8 +24,6 @@ module Cardano.Db.Insert
   , insertPotTransfer
   , insertPoolHash
   , insertPoolMetadataRef
-  , insertPoolOfflineData
-  , insertPoolOfflineFetchError
   , insertPoolOwner
   , insertPoolRelay
   , insertPoolRetire
@@ -154,12 +152,6 @@ insertPoolHash = insertCheckUnique "PoolHash"
 insertPoolMetadataRef :: (MonadBaseControl IO m, MonadIO m) => PoolMetadataRef -> ReaderT SqlBackend m PoolMetadataRefId
 insertPoolMetadataRef = insertCheckUnique "PoolMetadataRef"
 
-insertPoolOfflineData :: (MonadBaseControl IO m, MonadIO m) => PoolOfflineData -> ReaderT SqlBackend m PoolOfflineDataId
-insertPoolOfflineData = insertCheckUnique "PoolOfflineData"
-
-insertPoolOfflineFetchError :: (MonadBaseControl IO m, MonadIO m) => PoolOfflineFetchError -> ReaderT SqlBackend m PoolOfflineFetchErrorId
-insertPoolOfflineFetchError = insertCheckUnique "PoolOfflineFetchError"
-
 insertPoolOwner :: (MonadBaseControl IO m, MonadIO m) => PoolOwner -> ReaderT SqlBackend m PoolOwnerId
 insertPoolOwner = insertCheckUnique "PoolOwner"
 
@@ -218,13 +210,13 @@ insertCheckPoolOfflineData :: (MonadBaseControl IO m, MonadIO m) => PoolOfflineD
 insertCheckPoolOfflineData pod = do
   foundPool <- existsPoolHashId (poolOfflineDataPoolId pod)
   foundMeta <- existsPoolMetadataRefId (poolOfflineDataPmrId pod)
-  when (foundPool && foundMeta) $ void $ insertPoolOfflineData pod
+  when (foundPool && foundMeta) . void $ insertCheckUnique "PoolOfflineData" pod
 
 insertCheckPoolOfflineFetchError :: (MonadBaseControl IO m, MonadIO m) => PoolOfflineFetchError -> ReaderT SqlBackend m ()
 insertCheckPoolOfflineFetchError pofe = do
   foundPool <- existsPoolHashId (poolOfflineFetchErrorPoolId pofe)
   foundMeta <- existsPoolMetadataRefId (poolOfflineFetchErrorPmrId pofe)
-  when (foundPool && foundMeta) $ void $ insertPoolOfflineFetchError pofe
+  when (foundPool && foundMeta) . void $ insertCheckUnique "PoolOfflineFetchError" pofe
 
 -- -----------------------------------------------------------------------------