Add warning for missing validation

Author: kderme

cardano-chain-gen/test/Test/Cardano/Db/Mock/Unit/Babbage/CommandLineArg/ForceIndex.hs

@@ -19,7 +19,7 @@ checkForceIndexesArg =
   withCustomConfig commandLineForceIndexArgs Nothing babbageConfigDir testLabel $ \_ _ dbSyncEnv -> do
     startDBSync dbSyncEnv
     threadDelay 3_000_000
-    assertEqQuery dbSyncEnv DB.queryPgIndexesCount 166 "there wasn't the correct number of indexes"
+    assertEqQuery dbSyncEnv DB.queryPgIndexesCount 169 "there wasn't the correct number of indexes"
   where
     testLabel = "CLAcheckForceIndexesArg"
     commandLineForceIndexArgs =
@@ -32,7 +32,7 @@ checkNoForceIndexesArg =
   withCustomConfigAndDropDB commandLineNoForceIndexArgs Nothing babbageConfigDir testLabel $ \_ _ dbSyncEnv -> do
     startDBSync dbSyncEnv
     threadDelay 3_000_000
-    assertEqQuery dbSyncEnv DB.queryPgIndexesCount 101 "there wasn't the correct number of indexes"
+    assertEqQuery dbSyncEnv DB.queryPgIndexesCount 104 "there wasn't the correct number of indexes"
   where
     testLabel = "CLAcheckNoForceIndexesArg"
     commandLineNoForceIndexArgs =

cardano-chain-gen/test/Test/Cardano/Db/Mock/Unit/Conway/CommandLineArg/ForceIndex.hs

@@ -17,7 +17,7 @@ checkForceIndexesArg =
     startDBSync dbSync
 
     -- Verify number of DB indexes
-    assertEqQuery dbSync DB.queryPgIndexesCount 166 "unexpected number of indexes"
+    assertEqQuery dbSync DB.queryPgIndexesCount 169 "unexpected number of indexes"
   where
     cliArgs = initCommandLineArgs {claForceIndexes = True}
     testLabel = "conwayCLACheckForceIndexesArg"
@@ -28,7 +28,7 @@ checkNoForceIndexesArg =
     startDBSync dbSync
 
     -- Verify number of DB indexes
-    assertEqQuery dbSync DB.queryPgIndexesCount 101 "unexpected number of indexes"
+    assertEqQuery dbSync DB.queryPgIndexesCount 104 "unexpected number of indexes"
   where
     cliArgs = initCommandLineArgs {claForceIndexes = False}
     testLabel = "conwayCLACheckNoForceIndexesArg"

cardano-db-sync/src/Cardano/DbSync/OffChain/Http.hs

@@ -102,10 +102,10 @@ httpGetOffChainVoteData manager request vurl metaHash isGovAction = do
 
 parseAndValidateVoteData :: ByteString -> LBS.ByteString -> Maybe VoteMetaHash -> Bool -> Maybe OffChainUrlType -> ExceptT OffChainFetchError IO (Vote.OffChainVoteData, Aeson.Value, ByteString, Maybe Text)
 parseAndValidateVoteData bs lbs metaHash isGa murl = do
-  mWarning <- case unVoteMetaHash <$> metaHash of
-    Nothing -> pure Nothing
-    Just _expectedMetaHash -> pure Nothing
   let metadataHash = Crypto.digest (Proxy :: Proxy Crypto.Blake2b_256) bs
+  (hsh, mWarning) <- case unVoteMetaHash <$> metaHash of
+    Nothing -> pure (metadataHash, Nothing)
+    Just expectedMetaHash -> pure (expectedMetaHash, Just "Failed to validate metadata hash") -- TODO: Conway
   decodedValue <-
     case Aeson.eitherDecode' @Aeson.Value lbs of
       Left err -> left $ OCFErrJsonDecodeFail murl (Text.pack err)
@@ -114,7 +114,7 @@ parseAndValidateVoteData bs lbs metaHash isGa murl = do
     case Vote.eitherDecodeOffChainVoteData lbs isGa of
       Left err -> left $ OCFErrJsonDecodeFail murl (Text.pack err)
       Right res -> pure res
-  pure (ocvd, decodedValue, metadataHash, mWarning)
+  pure (ocvd, decodedValue, hsh, mWarning)
 
 httpGetBytes ::
   Http.Manager ->