remove remaining panic from db-sync/db-sync

Author: Cmdv

cardano-db-sync/src/Cardano/DbSync/Config/Cardano.hs

@@ -17,7 +17,6 @@ import qualified Cardano.Chain.Genesis as Byron
 import Cardano.Chain.Update (ApplicationName (..), SoftwareVersion (..))
 import qualified Cardano.Crypto.Hash.Class as Crypto
 import Cardano.Crypto.ProtocolMagic (ProtocolMagicId (..))
-import Cardano.Db (textShow)
 import Cardano.DbSync.Config.Alonzo
 import Cardano.DbSync.Config.Byron
 import Cardano.DbSync.Config.Shelley
@@ -29,7 +28,6 @@ import Cardano.Ledger.Binary.Version
 import Cardano.Ledger.Conway.Genesis
 import Cardano.Ledger.Keys
 import Cardano.Ledger.Shelley.Translation (emptyFromByronTranslationContext)
-import Cardano.Prelude (panic)
 import Control.Monad.Trans.Except (ExceptT)
 import Data.Word (Word64)
 import Ouroboros.Consensus.Block.Forging
@@ -140,7 +138,7 @@ shelleyPraosNonce sCfg = Nonce (Crypto.castHash . unGenesisHashShelley $ scGenes
 mkProtVer :: Word64 -> Word64 -> ProtVer
 mkProtVer a b =
   case mkVersion64 a of
-    Nothing -> panic $ "Impossible: Invalid version generated: " <> textShow a
+    Nothing -> error $ "Impossible: Invalid version generated: " <> show a
     Just v -> ProtVer v (fromIntegral b)
 
 mkByronSoftwareVersion :: SoftwareVersion

cardano-db-sync/src/Cardano/DbSync/Default.hs

@@ -42,6 +42,7 @@ import qualified Data.Set as Set
 import qualified Data.Strict.Maybe as Strict
 import Database.Persist.SqlBackend.Internal
 import Database.Persist.SqlBackend.Internal.StatementCache
+import GHC.Err (error)
 import Ouroboros.Consensus.Cardano.Block (HardForkBlock (..))
 import qualified Ouroboros.Consensus.HardFork.Combinator as Consensus
 import Ouroboros.Network.Block (blockHash, blockNo, getHeaderFields, headerFieldBlockNo, unBlockNo)

cardano-db-sync/src/Cardano/DbSync/Epoch.hs

@@ -28,6 +28,7 @@ import Control.Monad.Trans.Control (MonadBaseControl)
 import Database.Esqueleto.Experimental (SqlBackend, replace)
 import Ouroboros.Consensus.Byron.Ledger (ByronBlock (..))
 import Ouroboros.Consensus.Cardano.Block (HardForkBlock (..))
+import GHC.Err (error)
 
 -- Populating the Epoch table has two mode:
 --  * SyncLagging: when the node is far behind the chain tip and is just updating the DB. In this

cardano-db-sync/src/Cardano/DbSync/Era/Shelley/Validate.hs

@@ -44,6 +44,7 @@ import Database.Esqueleto.Experimental (
   (==.),
   (^.),
  )
+import GHC.Err (error)
 
 {- HLINT ignore "Fuse on/on" -}
 {- HLINT ignore "Reduce duplication" -}
@@ -126,7 +127,7 @@ queryRewardMap (EpochNo epochNo) = do
     collapse :: [(ByteString, (RewardSource, DbLovelace))] -> (ByteString, [(RewardSource, DbLovelace)])
     collapse xs =
       case xs of
-        [] -> panic "queryRewardMap.collapse: Unexpected empty list" -- Impossible
+        [] -> error "queryRewardMap.collapse: Unexpected empty list" -- Impossible
         x : _ -> (fst x, List.sort $ map snd xs)
 
 diffRewardMap ::

cardano-db-sync/src/Cardano/DbSync/Error.hs

@@ -52,6 +52,7 @@ data SyncNodeError
   | SNErrInsertGenesis !String
   | SNErrLedgerState !String
   | SNErrNodeConfig NodeConfigError
+  | SNErrLocalStateQuery !String
 
 instance Exception SyncNodeError
 
@@ -110,11 +111,12 @@ instance Show SyncNodeError where
       SNErrInsertGenesis err -> "Error SNErrInsertGenesis: " <> err
       SNErrLedgerState err -> "Error SNErrLedgerState: " <> err
       SNErrNodeConfig err -> "Error SNErrNodeConfig: " <> show err
+      SNErrLocalStateQuery err -> "Error SNErrLocalStateQuery: " <> show err
 
 data NodeConfigError
-  = NodeConfigParseError String
-  | ParseSyncPreConfigError String
-  | ReadByteStringFromFileError String
+  = NodeConfigParseError !String
+  | ParseSyncPreConfigError !String
+  | ReadByteStringFromFileError !String
 
 instance Exception NodeConfigError
 

cardano-db-sync/src/Cardano/DbSync/Ledger/State.hs

@@ -119,6 +119,7 @@ import System.Directory (doesFileExist, listDirectory, removeFile)
 import System.FilePath (dropExtension, takeExtension, (</>))
 import System.Mem (performMajorGC)
 import Prelude (String, id)
+import GHC.Err (error)
 
 -- Note: The decision on whether a ledger-state is written to disk is based on the block number
 -- rather than the slot number because while the block number is fully populated (for every block

cardano-db-sync/src/Cardano/DbSync/LocalStateQuery.hs

@@ -11,7 +11,6 @@ module Cardano.DbSync.LocalStateQuery (
 ) where
 
 import Cardano.BM.Trace (Trace, logInfo)
-import Cardano.Db (textShow)
 import Cardano.DbSync.StateQuery
 import Cardano.DbSync.Types
 import qualified Cardano.Ledger.BaseTypes as Ledger
@@ -54,6 +53,7 @@ import Ouroboros.Network.Protocol.LocalStateQuery.Client (
  )
 import qualified Ouroboros.Network.Protocol.LocalStateQuery.Client as StateQuery
 import Ouroboros.Network.Protocol.LocalStateQuery.Type (AcquireFailure)
+import Cardano.DbSync.Error (SyncNodeError(..))
 
 data NoLedgerEnv = NoLedgerEnv
   { nleTracer :: Trace IO Text
@@ -96,7 +96,7 @@ getSlotDetailsNode nlEnv slot = do
     Left _ -> do
       einterp2 <- getHistoryInterpreter nlEnv
       case evalSlotDetails einterp2 of
-        Left err -> panic $ "getSlotDetailsNode: " <> textShow err
+        Left err -> throwIO $ SNErrLocalStateQuery $ "getSlotDetailsNode: " <> Prelude.show err
         Right sd -> insertCurrentTime sd
   where
     interVar = nleHistoryInterpreterVar nlEnv
@@ -123,7 +123,7 @@ getHistoryInterpreter nlEnv = do
   res <- atomically $ takeTMVar respVar
   case res of
     Left err ->
-      panic $ "getHistoryInterpreter: " <> textShow err
+      throwIO $ SNErrLocalStateQuery $ "getHistoryInterpreter: " <> Prelude.show err
     Right interp -> do
       logInfo tracer "getHistoryInterpreter: acquired"
       atomically $ writeTVar interVar $ Strict.Just interp