Remove Unique key from reward_rest

Fixes https://github.com/orgs/IntersectMBO/projects/8/views/5?pane=issue&itemId=62872398

Author: kderme

cardano-db-sync/src/Cardano/DbSync/Rollback.hs

@@ -53,6 +53,7 @@ rollbackFromBlockNo syncEnv blkNo = do
         DB.setNullTxOut trce mTxId
       DB.deleteEpochRows epochNo
       DB.deleteDrepDistr epochNo
+      DB.deleteRewardRest epochNo
       DB.setNullEnacted epochNo
       DB.setNullRatified epochNo
       DB.setNullDropped epochNo

cardano-db/src/Cardano/Db/Delete.hs

@@ -15,6 +15,7 @@ module Cardano.Db.Delete (
   deleteBlock,
   deleteEpochRows,
   deleteDrepDistr,
+  deleteRewardRest,
   deleteAdaPots,
   deleteTxOut,
   -- for testing
@@ -226,6 +227,10 @@ deleteDrepDistr :: MonadIO m => Word64 -> ReaderT SqlBackend m ()
 deleteDrepDistr epochNum =
   deleteWhere [DrepDistrEpochNo >. epochNum]
 
+deleteRewardRest :: MonadIO m => Word64 -> ReaderT SqlBackend m ()
+deleteRewardRest epochNum =
+  deleteWhere [RewardRestSpendableEpoch >. epochNum]
+
 deleteAdaPots :: MonadIO m => BlockId -> ReaderT SqlBackend m ()
 deleteAdaPots blkId = do
   deleteWhere [AdaPotsBlockId ==. blkId]

cardano-db/src/Cardano/Db/Insert.hs

@@ -214,7 +214,7 @@ insertManyRewardRests ::
   (MonadBaseControl IO m, MonadIO m) =>
   [RewardRest] ->
   ReaderT SqlBackend m ()
-insertManyRewardRests = insertManyCheckUnique "Many Rewards Rest"
+insertManyRewardRests = insertManyUnique "Many Rewards Rest" Nothing
 
 insertManyDrepDistr ::
   (MonadBaseControl IO m, MonadIO m) =>
@@ -517,11 +517,10 @@ insertManyUnique ::
   ) =>
   String ->
   -- | Does constraint already exists
-  Bool ->
-  ConstraintNameDB ->
+  Maybe ConstraintNameDB ->
   [record] ->
   ReaderT SqlBackend m ()
-insertManyUnique vtype constraintExists constraintName records = do
+insertManyUnique vtype mConstraintName records = do
   unless (null records) $
     handle exceptHandler (rawExecute query values)
   where
@@ -546,14 +545,14 @@ insertManyUnique vtype constraintExists constraintName records = do
 
     conflictQuery :: Text
     conflictQuery =
-      if constraintExists
-        then
+      case mConstraintName of
+        Just constraintName ->
           Text.concat
             [ " ON CONFLICT ON CONSTRAINT "
             , unConstraintNameDB constraintName
             , " DO NOTHING"
             ]
-        else ""
+        _ -> ""
 
     fieldNames, placeholders :: [Text]
     (fieldNames, placeholders) =
@@ -575,7 +574,10 @@ insertManyWithManualUnique ::
   ConstraintNameDB ->
   [record] ->
   ReaderT SqlBackend m ()
-insertManyWithManualUnique = insertManyUnique
+insertManyWithManualUnique str contraintExists constraintName =
+  insertManyUnique str mConstraintName
+  where
+    mConstraintName = if contraintExists then Just constraintName else Nothing
 
 insertManyCheckUnique ::
   forall m record.
@@ -588,7 +590,7 @@ insertManyCheckUnique ::
   ReaderT SqlBackend m ()
 insertManyCheckUnique vtype records = do
   let constraintName = uniqueDBName $ onlyOneUniqueDef (Proxy @record)
-  insertManyUnique vtype True constraintName records
+  insertManyUnique vtype (Just constraintName) records
 
 -- Insert, getting PostgreSQL to check the uniqueness constaint. If it is violated,
 -- simply returns the Key, without changing anything.

cardano-db/src/Cardano/Db/Schema.hs

@@ -321,7 +321,6 @@ share
     amount              DbLovelace          sqltype=lovelace
     earnedEpoch         Word64 generated="(CASE WHEN spendable_epoch >= 1 then spendable_epoch-1 else 0 end)"
     spendableEpoch      Word64
-    UniqueRewardRest addrId earnedEpoch type
     deriving Show
 
   Withdrawal

schema/migration-2-0040-20240517.sql

@@ -0,0 +1,19 @@
+-- Persistent generated migration.
+
+CREATE FUNCTION migrate() RETURNS void AS $$
+DECLARE
+  next_version int ;
+BEGIN
+  SELECT stage_two + 1 INTO next_version FROM schema_version ;
+  IF next_version = 40 THEN
+    EXECUTE 'ALTER TABLE "reward_rest" DROP CONSTRAINT "unique_reward_rest"' ;
+    -- Hand written SQL statements can be added here.
+    UPDATE schema_version SET stage_two = next_version ;
+    RAISE NOTICE 'DB has been migrated to stage_two version %', next_version ;
+  END IF ;
+END ;
+$$ LANGUAGE plpgsql ;
+
+SELECT migrate() ;
+
+DROP FUNCTION migrate() ;