refactor: Fix hlint violations

Author: sgillespie

.hlint.yaml

@@ -21,33 +21,31 @@
 # - flags:
 #   - {name: -w, within: []} # -w is allowed nowhere
 #
-# - modules:
-#   - {name: [Data.Set, Data.HashSet], as: Set} # if you import Data.Set qualified, it must be as 'Set'
-#   - {name: Control.Arrow, within: []} # Certain modules are banned entirely
-#
-# - functions:
-#   - {name: unsafePerformIO, within: []} # unsafePerformIO can only appear in no modules
-
 
 - modules:
   # If Data.List is imported qualified, it must be as 'List'
   - {name: [Data.List], as: List}
   - {name: [Data.Map.Strict], as: Map}
   - {name: [Data.Set], as: Set}
   - {name: [Data.Text], as: Text}
-  - {name: [Data.ByteString.Char8], as: BS}
-  - {name: [Data.ByteString.Lazy.Char8], as: LBS}
   - {name: [Data.ByteString.Short], as: SBS}
 
-# Banned functions
 - functions:
   - {name: coerce, within: []}
+  - {name: unsafePerformIO, within: []}
 
 # Add custom hints for this project
 #
 # Will suggest replacing "wibbleMany [myvar]" with "wibbleOne myvar"
 # - error: {lhs: "wibbleMany [x]", rhs: wibbleOne x}
 
+# The hints are named by the string they display in warning messages.
+# For example, if you see a warning starting like
+#
+# Main.hs:116:51: Warning: Redundant ==
+#
+# You can refer to that hint with `{name: Redundant ==}` (see below).
+
 # The monad of no return will be here one day
 - error: {lhs: "return x", rhs: pure x}
 
@@ -62,12 +60,19 @@
 #
 # Generalise map to fmap, ++ to <>
 # - group: {name: generalise, enabled: true}
+#
+# Warn on use of partial functions
+# - group: {name: partial, enabled: true}
 
 
 # Ignore some builtin hints
 # - ignore: {name: Use let}
 # - ignore: {name: Use const, within: SpecialModule} # Only within certain modules
 
+# Fuse on/on conflicts with Esqueleto's `on`
+- ignore: { name: "Fuse on/on" }
+
+
 
 # Define some custom infix operators
 # - fixity: infixr 3 ~^#^~

cardano-chain-gen/src/Cardano/Mock/Forging/Tx/Conway/Scenarios.hs

@@ -51,9 +51,10 @@ delegateAndSendBlocks n interpreter = do
     stakeCreds = createStakeCredentials n
     payCreds = createPaymentCredentials n
     addresses =
-      map
-        (\(payCred, stakeCred) -> Addr Testnet payCred (StakeRefBase stakeCred))
-        (zip payCreds stakeCreds)
+      zipWith
+        (\payCred stakeCred -> Addr Testnet payCred (StakeRefBase stakeCred))
+        payCreds
+        stakeCreds
 
 mkRegisterBlocks :: [StakeCredential] -> Interpreter -> IO [CardanoBlock]
 mkRegisterBlocks creds interpreter = forgeBlocksChunked interpreter creds $ \txCreds _ ->
@@ -65,7 +66,7 @@ mkRegisterBlocks creds interpreter = forgeBlocksChunked interpreter creds $ \txC
 mkDelegateBlocks :: [StakeCredential] -> Interpreter -> IO [CardanoBlock]
 mkDelegateBlocks creds interpreter = forgeBlocksChunked interpreter creds $ \txCreds state' ->
   Conway.mkDCertTx
-    (map (mkDelegCert state') $ zip (cycle [0, 1, 2]) txCreds)
+    (zipWith (curry (mkDelegCert state')) (cycle [0, 1, 2]) txCreds)
     (Withdrawals mempty)
     Nothing
   where

cardano-chain-gen/src/Cardano/Mock/Query.hs

@@ -176,7 +176,7 @@ queryTreasuryDonations = do
     txs <- from $ table @Db.Tx
     pure $ sum_ (txs ^. Db.TxTreasuryDonation)
 
-  let total = join (unValue <$> res)
+  let total = unValue =<< res
   pure $ maybe 0 Db.unDbLovelace total
 
 queryVoteCounts ::

cardano-chain-gen/test/Test/Cardano/Db/Mock/UnifiedApi.hs

@@ -33,7 +33,7 @@ import qualified Cardano.Mock.Forging.Tx.Conway.Scenarios as Conway
 import Cardano.Mock.Forging.Types
 import Cardano.Slotting.Slot (SlotNo (..))
 import Control.Concurrent.Class.MonadSTM.Strict (atomically)
-import Control.Monad (forM, replicateM)
+import Control.Monad (replicateM)
 import Data.Word (Word64)
 import Ouroboros.Consensus.Cardano.Block (
   BabbageEra,
@@ -63,7 +63,7 @@ forgeNextSkipSlotsFindLeaderAndSubmit interpreter mockServer skipSlots txs' = do
 
 forgeAndSubmitBlocks :: Interpreter -> ServerHandle IO CardanoBlock -> Int -> IO [CardanoBlock]
 forgeAndSubmitBlocks interpreter mockServer blocksToCreate =
-  forM [1 .. blocksToCreate] $ \_ -> forgeNextFindLeaderAndSubmit interpreter mockServer []
+  replicateM blocksToCreate (forgeNextFindLeaderAndSubmit interpreter mockServer [])
 
 withAlonzoFindLeaderAndSubmit ::
   Interpreter ->

cardano-db-sync/src/Cardano/DbSync/Config/Node.hs

@@ -78,8 +78,8 @@ readByteStringFromFile fp cfgType =
 -- -------------------------------------------------------------------------------------------------
 
 instance FromJSON NodeConfig where
-  parseJSON v =
-    Aeson.withObject "NodeConfig" parse v
+  parseJSON =
+    Aeson.withObject "NodeConfig" parse
     where
       parse :: Object -> Parser NodeConfig
       parse o =

cardano-db-sync/src/Cardano/DbSync/DbAction.hs

@@ -56,7 +56,7 @@ waitRestartState tc = do
 waitDoneInit :: ThreadChannels -> IO ()
 waitDoneInit tc = atomically $ do
   isDone <- readTVar (tcDoneInit tc)
-  if isDone then pure () else retry
+  unless isDone retry
 
 runAndSetDone :: ThreadChannels -> IO Bool -> IO Bool
 runAndSetDone tc action = do

cardano-db-sync/src/Cardano/DbSync/Era/Shelley/Generic/Block.hs

@@ -1,7 +1,6 @@
 {-# LANGUAGE CPP #-}
 {-# LANGUAGE DataKinds #-}
 {-# LANGUAGE FlexibleContexts #-}
-{-# LANGUAGE OverloadedStrings #-}
 {-# LANGUAGE RankNTypes #-}
 {-# LANGUAGE ScopedTypeVariables #-}
 {-# LANGUAGE TypeApplications #-}

cardano-db-sync/src/Cardano/DbSync/Era/Shelley/Generic/ProtoParams.hs

@@ -1,5 +1,4 @@
 {-# LANGUAGE DataKinds #-}
-{-# LANGUAGE OverloadedStrings #-}
 {-# LANGUAGE RankNTypes #-}
 {-# LANGUAGE NoImplicitPrelude #-}
 

cardano-db-sync/src/Cardano/DbSync/Era/Shelley/Generic/StakeDist.hs

@@ -3,7 +3,6 @@
 {-# LANGUAGE DataKinds #-}
 {-# LANGUAGE FlexibleContexts #-}
 {-# LANGUAGE GADTs #-}
-{-# LANGUAGE OverloadedStrings #-}
 {-# LANGUAGE ScopedTypeVariables #-}
 {-# LANGUAGE TupleSections #-}
 {-# LANGUAGE NoImplicitPrelude #-}

cardano-db-sync/src/Cardano/DbSync/Ledger/State.hs

@@ -693,7 +693,7 @@ listKnownSnapshots :: HasLedgerEnv -> IO [SnapshotPoint]
 listKnownSnapshots env = do
   inMem <- fmap InMemory <$> listMemorySnapshots env
   onDisk <- fmap OnDisk <$> listLedgerStateFilesOrdered (leDir env)
-  pure $ reverse $ List.sortOn getSlotNoSnapshot $ inMem <> onDisk
+  pure $ List.sortOn (Down . getSlotNoSnapshot) (inMem <> onDisk)
 
 listMemorySnapshots :: HasLedgerEnv -> IO [CardanoPoint]
 listMemorySnapshots env = do