Skip to content

Commit 30d293d

Browse files
authored
Merge pull request #5473 from IntersectMBO/carlos/update-fls-enable-tests-5
Update formal-ledger-specification and enable tests
2 parents b06b71e + 0446acc commit 30d293d

File tree

4 files changed

+9
-19
lines changed

4 files changed

+9
-19
lines changed

cabal.project

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ source-repository-package
1616
subdir: hs
1717
-- !WARNING!:
1818
-- MAKE SURE THIS POINTS TO A COMMIT IN `*-artifacts` BEFORE MERGE!
19-
tag: 99420c6806ed42c4c2e8bb74c593d161fd821456
19+
tag: 9291fe30190180631e79589c506a062e95123961
2020

2121
source-repository-package
2222
type: git

eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/RatifySpec.hs

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -143,9 +143,7 @@ spoAndCCVotingSpec = do
143143

144144
getLastEnactedParameterChange `shouldReturn` SNothing
145145
getsPParams ppMinFeeRefScriptCostPerByteL `shouldReturn` initialRefScriptBaseFee
146-
-- https://github.com/IntersectMBO/cardano-ledger/issues/5418
147-
-- TODO: Re-enable after issue is resolved, by removing this override
148-
disableInConformanceIt "Committee proposals pass" $
146+
it "Committee proposals pass" $
149147
whenPostBootstrap $ do
150148
modifyPParams $ \pp ->
151149
pp
@@ -233,9 +231,7 @@ spoAndCCVotingSpec = do
233231
constitutionActionId <- submitGovAction $ NewConstitution SNothing newConstitution
234232
logRatificationChecks constitutionActionId
235233
getConstitution `shouldNotReturn` newConstitution
236-
-- https://github.com/IntersectMBO/cardano-ledger/issues/5418
237-
-- TODO: Re-enable after issue is resolved, by removing this override
238-
disableInConformanceIt
234+
it
239235
"Constitution cannot be changed if committee is not active because it doesn't have registered hot credentials"
240236
$ whenPostBootstrap
241237
$ do
@@ -1123,9 +1119,7 @@ votingSpec =
11231119
passNEpochs 2
11241120
-- The same vote should now successfully ratify the proposal
11251121
getLastEnactedCommittee `shouldReturn` SJust (GovPurposeId addCCGaid)
1126-
-- https://github.com/IntersectMBO/formal-ledger-specifications/issues/926
1127-
-- TODO: Re-enable after issue is resolved, by removing this override
1128-
disableInConformanceIt "Rewards contribute to active voting stake even in the absence of StakeDistr" $
1122+
it "Rewards contribute to active voting stake even in the absence of StakeDistr" $
11291123
whenPostBootstrap $ do
11301124
let govActionLifetime = 5
11311125
govActionDeposit = Coin 1_000_000

flake.lock

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

libs/cardano-ledger-conformance/test/Test/Cardano/Ledger/Conformance/Spec/Conway/Ratify.hs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -80,16 +80,12 @@ conformsToImplAccepted impl agda = property $ do
8080

8181
spec :: Spec
8282
spec = describe "RATIFY" $ do
83-
-- https://github.com/IntersectMBO/cardano-ledger/issues/5418
84-
-- TODO: Re-enable after issue is resolved, by removing this override
85-
xprop "STS" $ conformsToImplConstrained_ constrainedRatify
83+
prop "STS" $ conformsToImplConstrained_ constrainedRatify
8684
describe "Accepted" $ do
8785
forM_
8886
[ ("DRep", (dRepAccepted, Agda.acceptedByDRep))
8987
, ("SPO", (spoAccepted, Agda.acceptedBySPO))
88+
, ("CC", (committeeAccepted, Agda.acceptedByCC))
9089
]
9190
$ \(l, (impl, agda)) ->
9291
prop l $ conformsToImplAccepted impl agda
93-
-- https://github.com/IntersectMBO/cardano-ledger/issues/5418
94-
-- TODO: Re-enable after issue is resolved, by removing this override
95-
xprop "CC" $ conformsToImplAccepted committeeAccepted Agda.acceptedByCC

0 commit comments

Comments
 (0)