Skip to content

Commit 0c6fad6

Browse files
committed
refactor(test): remove pytest-timeout dependency
Removed pytest-timeout from project dependencies and related lock file entries. Updated test runner scripts to no longer pass timeout arguments to pytest. Test session timeout is now managed outside of pytest. The `pytest-timeout` plugin was previously used to enforce timeouts on individual tests. However, it seems that it doesn't play well with `subprocess` timeouts that we use with `cardano-cli` calls.
1 parent 9320aac commit 0c6fad6

File tree

3 files changed

+5
-21
lines changed

3 files changed

+5
-21
lines changed

.github/run_tests.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
# DESELECT_FROM_FILE: path to file with tests to deselect
2222
# CLUSTERS_COUNT: number of local testnet clusters to launch
2323
# FORBID_RESTART: if set to 1, do not restart clusters between tests
24-
# SESSION_TIMEOUT: overall timeout for the test session (e.g. 10800 for 3 hours)
24+
# SESSION_TIMEOUT: timeout for the test session (e.g. 10800 for 3 hours)
2525
#
2626
# Notes:
2727
# - If PYTEST_ARGS is provided, we disable cleanup and the initial "skip all" pass.
@@ -171,7 +171,7 @@ target_tests() {
171171
compute_common_args
172172
cleanup_previous_run
173173
initial_skip_pass
174-
run_real_tests --timeout=7200 "$@"
174+
run_real_tests "$@"
175175
}
176176

177177
target_testpr() {
@@ -186,7 +186,7 @@ target_testpr() {
186186
compute_common_args
187187
cleanup_previous_run
188188
initial_skip_pass
189-
run_real_tests --timeout=1200 "$@"
189+
run_real_tests "$@"
190190
}
191191

192192
target_testnets() {
@@ -201,7 +201,7 @@ target_testnets() {
201201
compute_common_args
202202
cleanup_previous_run
203203
initial_skip_pass
204-
run_real_tests --timeout=7200 "$@"
204+
run_real_tests "$@"
205205
}
206206

207207
# Dispatch

poetry.lock

Lines changed: 1 addition & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ PyYAML = "^6.0.2"
4343
requests = "^2.32.4"
4444
pytest-subtests = "^0.14.2"
4545
cardonnay = "^0.2.8"
46-
pytest-timeout = "^2.4.0"
4746

4847
[tool.poetry.group.dev]
4948
optional = true

0 commit comments

Comments
 (0)