refactor: centralize ADDR_ALPHABET constant usage (#3193)

Move the ADDR_ALPHABET definition to common.py and update all references
in test_cli.py and test_tx_negative.py to use common.ADDR_ALPHABET.
This reduces duplication and ensures consistency in address generation
for hypothesis-based tests.

Author: mkoura

cardano_node_tests/tests/common.py

@@ -1,4 +1,5 @@
 import logging
+import string
 import time
 import typing as tp
 
@@ -20,6 +21,8 @@
 MAX_INT64 = (2**63) - 1
 MAX_UINT64 = (2**64) - 1
 
+ADDR_ALPHABET = string.ascii_lowercase + string.digits
+
 ORDER5_BYRON = (
     pytest.mark.order(5) if "_fast" not in configuration.TESTNET_VARIANT else pytest.mark.noop
 )

cardano_node_tests/tests/test_cli.py

@@ -29,9 +29,6 @@
 LOGGER = logging.getLogger(__name__)
 DATA_DIR = pl.Path(__file__).parent / "data"
 
-ADDR_ALPHABET = list(f"{string.ascii_lowercase}{string.digits}")
-
-
 pytestmark = common.SKIPIF_WRONG_ERA
 
 
@@ -373,7 +370,7 @@ def test_address_info_payment_with_outfile(self, cluster: clusterlib.ClusterLib)
         )
 
     @allure.link(helpers.get_vcs_link())
-    @hypothesis.given(address=st.text(alphabet=ADDR_ALPHABET, min_size=1))
+    @hypothesis.given(address=st.text(alphabet=common.ADDR_ALPHABET, min_size=1))
     @common.hypothesis_settings(max_examples=300)
     @pytest.mark.smoke
     def test_address_info_with_invalid_address(self, cluster: clusterlib.ClusterLib, address: str):
@@ -471,7 +468,7 @@ def test_address_build(
 
     @allure.link(helpers.get_vcs_link())
     @pytest.mark.parametrize("option", ("vkey", "vkey_file", "script_file"))
-    @hypothesis.given(key=st.text(alphabet=ADDR_ALPHABET, min_size=1))
+    @hypothesis.given(key=st.text(alphabet=common.ADDR_ALPHABET, min_size=1))
     @common.hypothesis_settings(max_examples=300)
     @pytest.mark.smoke
     def test_invalid_payment_info(
@@ -531,7 +528,7 @@ def test_invalid_payment_info(
             "address",
         ),
     )
-    @hypothesis.given(key=st.text(alphabet=ADDR_ALPHABET, min_size=1))
+    @hypothesis.given(key=st.text(alphabet=common.ADDR_ALPHABET, min_size=1))
     @common.hypothesis_settings(max_examples=300)
     @pytest.mark.smoke
     def test_invalid_stake_info(
@@ -619,7 +616,7 @@ def test_valid_verification_key(self, cluster: clusterlib.ClusterLib, option: st
 
     @allure.link(helpers.get_vcs_link())
     @pytest.mark.parametrize("option", ("vkey", "vkey_file"))
-    @hypothesis.given(vkey=st.text(alphabet=ADDR_ALPHABET, min_size=1))
+    @hypothesis.given(vkey=st.text(alphabet=common.ADDR_ALPHABET, min_size=1))
     @common.hypothesis_settings(max_examples=300)
     @pytest.mark.smoke
     def test_invalid_verification_key(self, cluster: clusterlib.ClusterLib, option: str, vkey: str):
@@ -866,7 +863,7 @@ def test_tx_in_invalid_data(
             assert "expecting digit" in err_str, err_str
 
     @allure.link(helpers.get_vcs_link())
-    @hypothesis.given(filter_str=st.text(alphabet=ADDR_ALPHABET, min_size=1))
+    @hypothesis.given(filter_str=st.text(alphabet=common.ADDR_ALPHABET, min_size=1))
     @common.hypothesis_settings(max_examples=300)
     @pytest.mark.smoke
     def test_address_invalid_data(self, cluster: clusterlib.ClusterLib, filter_str: str):
@@ -922,7 +919,7 @@ def test_valid_verification_key(self, cluster: clusterlib.ClusterLib, option: st
 
     @allure.link(helpers.get_vcs_link())
     @pytest.mark.parametrize("option", ("vkey", "vkey_file"))
-    @hypothesis.given(vkey=st.text(alphabet=ADDR_ALPHABET, min_size=1))
+    @hypothesis.given(vkey=st.text(alphabet=common.ADDR_ALPHABET, min_size=1))
     @common.hypothesis_settings(max_examples=300)
     @pytest.mark.smoke
     def test_invalid_verification_key(self, cluster: clusterlib.ClusterLib, option: str, vkey: str):

cardano_node_tests/tests/test_tx_negative.py

@@ -7,7 +7,6 @@
 import logging
 import pathlib as pl
 import re
-import string
 import time
 import typing as tp
 
@@ -31,8 +30,6 @@
 
 LOGGER = logging.getLogger(__name__)
 
-ADDR_ALPHABET = list(f"{string.ascii_lowercase}{string.digits}")
-
 
 class TestNegative:
     """Transaction tests that are expected to fail."""
@@ -872,7 +869,7 @@ def test_send_funds_to_utxo_address(
 
     @allure.link(helpers.get_vcs_link())
     @common.PARAM_BUILD_METHOD
-    @hypothesis.given(addr=st.text(alphabet=ADDR_ALPHABET, min_size=98, max_size=98))
+    @hypothesis.given(addr=st.text(alphabet=common.ADDR_ALPHABET, min_size=98, max_size=98))
     @common.hypothesis_settings(300)
     @pytest.mark.smoke
     @pytest.mark.testnets
@@ -899,7 +896,7 @@ def test_send_funds_to_invalid_address(
         )
 
     @allure.link(helpers.get_vcs_link())
-    @hypothesis.given(addr=st.text(alphabet=ADDR_ALPHABET, min_size=50, max_size=250))
+    @hypothesis.given(addr=st.text(alphabet=common.ADDR_ALPHABET, min_size=50, max_size=250))
     @common.hypothesis_settings(300)
     @common.PARAM_BUILD_METHOD
     @pytest.mark.smoke
@@ -957,7 +954,7 @@ def test_send_funds_to_invalid_chars_address(
         )
 
     @allure.link(helpers.get_vcs_link())
-    @hypothesis.given(addr=st.text(alphabet=ADDR_ALPHABET, min_size=98, max_size=98))
+    @hypothesis.given(addr=st.text(alphabet=common.ADDR_ALPHABET, min_size=98, max_size=98))
     @common.hypothesis_settings(300)
     @common.PARAM_BUILD_METHOD
     @pytest.mark.smoke
@@ -985,7 +982,7 @@ def test_send_funds_from_invalid_address(
         )
 
     @allure.link(helpers.get_vcs_link())
-    @hypothesis.given(addr=st.text(alphabet=ADDR_ALPHABET, min_size=50, max_size=250))
+    @hypothesis.given(addr=st.text(alphabet=common.ADDR_ALPHABET, min_size=50, max_size=250))
     @common.hypothesis_settings(300)
     @common.PARAM_BUILD_METHOD
     @pytest.mark.smoke
@@ -1044,7 +1041,7 @@ def test_send_funds_from_invalid_chars_address(
 
     @allure.link(helpers.get_vcs_link())
     @common.SKIPIF_BUILD_UNUSABLE
-    @hypothesis.given(addr=st.text(alphabet=ADDR_ALPHABET, min_size=98, max_size=98))
+    @hypothesis.given(addr=st.text(alphabet=common.ADDR_ALPHABET, min_size=98, max_size=98))
     @common.hypothesis_settings(300)
     @pytest.mark.smoke
     @pytest.mark.testnets
@@ -1096,7 +1093,7 @@ def test_build_send_funds_invalid_chars_change_address(
 
     @allure.link(helpers.get_vcs_link())
     @common.SKIPIF_BUILD_UNUSABLE
-    @hypothesis.given(addr=st.text(alphabet=ADDR_ALPHABET, min_size=50, max_size=250))
+    @hypothesis.given(addr=st.text(alphabet=common.ADDR_ALPHABET, min_size=50, max_size=250))
     @common.hypothesis_settings(300)
     @pytest.mark.smoke
     @pytest.mark.testnets
@@ -1205,7 +1202,7 @@ def test_nonexistent_utxo_hash(
             raise ValueError(msg)
 
     @allure.link(helpers.get_vcs_link())
-    @hypothesis.given(utxo_hash=st.text(alphabet=ADDR_ALPHABET, min_size=10, max_size=550))
+    @hypothesis.given(utxo_hash=st.text(alphabet=common.ADDR_ALPHABET, min_size=10, max_size=550))
     @common.hypothesis_settings(300)
     @common.PARAM_BUILD_METHOD
     @pytest.mark.smoke
@@ -1241,7 +1238,7 @@ def test_invalid_length_utxo_hash(
 
     @allure.link(helpers.get_vcs_link())
     @common.SKIPIF_BUILD_UNUSABLE
-    @hypothesis.given(utxo_hash=st.text(alphabet=ADDR_ALPHABET, min_size=10, max_size=550))
+    @hypothesis.given(utxo_hash=st.text(alphabet=common.ADDR_ALPHABET, min_size=10, max_size=550))
     @common.hypothesis_settings(300)
     @pytest.mark.smoke
     @pytest.mark.testnets