feat: check fees only on local testnet

- Added `is_fee_in_interval` function to `common.py` for checking if the fee
  is within the expected range on local testnet.
- Replaced `helpers.is_in_interval` with `common.is_fee_in_interval` in
  various test files to use the new function.

Author: mkoura

cardano_node_tests/tests/common.py

@@ -10,6 +10,7 @@
 from cardano_node_tests.utils import cluster_nodes
 from cardano_node_tests.utils import clusterlib_utils
 from cardano_node_tests.utils import configuration
+from cardano_node_tests.utils import helpers
 from cardano_node_tests.utils import pytest_utils
 from cardano_node_tests.utils.versions import VERSIONS
 
@@ -450,3 +451,15 @@ def get_pool_user(
         caching_key=caching_key,
         amount=amount,
     )[0]
+
+
+def is_fee_in_interval(fee: float, expected_fee: float, frac: float = 0.1) -> bool:
+    """Check that the fee is within the expected range on local testnet.
+
+    The fee is considered to be within the expected range if it is within the expected_fee +/- frac
+    range.
+    """
+    # We have the fees calibrated only for local testnet
+    if cluster_nodes.get_cluster_type().type == cluster_nodes.ClusterType.TESTNET:
+        return True
+    return helpers.is_in_interval(fee, expected_fee, frac=frac)

cardano_node_tests/tests/test_native_tokens.py

@@ -228,9 +228,9 @@ def test_minting_and_burning_witnesses(
         assert not token_utxo, "The token was not burnt"
 
         # Check expected fees
-        assert helpers.is_in_interval(
+        assert common.is_fee_in_interval(
             tx_out_mint.fee, expected_fee, frac=0.15
-        ) and helpers.is_in_interval(tx_out_burn.fee, expected_fee, frac=0.15), (
+        ) and common.is_fee_in_interval(tx_out_burn.fee, expected_fee, frac=0.15), (
             "TX fee doesn't fit the expected interval"
         )
 
@@ -327,9 +327,9 @@ def test_minting_and_burning_sign(
         assert not token_utxo, "The token was not burnt"
 
         # Check expected fees
-        assert helpers.is_in_interval(
+        assert common.is_fee_in_interval(
             tx_out_mint.fee, expected_fee, frac=0.15
-        ) and helpers.is_in_interval(tx_out_burn.fee, expected_fee, frac=0.15), (
+        ) and common.is_fee_in_interval(tx_out_burn.fee, expected_fee, frac=0.15), (
             "TX fee doesn't fit the expected interval"
         )
 
@@ -443,9 +443,9 @@ def test_minting_multiple_scripts(
             assert not utxo_burn, f"The {t.token} token was not burnt"
 
         # Check expected fees
-        assert helpers.is_in_interval(
+        assert common.is_fee_in_interval(
             tx_out_mint.fee, expected_fee, frac=0.15
-        ) and helpers.is_in_interval(tx_out_burn.fee, expected_fee, frac=0.15), (
+        ) and common.is_fee_in_interval(tx_out_burn.fee, expected_fee, frac=0.15), (
             "TX fee doesn't fit the expected interval"
         )
 
@@ -562,7 +562,7 @@ def test_minting_burning_diff_tokens_single_tx(
         assert not token2_burn_utxo, "The token was not burnt"
 
         # Check expected fees
-        assert helpers.is_in_interval(tx_out_mint_burn.fee, expected_fee, frac=0.15), (
+        assert common.is_fee_in_interval(tx_out_mint_burn.fee, expected_fee, frac=0.15), (
             "TX fee doesn't fit the expected interval"
         )
 
@@ -685,7 +685,7 @@ def test_minting_burning_same_token_single_tx(
         assert token_utxo and token_utxo[0].amount == 1, "The token was not minted"
 
         # Check expected fees
-        assert helpers.is_in_interval(tx_output.fee, expected_fee, frac=0.15), (
+        assert common.is_fee_in_interval(tx_output.fee, expected_fee, frac=0.15), (
             "TX fee doesn't fit the expected interval"
         )
 
@@ -829,7 +829,7 @@ def _mint_tokens() -> clusterlib.TxRawOutput:
 
         # Check expected fees
         mint_fee = tx_out_mint.fee
-        assert helpers.is_in_interval(mint_fee, expected_fee, frac=0.15), (
+        assert common.is_fee_in_interval(mint_fee, expected_fee, frac=0.15), (
             "TX fee doesn't fit the expected interval"
         )
 
@@ -979,7 +979,7 @@ def _mint_tokens() -> clusterlib.TxRawOutput:
 
         # Check expected fees
         mint_fee = tx_out_mint.fee
-        assert helpers.is_in_interval(mint_fee, expected_fee, frac=0.15), (
+        assert common.is_fee_in_interval(mint_fee, expected_fee, frac=0.15), (
             "TX fee doesn't fit the expected interval"
         )
 
@@ -1077,7 +1077,7 @@ def test_minting_and_partial_burning(
         )
 
         # Check expected fee
-        assert helpers.is_in_interval(tx_out_mint.fee, expected_fee, frac=0.15), (
+        assert common.is_fee_in_interval(tx_out_mint.fee, expected_fee, frac=0.15), (
             "TX fee doesn't fit the expected interval"
         )
 
@@ -1163,9 +1163,9 @@ def test_minting_unicode_asset_name(
         assert not token_utxo, "The token was not burnt"
 
         # Check expected fees
-        assert helpers.is_in_interval(
+        assert common.is_fee_in_interval(
             tx_out_mint.fee, expected_fee, frac=0.15
-        ) and helpers.is_in_interval(tx_out_burn.fee, expected_fee, frac=0.15), (
+        ) and common.is_fee_in_interval(tx_out_burn.fee, expected_fee, frac=0.15), (
             "TX fee doesn't fit the expected interval"
         )
 
@@ -1260,9 +1260,9 @@ def test_valid_policy_after(
             assert not token_utxo, "The token was not burnt"
 
         # Check expected fees
-        assert helpers.is_in_interval(
+        assert common.is_fee_in_interval(
             tx_out_mint.fee, expected_fee, frac=0.15
-        ) and helpers.is_in_interval(tx_out_burn.fee, expected_fee, frac=0.15), (
+        ) and common.is_fee_in_interval(tx_out_burn.fee, expected_fee, frac=0.15), (
             "TX fee doesn't fit the expected interval"
         )
 
@@ -1354,9 +1354,9 @@ def test_valid_policy_before(
             assert not token_utxo, "The token was not burnt"
 
         # Check expected fees
-        assert helpers.is_in_interval(
+        assert common.is_fee_in_interval(
             tx_out_mint.fee, expected_fee, frac=0.15
-        ) and helpers.is_in_interval(tx_out_burn.fee, expected_fee, frac=0.15), (
+        ) and common.is_fee_in_interval(tx_out_burn.fee, expected_fee, frac=0.15), (
             "TX fee doesn't fit the expected interval"
         )
 
@@ -2420,7 +2420,7 @@ def test_multiasset_txouts_syntax(
         assert token_utxo and token_utxo[0].amount == 1_000, "The token was not minted"
 
         # Check expected fees
-        assert helpers.is_in_interval(tx_raw_output.fee, expected_fee, frac=0.15), (
+        assert common.is_fee_in_interval(tx_raw_output.fee, expected_fee, frac=0.15), (
             "TX fee doesn't fit the expected interval"
         )
 
@@ -2592,7 +2592,7 @@ def test_script_reference_utxo(
         assert cluster.g_query.get_utxo(utxo=reference_utxo), "Reference input was spent"
 
         # Check expected fees
-        assert helpers.is_in_interval(tx_raw_output.fee, expected_fee, frac=0.15), (
+        assert common.is_fee_in_interval(tx_raw_output.fee, expected_fee, frac=0.15), (
             "TX fee doesn't fit the expected interval"
         )
 

cardano_node_tests/tests/test_scripts.py

@@ -454,7 +454,7 @@ def test_multisig_any(
         expected_fee = 204_969
         for tx_out in from_single_tx_outputs:
             # Check expected fees
-            assert helpers.is_in_interval(tx_out.fee, expected_fee, frac=0.15), (
+            assert common.is_fee_in_interval(tx_out.fee, expected_fee, frac=0.15), (
                 "TX fee doesn't fit the expected interval"
             )
 
@@ -747,7 +747,7 @@ def test_multisig_empty_all(
 
         # Check expected fees
         expected_fee = 176_809
-        assert helpers.is_in_interval(tx_out_from.fee, expected_fee, frac=0.15), (
+        assert common.is_fee_in_interval(tx_out_from.fee, expected_fee, frac=0.15), (
             "TX fee doesn't fit the expected interval"
         )
 
@@ -814,7 +814,7 @@ def test_multisig_no_required_atleast(
 
         # Check expected fees
         expected_fee = 176_765
-        assert helpers.is_in_interval(tx_out_from.fee, expected_fee, frac=0.15), (
+        assert common.is_fee_in_interval(tx_out_from.fee, expected_fee, frac=0.15), (
             "TX fee doesn't fit the expected interval"
         )
 
@@ -1257,7 +1257,7 @@ def test_script_after(
 
         # Check expected fees
         expected_fee = 280_693 if use_build_cmd else 323_857
-        assert helpers.is_in_interval(tx_out_from.fee, expected_fee, frac=0.15), (
+        assert common.is_fee_in_interval(tx_out_from.fee, expected_fee, frac=0.15), (
             "TX fee doesn't fit the expected interval"
         )
 
@@ -1334,7 +1334,7 @@ def test_script_before(
 
         # Check expected fees
         expected_fee = 279_241 if use_build_cmd else 323_989
-        assert helpers.is_in_interval(tx_out_from.fee, expected_fee, frac=0.15), (
+        assert common.is_fee_in_interval(tx_out_from.fee, expected_fee, frac=0.15), (
             "TX fee doesn't fit the expected interval"
         )
 

cardano_node_tests/tests/test_tx_fees.py

@@ -294,7 +294,7 @@ def _from_to_transactions(
         tx_fee = cluster_obj.g_transaction.calculate_tx_fee(
             src_address=src_address, tx_name=tx_name, txins=txins, txouts=txouts, tx_files=tx_files
         )
-        assert helpers.is_in_interval(tx_fee, expected_fee), (
+        assert common.is_fee_in_interval(tx_fee, expected_fee), (
             "Expected fee doesn't match the actual fee"
         )
 
@@ -350,7 +350,7 @@ def test_pool_registration_fees(
         tx_fee = cluster.g_transaction.calculate_tx_fee(
             src_address=src_address, tx_name=temp_template, tx_files=tx_files
         )
-        assert helpers.is_in_interval(tx_fee, expected_fee), (
+        assert common.is_fee_in_interval(tx_fee, expected_fee), (
             "Expected fee doesn't match the actual fee"
         )
 
@@ -418,7 +418,7 @@ def test_pool_deregistration_fees(
         tx_fee = cluster.g_transaction.calculate_tx_fee(
             src_address=src_address, tx_name=temp_template, tx_files=tx_files
         )
-        assert helpers.is_in_interval(tx_fee, expected_fee), (
+        assert common.is_fee_in_interval(tx_fee, expected_fee), (
             "Expected fee doesn't match the actual fee"
         )
 
@@ -459,7 +459,7 @@ def test_addr_registration_fees(
         tx_fee = cluster.g_transaction.calculate_tx_fee(
             src_address=src_address, tx_name=temp_template, tx_files=tx_files
         )
-        assert helpers.is_in_interval(tx_fee, expected_fee), (
+        assert common.is_fee_in_interval(tx_fee, expected_fee), (
             "Expected fee doesn't match the actual fee"
         )
 
@@ -500,7 +500,7 @@ def test_addr_deregistration_fees(
         tx_fee = cluster.g_transaction.calculate_tx_fee(
             src_address=src_address, tx_name=temp_template, tx_files=tx_files
         )
-        assert helpers.is_in_interval(tx_fee, expected_fee), (
+        assert common.is_fee_in_interval(tx_fee, expected_fee), (
             "Expected fee doesn't match the actual fee"
         )
 

cardano_node_tests/tests/tests_plutus/test_mint_build.py

@@ -217,10 +217,10 @@ def test_minting_one_token(
 
         # Check expected fees
         expected_fee_step1 = 168_977
-        assert helpers.is_in_interval(tx_output_step1.fee, expected_fee_step1, frac=0.15)
+        assert common.is_fee_in_interval(tx_output_step1.fee, expected_fee_step1, frac=0.15)
 
         expected_fee_step2 = 187_031 if plutus_version == "v3" else 350_000
-        assert helpers.is_in_interval(tx_output_step2.fee, expected_fee_step2, frac=0.15)
+        assert common.is_fee_in_interval(tx_output_step2.fee, expected_fee_step2, frac=0.15)
 
         plutus_common.check_plutus_costs(
             plutus_costs=plutus_costs,
@@ -487,10 +487,10 @@ def test_time_range_minting(
 
         # Check expected fees
         expected_fee_step1 = 167_349
-        assert helpers.is_in_interval(tx_output_step1.fee, expected_fee_step1, frac=0.15)
+        assert common.is_fee_in_interval(tx_output_step1.fee, expected_fee_step1, frac=0.15)
 
         expected_fee_step2 = 346_952 if plutus_version == "v3" else 411_175
-        assert helpers.is_in_interval(tx_output_step2.fee, expected_fee_step2, frac=0.15)
+        assert common.is_fee_in_interval(tx_output_step2.fee, expected_fee_step2, frac=0.15)
 
         plutus_common.check_plutus_costs(
             plutus_costs=plutus_costs,
@@ -754,10 +754,10 @@ def test_two_scripts_minting(
 
         # Check expected fees
         expected_fee_step1 = 168_977
-        assert helpers.is_in_interval(tx_output_step1.fee, expected_fee_step1, frac=0.15)
+        assert common.is_fee_in_interval(tx_output_step1.fee, expected_fee_step1, frac=0.15)
 
         expected_fee_step2 = 428_543 if plutus_version == "mix_v3_v1" else 633_269
-        assert helpers.is_in_interval(tx_output_step2.fee, expected_fee_step2, frac=0.15)
+        assert common.is_fee_in_interval(tx_output_step2.fee, expected_fee_step2, frac=0.15)
 
         plutus_common.check_plutus_costs(
             plutus_costs=plutus_costs,
@@ -1115,10 +1115,10 @@ def test_witness_redeemer(
 
         # Check expected fees
         expected_fee_step1 = 167_349
-        assert helpers.is_in_interval(tx_output_step1.fee, expected_fee_step1, frac=0.15)
+        assert common.is_fee_in_interval(tx_output_step1.fee, expected_fee_step1, frac=0.15)
 
         expected_fee_step2 = 372_438
-        assert helpers.is_in_interval(tx_output_step2.fee, expected_fee_step2, frac=0.15)
+        assert common.is_fee_in_interval(tx_output_step2.fee, expected_fee_step2, frac=0.15)
 
         plutus_common.check_plutus_costs(
             plutus_costs=plutus_costs,