Skip to content

Commit 30e9c95

Browse files
This PR refactors test_conway.py align with the new build Method
1 parent 5a3981e commit 30e9c95

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

cardano_node_tests/tests/tests_conway/test_conway.py

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ def _run_test_action_unreg_deposit_addr(
7373
cluster: clusterlib.ClusterLib,
7474
temp_template: str,
7575
pool_user: clusterlib.PoolUser,
76-
use_build_cmd: bool,
76+
build_method: str,
7777
submit_method: str = submit_utils.SubmitMethods.CLI,
7878
):
7979
"""Run the actual scenario of the 'test_action_unreg_deposit_addr*' tests."""
@@ -104,17 +104,23 @@ def _run_test_action_unreg_deposit_addr(
104104
name_template=f"{temp_template}_action",
105105
src_address=pool_user.payment.address,
106106
submit_method=submit_method,
107-
use_build_cmd=use_build_cmd,
107+
build_method=build_method,
108108
tx_files=tx_files_action,
109109
)
110110
err_str = str(excinfo.value)
111-
if use_build_cmd:
111+
if build_method in (
112+
clusterlib_utils.BuildMethods.BUILD,
113+
clusterlib_utils.BuildMethods.BUILD_EST,
114+
):
112115
assert (
113116
"Stake credential specified in the proposal is not registered on-chain" in err_str
114117
or "ProposalReturnAccountDoesNotExist" in err_str # In node <= 10.1.4
115118
), err_str
116-
else:
119+
elif build_method == clusterlib_utils.BuildMethods.BUILD_RAW:
117120
assert "ProposalReturnAccountDoesNotExist" in err_str, err_str
121+
else:
122+
msg = f"Unexpected build method: {build_method}"
123+
raise ValueError(msg)
118124

119125
@allure.link(helpers.get_vcs_link())
120126
@submit_utils.PARAM_SUBMIT_METHOD
@@ -137,7 +143,7 @@ def test_action_submit_unreg_deposit_addr(
137143
cluster=cluster,
138144
temp_template=temp_template,
139145
pool_user=pool_user,
140-
use_build_cmd=False,
146+
build_method=clusterlib_utils.BuildMethods.BUILD_RAW,
141147
submit_method=submit_method,
142148
)
143149

@@ -161,5 +167,5 @@ def test_action_build_unreg_deposit_addr(
161167
cluster=cluster,
162168
temp_template=temp_template,
163169
pool_user=pool_user,
164-
use_build_cmd=True,
170+
build_method=clusterlib_utils.BuildMethods.BUILD,
165171
)

0 commit comments

Comments
 (0)