refactor: use datetime.UTC instead of timezone.utc

Fixes ruff errors.

Replace all instances of `datetime.timezone.utc` with `datetime.UTC` for
consistency and to leverage the new standard introduced in Python 3.11.
Update imports accordingly. Also remove unnecessary noqa comments for
PERF203 and modernize some type checks. No functional changes intended.

Author: mkoura

cardano_node_tests/chang_us_coverage.py

@@ -68,7 +68,7 @@ def main() -> int:
         url = req_data.get("url")
         report = report.replace(f"https://github.com/{req_id}-404", url)
 
-    report = report.replace("TODAY", str(datetime.datetime.now(tz=datetime.timezone.utc).date()))
+    report = report.replace("TODAY", str(datetime.datetime.now(tz=datetime.UTC).date()))
 
     with open(args.output_report, "w", encoding="utf-8") as out_fp:
         out_fp.write(report)

cardano_node_tests/cluster_management/manager.py

@@ -113,9 +113,7 @@ def log(self, msg: str) -> None:
             locking.FileLockIfXdist(self.log_lock),
             open(configuration.SCHEDULING_LOG, "a", encoding="utf-8") as logfile,
         ):
-            logfile.write(
-                f"{datetime.datetime.now(tz=datetime.timezone.utc)} on {self.worker_id}: {msg}\n"
-            )
+            logfile.write(f"{datetime.datetime.now(tz=datetime.UTC)} on {self.worker_id}: {msg}\n")
 
     def save_worker_cli_coverage(self) -> None:
         """Save CLI coverage info collected by this pytest worker.

cardano_node_tests/tests/kes.py

@@ -61,7 +61,7 @@ def check_kes_period_info_result(  # noqa: C901
         errors.append(f"The kes expiration date is `null` in check '{check_id}' -> issue #4396?")
     elif command_metrics["qKesKesKeyExpiry"]:
         expected_expiration_date = (
-            datetime.datetime.now(tz=datetime.timezone.utc)
+            datetime.datetime.now(tz=datetime.UTC)
             + datetime.timedelta(
                 seconds=command_metrics["qKesRemainingSlotsInKesPeriod"] * cluster_obj.slot_length
             )

cardano_node_tests/tests/test_cli.py

@@ -1400,7 +1400,7 @@ def test_slot_number(
         """Test `query slot-number`."""
         common.get_test_id(cluster)
 
-        timestamp = datetime.datetime.now(datetime.timezone.utc)
+        timestamp = datetime.datetime.now(datetime.UTC)
         slot_number = cluster.g_query.get_slot_number(timestamp=timestamp)
 
         # In case the test runs on epoch boundary, the tip could still be in the previous epoch.
@@ -1423,7 +1423,7 @@ def test_slot_number_invalid_format(
         """
         common.get_test_id(cluster)
 
-        timestamp_str = datetime.datetime.now(datetime.timezone.utc).strftime("%Y-%m-%d")
+        timestamp_str = datetime.datetime.now(datetime.UTC).strftime("%Y-%m-%d")
 
         with pytest.raises(clusterlib.CLIError) as excinfo:
             cluster.g_query.query_cli(["slot-number", timestamp_str])
@@ -1445,7 +1445,7 @@ def test_slot_number_out_of_range(
         """
         common.get_test_id(cluster)
 
-        now = datetime.datetime.now(datetime.timezone.utc)
+        now = datetime.datetime.now(datetime.UTC)
 
         timestamp = now.replace(year=now.year * 4) if time_val == "above" else now.replace(year=1)
 

cardano_node_tests/tests/test_dbsync.py

@@ -3,9 +3,9 @@
 import logging
 import time
 import typing as tp
+from datetime import UTC
 from datetime import datetime
 from datetime import timedelta
-from datetime import timezone
 
 import allure
 import pytest
@@ -417,7 +417,7 @@ def test_latest_snapshot_freshness(
         LOGGER.info(f"Snapshot size: {latest_snapshot.size_gb:.2f} GB")
 
         # 3. Perform freshness check
-        now_utc = datetime.now(timezone.utc)
+        now_utc = datetime.now(UTC)
         five_days_ago = now_utc - timedelta(days=5)
 
         assert latest_snapshot.last_modified >= five_days_ago, (

cardano_node_tests/tests/test_kes.py

@@ -296,12 +296,12 @@ def _check_kes_period_info(
 
         with logfiles.expect_errors(expected_errors, worker_id=worker_id):
             LOGGER.info(
-                f"{datetime.datetime.now(tz=datetime.timezone.utc)}: "
+                f"{datetime.datetime.now(tz=datetime.UTC)}: "
                 f"Waiting for slot no {expire_slot} for KES expiration."
             )
             cluster.wait_for_slot(slot=expire_slot)
             LOGGER.info(
-                f"{datetime.datetime.now(tz=datetime.timezone.utc)}: "
+                f"{datetime.datetime.now(tz=datetime.UTC)}: "
                 f"KES expired (?); tip: '{cluster.g_query.get_tip()}'."
             )
 
@@ -339,7 +339,7 @@ def _check_kes_period_info(
             )
 
             LOGGER.info(
-                f"{datetime.datetime.now(tz=datetime.timezone.utc)}: "
+                f"{datetime.datetime.now(tz=datetime.UTC)}: "
                 "Waiting 90 secs to make sure the expected errors make it to log files."
             )
             time.sleep(90)

cardano_node_tests/tests/test_reconnect.py

@@ -284,7 +284,7 @@ def _assert() -> None:
                 for check_no in range(1, 11):
                     try:
                         _assert()
-                    except AssertionError:  # noqa: PERF203
+                    except AssertionError:
                         if check_no == 10:
                             raise
                         LOGGER.info(f"AssertionError on check {check_no}")

cardano_node_tests/tests/test_tx_mempool.py

@@ -88,7 +88,7 @@ def test_query_mempool_txin(
         for r in range(5):
             try:
                 cluster.g_transaction.submit_tx_bare(tx_file=out_file_signed)
-            except clusterlib.CLIError as exc:  # noqa: PERF203
+            except clusterlib.CLIError as exc:
                 exc_str = str(exc)
                 inputs_spent = (
                     "All inputs are spent" in exc_str  # In cardano-node >= 10.6.0

cardano_node_tests/tests/tests_plutus/test_mint_build.py

@@ -412,8 +412,7 @@ def test_time_range_minting(
 
         # POSIX timestamp + offset
         redeemer_value = (
-            int(datetime.datetime.now(tz=datetime.timezone.utc).timestamp() * 1_000)
-            + timestamp_offset_ms
+            int(datetime.datetime.now(tz=datetime.UTC).timestamp() * 1_000) + timestamp_offset_ms
         )
 
         policyid = cluster.g_transaction.get_policyid(plutus_v_record.script_file)
@@ -661,8 +660,7 @@ def test_two_scripts_minting(
 
         # POSIX timestamp + offset
         redeemer_value_timerange = (
-            int(datetime.datetime.now(tz=datetime.timezone.utc).timestamp() * 1_000)
-            + timestamp_offset_ms
+            int(datetime.datetime.now(tz=datetime.UTC).timestamp() * 1_000) + timestamp_offset_ms
         )
 
         policyid2 = cluster.g_transaction.get_policyid(script_file2)

cardano_node_tests/tests/tests_plutus/test_mint_negative_build.py

@@ -420,8 +420,7 @@ def test_time_range_missing_tx_validity(
 
         # POSIX timestamp + offset
         redeemer_value = (
-            int(datetime.datetime.now(tz=datetime.timezone.utc).timestamp() * 1_000)
-            + timestamp_offset_ms
+            int(datetime.datetime.now(tz=datetime.UTC).timestamp() * 1_000) + timestamp_offset_ms
         )
 
         policyid = cluster.g_transaction.get_policyid(plutus_v_record.script_file)