Merge pull request #2859 from IntersectMBO/imp_port_allocation

Improve ports allocation

Author: mkoura

README.md

@@ -98,6 +98,7 @@ Tests execution can be configured using env variables.
 * `BOOTSTRAP_DIR` – path to a bootstrap dir for the given testnet (genesis files, config files, faucet data) (default: unset)
 * `KEEP_CLUSTERS_RUNNING` – don't stop cluster instances after testrun is finished
   (WARNING: this implies interactive behavior when running tests using the `./.github/regression.sh` script)
+* `PORTS_BASE` - base port number for ports range used by cluster instances (default: 23000)
 
 When running tests using the `./.github/regression.sh` script, you can also use
 

cardano_node_tests/utils/cluster_scripts.py

@@ -166,11 +166,12 @@ def _preselect_addr(self, instance_num: int) -> str:
 
     def get_instance_ports(self, instance_num: int) -> InstancePorts:
         """Return ports mapping for given cluster instance."""
-        ports_per_instance = 100
-        ports_per_node = 5
+        # Allocate 100 ports per each 18 pools
+        ports_per_instance = ((self.num_pools - 1) // 18 + 1) * 100
         offset = instance_num * ports_per_instance
-        base = 32000 + offset
+        base = configuration.PORTS_BASE + offset
         last_port = base + ports_per_instance - 1
+        ports_per_node = 5
 
         def _get_node_ports(num: int) -> NodePorts:
             rec_base = base + (num * ports_per_node)

cardano_node_tests/utils/configuration.py

@@ -31,6 +31,10 @@ def _check_cardano_node_socket_path() -> None:
 DBSYNC_DB = "dbsync"
 IS_XDIST = bool(os.environ.get("PYTEST_XDIST_TESTRUNUID"))
 
+# Make sure the ports don't overlap with ephemeral port range. It's usually 32768 to 60999.
+# See `cat /proc/sys/net/ipv4/ip_local_port_range`.
+PORTS_BASE = int(os.environ.get("PORTS_BASE") or 23000)
+
 # Used also in startup scripts as `if [ -n "$VAR" ]...`
 ENABLE_LEGACY = (os.environ.get("ENABLE_LEGACY") or "") != ""
 # Used also in startup scripts as `if [ -n "$VAR" ]...`