chore(linting): remove pylint ignores

We no longer check the code with pylint.

Author: mkoura

cardano_node_tests/cluster_management/cluster_getter.py

@@ -1,6 +1,5 @@
 """Functionality for obtaining and setting up a cluster instance."""
 
-# pylint: disable=abstract-class-instantiated
 import dataclasses
 import logging
 import os
@@ -111,7 +110,6 @@ def _respin(self, start_cmd: str = "", stop_cmd: str = "") -> bool:  # noqa: C90
 
         Not called under global lock!
         """
-        # pylint: disable=too-many-branches,too-many-statements
         cluster_running_file = self.instance_dir / common.CLUSTER_RUNNING_FILE
 
         # Don't respin cluster if it was started outside of test framework
@@ -735,7 +733,6 @@ def get_cluster_instance(  # noqa: C901
                 ("singleton" tests).
             start_cmd: Custom command to start the cluster.
         """
-        # pylint: disable=too-many-statements,too-many-branches
         assert not isinstance(lock_resources, str), "`lock_resources` can't be single string"
         assert not isinstance(use_resources, str), "`use_resources` can't be single string"
 
@@ -800,7 +797,6 @@ def get_cluster_instance(  # noqa: C901
 
             # Sleep for a while to avoid too many checks in a short time
             _xdist_sleep(random.uniform(0.6, 1.2) * cget_status.sleep_delay)
-            # pylint: disable=consider-using-max-builtin
             cget_status.sleep_delay = max(cget_status.sleep_delay, 1)
 
             # Nothing time consuming can go under this lock as all other workers will need to wait

cardano_node_tests/pytest_plugins/xdist_scheduler.py

@@ -45,8 +45,6 @@ class OneLongScheduling(scheduler.LoadScopeScheduling):
            }
     """
 
-    # pylint: disable=abstract-method
-
     def _split_scope(self, nodeid: str) -> str:
         """Determine the scope (grouping) of a nodeid.
 

cardano_node_tests/tests/common.py

@@ -134,7 +134,6 @@
 
 
 def hypothesis_settings(max_examples: int = 100) -> tp.Any:
-    # pylint: disable=import-outside-toplevel
     import hypothesis
 
     return hypothesis.settings(

cardano_node_tests/tests/conftest.py

@@ -1,4 +1,3 @@
-# pylint: disable=abstract-class-instantiated
 import json
 import logging
 import os
@@ -330,7 +329,6 @@ def session_autouse(
     testenv_setup_teardown: tp.Any,
 ) -> None:
     """Autouse session fixtures that are required for session setup and teardown."""
-    # pylint: disable=unused-argument,unnecessary-pass
 
 
 @pytest.fixture(scope="module")
@@ -369,7 +367,7 @@ def cluster_manager(
 ) -> tp.Generator[cluster_management.ClusterManager, None, None]:
     """Return instance of `cluster_management.ClusterManager`."""
     # Hide from traceback to make logs errors more readable
-    __tracebackhide__ = True  # pylint: disable=unused-variable
+    __tracebackhide__ = True
 
     cluster_manager_obj = cluster_management.ClusterManager(
         worker_id=worker_id, pytest_config=request.config
@@ -413,7 +411,6 @@ def function_autouse(
     respin_on_large_db: tp.Generator[None, None, None],
 ) -> None:
     """Autouse function fixtures that are required for each test setup and teardown."""
-    # pylint: disable=unused-argument,unnecessary-pass
 
 
 @pytest.fixture

cardano_node_tests/tests/kes.py

@@ -35,7 +35,6 @@ def check_kes_period_info_result(  # noqa: C901
 
     When `pool_num` is specified, prometheus metrics are checked.
     """
-    # pylint: disable=too-many-branches
     output_scenario = "unknown"
     errors = []
 

cardano_node_tests/tests/test_blocks.py

@@ -53,7 +53,6 @@ def test_pool_blocks(  # noqa: C901
         * compare log records with ledger state dump
         * (optional) check minted blocks in db-sync
         """
-        # pylint: disable=unused-argument
         cluster, pool_name = cluster_use_pool
         pool_short_name = f"{pool_name.replace('node-', '')}"
         temp_template = common.get_test_id(cluster)
@@ -213,7 +212,6 @@ def test_unstable_stake_distribution(
 
         Expect failure.
         """
-        # pylint: disable=unused-argument
         common.get_test_id(cluster)
 
         pool_name = cluster_management.Resources.POOL3
@@ -280,7 +278,6 @@ def test_block_production(  # noqa: C901
            - each epoch save block production data to sqlite db
            - transfer funds between multiple addresses to create activity
         """
-        # pylint: disable=too-many-statements
         temp_template = common.get_test_id(cluster)
         rand = clusterlib.get_rand_str(5)
         num_epochs = int(os.environ.get("BLOCK_PRODUCTION_EPOCHS") or 50)

cardano_node_tests/tests/test_cli.py

@@ -955,7 +955,6 @@ def _check_stake_snapshot(  # noqa: C901
         option: str,
         temp_template: str,
     ):
-        # pylint: disable=too-many-branches,too-many-statements
         pool_ids = cluster_obj.g_query.get_stake_pools()
         if not pool_ids:
             pytest.skip("No stake pools are available.")
@@ -1264,7 +1263,6 @@ def test_ping_localhost(
         cluster: clusterlib.ClusterLib,
     ):
         """Test `cardano-cli ping` on local node using host and port."""
-        # pylint: disable=unused-argument
         common.get_test_id(cluster)
 
         count = 5
@@ -1309,7 +1307,6 @@ def test_ping_unix_socket(
         cluster: clusterlib.ClusterLib,
     ):
         """Test `cardano-cli ping` on local node using unix socket."""
-        # pylint: disable=unused-argument
         common.get_test_id(cluster)
         count = 5
         ignore_file_id = "ping_unix_socket"
@@ -1374,7 +1371,6 @@ def test_slot_number(
         cluster: clusterlib.ClusterLib,
     ):
         """Test `query slot-number`."""
-        # pylint: disable=unused-argument
         common.get_test_id(cluster)
 
         timestamp = datetime.datetime.now(datetime.timezone.utc)
@@ -1398,7 +1394,6 @@ def test_slot_number_invalid_format(
 
         Expect failure.
         """
-        # pylint: disable=unused-argument
         common.get_test_id(cluster)
 
         timestamp_str = datetime.datetime.now(datetime.timezone.utc).strftime("%Y-%m-%d")
@@ -1421,7 +1416,6 @@ def test_slot_number_out_of_range(
 
         Expect failure.
         """
-        # pylint: disable=unused-argument
         common.get_test_id(cluster)
 
         now = datetime.datetime.now(datetime.timezone.utc)

cardano_node_tests/tests/test_configuration.py

@@ -1,6 +1,5 @@
 """Tests for node configuration."""
 
-# pylint: disable=abstract-class-instantiated
 import json
 import logging
 import pathlib as pl

cardano_node_tests/tests/test_dbsync.py

@@ -121,7 +121,6 @@ def test_table_names(self, cluster: clusterlib.ClusterLib):
     @pytest.mark.smoke
     def test_blocks(self, cluster: clusterlib.ClusterLib):  # noqa: C901
         """Check expected values in the `block` table in db-sync."""
-        # pylint: disable=too-many-branches
         common.get_test_id(cluster)
 
         tip = cluster.g_query.get_tip()

cardano_node_tests/tests/test_env_network_id.py

@@ -68,7 +68,6 @@ def skip_on_no_env(
     set_network_id_env: None,  # noqa: ARG001
 ) -> None:
     """Skip test if `CARDANO_NODE_NETWORK_ID` is not available."""
-    # pylint: disable=unused-argument
     try:
         cluster.g_query.get_tip()
     except clusterlib.CLIError as exc:
@@ -100,7 +99,6 @@ def payment_addrs(
     cluster: clusterlib.ClusterLib,
 ) -> list[clusterlib.AddressRecord]:
     """Create new payment addresses."""
-    # pylint: disable=unused-argument
     addrs = common.get_payment_addrs(
         name_template=common.get_test_id(cluster),
         cluster_manager=cluster_manager,
@@ -126,7 +124,6 @@ def test_query_protocol_state(
         cluster: clusterlib.ClusterLib,
     ):
         """Test `query protocol-state`."""
-        # pylint: disable=unused-argument
         common.get_test_id(cluster)
         state = cluster.g_query.get_protocol_state()
         assert "lastSlot" in state
@@ -141,7 +138,6 @@ def test_query_stake_distribution(
         cluster: clusterlib.ClusterLib,
     ):
         """Test `query stake-distribution`."""
-        # pylint: disable=unused-argument
         common.get_test_id(cluster)
         distrib = cluster.g_query.get_stake_distribution()
         assert next(iter(distrib)).startswith("pool")
@@ -156,7 +152,6 @@ def test_query_protocol_params(
         cluster: clusterlib.ClusterLib,
     ):
         """Test `query protocol-parameters`."""
-        # pylint: disable=unused-argument
         common.get_test_id(cluster)
         protocol_params = cluster.g_query.get_protocol_params()
         assert "protocolVersion" in protocol_params
@@ -171,7 +166,6 @@ def test_query_pool_state(
         cluster: clusterlib.ClusterLib,
     ):
         """Test `query pool-state`."""
-        # pylint: disable=unused-argument
         common.get_test_id(cluster)
         cluster.g_query.get_pool_state(stake_pool_id=POOL_ID)
 
@@ -185,7 +179,6 @@ def test_query_stake_addr_info(
         cluster: clusterlib.ClusterLib,
     ):
         """Test `query stake-address-info`."""
-        # pylint: disable=unused-argument
         common.get_test_id(cluster)
         cluster.g_query.get_stake_addr_info(stake_addr=STAKE_ADDR)
 
@@ -207,7 +200,6 @@ def test_build_transfer_funds(
         * send funds from 1 source address to 1 destination address
         * check expected balances for both source and destination addresses
         """
-        # pylint: disable=unused-argument
         temp_template = common.get_test_id(cluster)
 
         src_addr = payment_addrs[0]
@@ -272,7 +264,6 @@ def test_neg_query_protocol_state(
 
         Expect failure.
         """
-        # pylint: disable=unused-argument
         common.get_test_id(cluster)
 
         _setup_scenarios(cluster_obj=cluster, env_scenario=env_scenario, arg_scenario=arg_scenario)
@@ -303,7 +294,6 @@ def test_neg_query_stake_distribution(
 
         Expect failure.
         """
-        # pylint: disable=unused-argument
         common.get_test_id(cluster)
 
         _setup_scenarios(cluster_obj=cluster, env_scenario=env_scenario, arg_scenario=arg_scenario)
@@ -333,7 +323,6 @@ def test_neg_query_protocol_params(
 
         Expect failure.
         """
-        # pylint: disable=unused-argument
         common.get_test_id(cluster)
 
         _setup_scenarios(cluster_obj=cluster, env_scenario=env_scenario, arg_scenario=arg_scenario)
@@ -363,7 +352,6 @@ def test_neg_query_pool_state(
 
         Expect failure.
         """
-        # pylint: disable=unused-argument
         common.get_test_id(cluster)
 
         _setup_scenarios(cluster_obj=cluster, env_scenario=env_scenario, arg_scenario=arg_scenario)
@@ -393,7 +381,6 @@ def test_neg_query_stake_addr_info(
 
         Expect failure.
         """
-        # pylint: disable=unused-argument
         common.get_test_id(cluster)
 
         _setup_scenarios(cluster_obj=cluster, env_scenario=env_scenario, arg_scenario=arg_scenario)
@@ -427,7 +414,6 @@ def test_neg_build_transfer_funds(
 
         Expect failure.
         """
-        # pylint: disable=unused-argument
         temp_template = common.get_test_id(cluster)
 
         _setup_scenarios(cluster_obj=cluster, env_scenario=env_scenario, arg_scenario=arg_scenario)